[Bug 52717] New: dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52717

Bug ID: 52717
           Summary: dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]

dxgi:dxgi fails on Windows 7 and in the 64-bit Windows 8.1 because
DXGI_STATUS_OCCLUDED != S_OK:

dxgi.c:2128: Test failed: Got unexpected hr 0x87a0001.
dxgi.c:3576: Test failed: Got unexpected hr 0x87a0001.

https://test.winehq.org/data/patterns.html#dxgi:dxgi

This is because of the commit below changed a couple of SUCCEEDED(hr) to hr ==
S_OK:

commit 65ff2098826bb9944b872251b1c9543bbbe6f488
Author:     Eric Pouech 
AuthorDate: Fri Mar 18 16:59:29 2022 +0100

dxgi/tests: Build without -DWINE_NO_LONG_TYPES.

Signed-off-by: Eric Pouech 
    Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

So the question is: should these two checks be reverted to SUCCEEDED(hr), or
should we investigate why we get DXGI_STATUS_OCCLUDED on w7pro64-64, w7u*,
win81_cw-gtx560-64 and win81_cw-rx460-64 ?

[Bug 52717] dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52717

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |65ff2098826bb9944b872251b1c
                   |                            |9543bbbe6f488
           Keywords|                            |regression, source,
                   |                            |testcase

[Bug 52717] dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52717

--- Comment #1 from François Gouget  ---
Oh, also SUCCEEDED(DXGI_STATUS_OCCLUDED) == true which is why it worked before.

[Bug 52717] dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52717

--- Comment #2 from Henri Verbeet  ---
I've sent https://source.winehq.org/patches/data/230607 for this. These can
legitimately occur for fullscreen swapchains if either there's another window
in front, or the swapchain window gets e.g. minimised.

[Bug 52717] dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52717

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |f2afa424769de3517cf5ea3e171
                   |                            |de36d06a5dc68
             Status|NEW                         |RESOLVED

--- Comment #3 from François Gouget  ---
Henri fixed this bug:

commit f2afa424769de3517cf5ea3e171de36d06a5dc68
Author: Henri Verbeet 
Date:   Wed Mar 23 17:27:37 2022 +0100

dxgi/tests: Accept DXGI_STATUS_OCCLUDED as result when creating fullscreen
swapchains.

These can legitimately occur in some circumstances, and shouldn't otherwise
    affect these tests.

Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

[Bug 52717] dxgi:dxgi fails because DXGI_STATUS_OCCLUDED != S_OK

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52717

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 7.5.