http://bugs.winehq.org/show_bug.cgi?id=29081
Bug #: 29081 Summary: Drag and Drop: Duplicate entries in winamp playlist window Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv AssignedTo: wine-bugs@winehq.org ReportedBy: anwetli@hotmail.com Classification: Unclassified
Created attachment 37475 --> http://bugs.winehq.org/attachment.cgi?id=37475 Wine log for xdnd
Operating System: Kubuntu 10.04 LTS with KDE 4.4.5 / i386 / nvidia grafics driver
Bug is related to winamp, a windows music player (www.winamp.com). Other applications may be affected by this bug.
Problem: Every File drag and dropped to the playlist-window of winamp will duplicated. It generates double entries for every file dropped to the playlist-window.
Version of wine: This bug has been introduced since version 1.3x. In wine 1.2 everything is fine.
Details: If you drag drop a file to the main window of winamp, no duplicate entries will be generated. But if you drop a file to the playlist-window (a window within the winamp application), you will get two entries (duplicated). So it seems to me that the bug is connected to how the drag drop code specifies the target window.
Wine trace (WINEDEBUG=xdnd wine winamp.exe) last lines in wine 1.2x: ---------------------------- trace:xdnd:X11DRV_XDND_DropEvent trace:xdnd:X11DRV_XDND_SendDropFiles Sending WM_DROPFILES: hWnd(0x0x10056) 0x1356a4(L"E:\x.mp3") trace:xdnd:X11DRV_XDND_FreeDragDropOp
last lines in wine 1.3x: ---------------------------- trace:xdnd:X11DRV_XDND_DropEvent trace:xdnd:X11DRV_XDND_SendDropFiles Sending WM_DROPFILES: hWnd(0x0x101e0) 0x1abe6c(L"Z:\home\angel\Desktop\x.mp3") trace:xdnd:create_stream_from_map size 4096 trace:xdnd:XDNDDATAOBJECT_QueryGetData (0x68a29320, 0x7adbb4={.tymed=0x1, .dwAspect=1, .cfFormat=49326} trace:xdnd:XDNDDATAOBJECT_QueryGetData application didn't find UniformResourceLocator trace:xdnd:XDNDDATAOBJECT_QueryGetData (0x68a29320, 0x7adba0={.tymed=0x1, .dwAspect=1, .cfFormat=15} trace:xdnd:XDNDDATAOBJECT_QueryGetData application found CF_HDROP trace:xdnd:XDNDDATAOBJECT_GetData (0x68a29320, 0x7adba0, 0x7adbd8) trace:xdnd:XDNDDATAOBJECT_GetData application is looking for CF_HDROP trace:xdnd:XDNDDATAOBJECT_QueryGetData (0x68a29320, 0x7adba0={.tymed=0x1, .dwAspect=1, .cfFormat=15} trace:xdnd:XDNDDATAOBJECT_QueryGetData application found CF_HDROP trace:xdnd:X11DRV_XDND_DropEvent drop succeeded trace:xdnd:X11DRV_XDND_FreeDragDropOp
It seems that with wine 1.3 new code for a better drag and drop functionality has been introduced. But also leading to a bug with duplicate entries.
Maybe someone can fix this? Would be nice :-)
http://bugs.winehq.org/show_bug.cgi?id=29081
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |00cpxxx@gmail.com Version|unspecified |20050930 Ever Confirmed|0 |1
--- Comment #1 from Bruno Jesus 00cpxxx@gmail.com 2011-11-19 12:49:28 CST --- I can confirm this issue in 1.3.33.
http://bugs.winehq.org/show_bug.cgi?id=29081
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #2 from Austin English austinenglish@gmail.com 2013-12-05 20:06:50 CST --- Is this still an issue in current (1.7.7 or newer) wine?
(In reply to comment #0)
Version of wine: This bug has been introduced since version 1.3x. In wine 1.2 everything is fine.
Since this is a regression, please run a regression test (if it's not already fixed): http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=29081
--- Comment #3 from Bruno Jesus 00cpxxx@gmail.com 2013-12-05 20:13:51 CST --- Still in wine 1.7.7.
http://bugs.winehq.org/show_bug.cgi?id=29081
--- Comment #4 from Austin English austinenglish@gmail.com 2013-12-05 21:50:53 CST --- This is your friendly reminder that there has been no bug activity for 2 years. Is this still an issue in current (1.7.7 or newer) wine? If so, please attach the terminal output in 1.7.7 (see http://wiki.winehq.org/FAQ#get_log).
https://bugs.winehq.org/show_bug.cgi?id=29081
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |ABANDONED
--- Comment #5 from Austin English austinenglish@gmail.com --- (In reply to Austin English from comment #4)
This is your friendly reminder that there has been no bug activity for 2 years. Is this still an issue in current (1.7.7 or newer) wine? If so, please attach the terminal output in 1.7.7 (see http://wiki.winehq.org/FAQ#get_log).
Abandoned.
https://bugs.winehq.org/show_bug.cgi?id=29081
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Austin English austinenglish@gmail.com --- Closing.
https://bugs.winehq.org/show_bug.cgi?id=29081
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|CLOSED |REOPENED URL| |http://www.oldversion.com/w | |indows/winamp-2-95 Resolution|ABANDONED |---
--- Comment #7 from Bruno Jesus 00cpxxx@gmail.com --- Still in wine 1.7.37.
https://bugs.winehq.org/show_bug.cgi?id=29081
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gyebro69@gmail.com
--- Comment #8 from Béla Gyebrószki gyebro69@gmail.com --- I can't reproduce the problem, tried with Wine 1.4/1.6 and 1.7.43. Maybe I missed something in the bug description and performed the wrong steps to reproduce the problem.
I installed Winamp 2.95 with default settings. After starting I clicked the open file button on the winamp interface which presented a file selection dialog. I used drag&drop with the mouse to add some mp3 files to the playlist window: each track appears only once for me. Is that the way how to hit this bug?
wine-1.7.43-166-g39d71c5 Fedora 21 XOrg 1.16.3 XFCE 4.10
https://bugs.winehq.org/show_bug.cgi?id=29081
--- Comment #9 from Bruno Jesus 00cpxxx@gmail.com --- Created attachment 51575 --> https://bugs.winehq.org/attachment.cgi?id=51575 doubled files screenshot
I can still reproduce in wine 1.7.44. It's very simple, I even upgraded to XFCE 4.12. My test is:
1 - Install winamp295.exe in a clean prefix with default settings (it will automatically run after installation) 2 - Open Thunar in a folder with some mp3; 3 - Select random mp3 files and drag & drop to winamp. 4 - Expect to see a single entry for each file, actually I see like in the screenshot (3 files dragged, 6 files added).
winamp295.exe SHA1 d859a19d4c614a789d302f4edd2e4df65a2c0869
I only have XFCE and Thunar as file manager, so I didn't test in any other WM.
https://bugs.winehq.org/show_bug.cgi?id=29081
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov@gmail.com Version|20050930 |1.3.1 Regression SHA1| |1afc16e96201d52bd6de1e0c2dd | |d033e94a56989
--- Comment #10 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Bruno Jesus from comment #9)
Created attachment 51575 [details] doubled files screenshot
I can still reproduce in wine 1.7.44. It's very simple, I even upgraded to XFCE 4.12. My test is:
1 - Install winamp295.exe in a clean prefix with default settings (it will automatically run after installation) 2 - Open Thunar in a folder with some mp3; 3 - Select random mp3 files and drag & drop to winamp. 4 - Expect to see a single entry for each file, actually I see like in the screenshot (3 files dragged, 6 files added).
winamp295.exe SHA1 d859a19d4c614a789d302f4edd2e4df65a2c0869
I only have XFCE and Thunar as file manager, so I didn't test in any other WM.
Thanks for the "how-to", I can reproduce it now.
The result of the regression test:
1afc16e96201d52bd6de1e0c2ddd033e94a56989 is the first bad commit commit 1afc16e96201d52bd6de1e0c2ddd033e94a56989 Author: Damjan Jovanovic damjan.jov@gmail.com Date: Mon Aug 16 21:11:08 2010 +0200
winex11.drv: Implement the DataObject for dragging from X and dropping to OLE.
https://bugs.winehq.org/show_bug.cgi?id=29081
--- Comment #11 from Damjan Jovanovic damjan.jov@gmail.com --- It's possible that some apps accept both OLE drag and drag and WM_DROPFILES, and since we do both, the files appear to be dropped twice :-).
Maybe we shouldn't send WM_DROPFILES if the files were successfully dropped via OLE first? Let me see if I can make a quick patch for you to try.
https://bugs.winehq.org/show_bug.cgi?id=29081
--- Comment #12 from Damjan Jovanovic damjan.jov@gmail.com --- Created attachment 51584 --> https://bugs.winehq.org/attachment.cgi?id=51584 Only send WM_DROPFILES when OLE dnd fails
Please try this patch, both with winamp and (lots of) other apps, and report back.
https://bugs.winehq.org/show_bug.cgi?id=29081
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Status|REOPENED |NEW
--- Comment #13 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to Damjan Jovanovic from comment #12)
Created attachment 51584 [details] Only send WM_DROPFILES when OLE dnd fails
Please try this patch, both with winamp and (lots of) other apps, and report back.
Yes, the patch fixes the issue. Thanks =)
https://bugs.winehq.org/show_bug.cgi?id=29081
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #14 from super_man@post.com --- Still an issue without patches 1.7.48
https://bugs.winehq.org/show_bug.cgi?id=29081
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b78a9f1aa14d2d43ee7e62f617a | |3c7bdf576dd4b Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #15 from Bruno Jesus 00cpxxx@gmail.com --- Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=b78a9f1aa14d2d43ee7e62f617...
Thanks Damjan
https://bugs.winehq.org/show_bug.cgi?id=29081
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.50.
-
wine-bugs＠winehq.org