[Bug 41715] New: winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

Bug ID: 41715
           Summary: winhttp:winhttp test regression
                    (test_secure_connection)
           Product: Wine
           Version: 1.9.8
          Hardware: x86
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winhttp
          Assignee: [e-mail]
          Reporter: [e-mail]

Since the commit below, the Windows XP SP2 and lower machines have two new test
failures:

winhttp.c:998: Test failed: setting client cert context returned 0 (87)
winhttp.c:1024: Test failed: failed to set client cert context 87

See:
https://test.winehq.org/data/tests/winhttp:winhttp.html

This can be seen on the following machines: fg-winxp_1sp, fg-winxp_2sp,
fg-winxp_2spie7, fgtb-fgtbwinxp (also SP2).

[Bug 41715] winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

--- Comment #1 from Hans Leidekker  ---
Created attachment 56133
  --> https://bugs.winehq.org/attachment.cgi?id=56133
patch

Can you try this?

[Bug 41715] winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://test.winehq.org/dat
                   |                            |a/tests/winhttp:winhttp.htm
                   |                            |l
           Keywords|                            |download, regression,
                   |                            |source, testcase

--- Comment #2 from François Gouget  ---
Forgot to actually mention the commit, for future reference:

commit e27ff36fc678dcb27372aace5fc2e25688854828
Author: Jacek Caban 
Date:   Thu Oct 6 14:05:32 2016 +0200

winhttp: Added WINHTTP_OPTION_CLIENT_CERT_CONTEXT option stub.

Signed-off-by: Jacek Caban 
    Signed-off-by: Hans Leidekker 
    Signed-off-by: Alexandre Julliard

[Bug 41715] winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.9.8                       |1.9.21

[Bug 41715] winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

--- Comment #3 from Hans Leidekker  ---
Should be fixed by bfa0e4b840075857e1c6850aa6a99b98e052e6cf. Note that there is
still one failure left which wasn't introduced by the regression patch.

[Bug 41715] winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |bfa0e4b840075857e1c6850aa6a
                   |                            |99b98e052e6cf

--- Comment #4 from Hans Leidekker  ---
Fixed by bfa0e4b840075857e1c6850aa6a99b98e052e6cf.

[Bug 41715] winhttp:winhttp test regression (test_secure_connection)

https://bugs.winehq.org/show_bug.cgi?id=41715

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 2.0-rc2.