[Bug 19760] New: SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Summary: SiSoftware Sandra 2009.SP3c installer causes a page
                    fault
           Product: Wine
           Version: 1.1.27
          Platform: PC
               URL: http://download.cnet.com/SiSoftware-Sandra/3000-2086_4
                    -10556571.html
        OS/Version: Linux
            Status: NEW
          Keywords: download, Installer
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=23136)
 --> (http://bugs.winehq.org/attachment.cgi?id=23136)
wine-1.1.27-221-g4e1a4ec console output

SiSoftware Sandra 2009.SP3c installer causes a page fault apparently in rpcrt4.
The installation claims to complete despite this, but there is an unhandled
exception when trying to start Sandra, and I can not tell if this is the
reason.

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |rpc

--- Comment #1 from Juan Lang   2009-08-17 10:29:34 ---
> From the crash log:

=>0 0xb7d76323 strlen+0x33() in libc.so.6 (0x0094e7a8)
  1 0x7ee3ad03 RpcEpRegisterW+0x40(IfSpec=0x407018, BindingVector=0x14dac0,
UuidVector=(nil), Annotation=(nil))
[/home/test/wine-git/dlls/rpcrt4/rpc_epmap.c:292] in rpcrt4 (0x0094e7d8)

Looking at rpc_epmap.c, RpcEpRegisterW calls RpcEpRegisterA.  Note that both
Uuidvector and Annotation are NULL.  Taking a gander at RpcEpRegisterA:

for (i = 0; i < BindingVector->Count; i++)
  {
      unsigned j;
      RpcBinding* bind = BindingVector->BindingH[i];
      for (j = 0; j < (UuidVector ? UuidVector->Count : 1); j++)
      {
          int len = strlen((char *)Annotation);

That is, Annotation is always dereferenced, even if it's NULL, while UuidVector
is checked whether it might be NULL.  So I'm going to go out on a limb and say
the bug is in rpcrt4's RpcEpRegisterA, but it need some tests to fix it even if
I'm correct.

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

--- Comment #2 from Ken Sharp   2009-08-17 17:47:41 ---
Created an attachment (id=23156)
 --> (http://bugs.winehq.org/attachment.cgi?id=23156)
wine-1.1.27-266-gda1784b +rpc

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

--- Comment #3 from Juan Lang   2009-08-19 12:31:06 ---
Created an attachment (id=23181)
 --> (http://bugs.winehq.org/attachment.cgi?id=23181)
Patch

MSDN states that Annotation may be NULL or empty, and indeed that it's ignored
internally:

"Specify a null value or a null-terminated string ("\0") if there is no
annotation string.

The annotation string is used by applications for information only. RPC does
not use this string to determine which server instance a client communicates
with or for enumerating elements in the endpoint-map database."

This patch should fix it.  I'll combine it with a test patch once someone
confirms that the test passes on Windows.  Nevertheless, you might give this
another try with the attached patch just to make sure it fixes it for you.

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Juan Lang   2009-08-20 13:05:46 ---
Fixed by commit d82cbcf049fb5b85ab69549135bf28229dc769d6.

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard   2009-08-21 13:01:29 ---
Closing bugs fixed in 1.1.28.

[Bug 19760] SiSoftware Sandra 2009.SP3c installer causes a page fault

http://bugs.winehq.org/show_bug.cgi?id=19760

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |d82cbcf049fb5b85ab69549135b
                   |                            |f28229dc769d6