[Bug 39805] New: GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Bug ID: 39805
           Summary: GTAIV rendering is broken
           Product: Wine
           Version: 1.8-rc4
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 53132
  --> https://bugs.winehq.org/attachment.cgi?id=53132
Broken rendering screenshot

After commit 1ca9dfc8ee25f4ae188fdacd4d3d56046cef8003 wined3d: Prepare GL
resources before calling context_apply_fbo_state, GTAIV prints lots of errors
like the following:

err:d3d:wined3d_debug_callback 0x415e120: "GL_INVALID_FRAMEBUFFER_OPERATION
error generated. Operation is not valid because a bound framebuffer is not
framebuffer complete.".
err:d3d:wined3d_debug_callback 0x415e120: "GL_INVALID_OPERATION error
generated. Calling glEnd from the current immediate mode state is invalid.
Check glBegin() / glEnd() pairs.".
err:d3d_shader:shader_glsl_deselect_depth_blt >>>>>>>>>>>>>>>>>
GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glUseProgram @ glsl_shader.c /
7447

And this results in broken rendering.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Ruslan Kabatsayev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |1ca9dfc8ee25f4ae188fdacd4d3
                   |                            |d56046cef8003

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

--- Comment #1 from Ruslan Kabatsayev  ---
Created attachment 53133
  --> https://bugs.winehq.org/attachment.cgi?id=53133
Screenshot before the regression

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Ruslan Kabatsayev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Ruslan Kabatsayev  ---
Forgot to mention, I'm on Linux 3.12.18 AMD64; video card is NVIDIA Corporation
GM107 [GeForce GTX 750 Ti] (rev a2), nvidia binary driver 340.46.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

--- Comment #3 from Stefan Dösinger  ---
Are you using AlwaysOffscreen=disabled by any chance?

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

--- Comment #4 from Ruslan Kabatsayev  ---
(In reply to Stefan Dösinger from comment #3)
> Are you using AlwaysOffscreen=disabled by any chance?

Yes, I have it set (due to bug 31393).

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

--- Comment #5 from Stefan Dösinger  ---
Yeah, setting this setting isn't wrong and things are supposed to work with it.
The non-default codepath explains why the problem wasn't noticed earlier
though. I'll look into this in the next days.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |[e-mail]

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

--- Comment #6 from Stefan Dösinger  ---
Created attachment 53435
  --> https://bugs.winehq.org/attachment.cgi?id=53435
wined3d: Prepare GL textures in surface_load_ds_location.

Can you give this patch a try? It is a semi-educated guess in the dark, based
on the info from this bug because I currently don't have access to the game.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

--- Comment #7 from Ruslan Kabatsayev  ---
(In reply to Stefan Dösinger from comment #6)
This makes it work.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |638f6c1ac81a4be0ff3f290a81b
                   |                            |c5d3472262839
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Stefan Dösinger  ---
Should be fixed by 638f6c1ac81a4be0ff3f290a81bc5d3472262839, please retest.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.8.x

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.2.

[Bug 39805] GTAIV rendering is broken

https://bugs.winehq.org/show_bug.cgi?id=39805

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #10 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.1.