https://bugs.winehq.org/show_bug.cgi?id=53891
Bug ID: 53891 Summary: user32:msg - test_swp_paint_regions() fails on Windows 7 Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com
user32:msg - test_swp_paint_regions() fails on Windows 7:
msg.c:9307: Test failed: 9417: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9417: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9417: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9417: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9417: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = +0: Parent update region shall match expected region msg.c:9370: Test failed: 9417: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = +0: Child update region shall match expected region msg.c:9307: Test failed: 9417: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9417: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9417: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9417: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9417: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = +0: Parent update region shall match expected region msg.c:9370: Test failed: 9417: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = +0: Child update region shall match expected region msg.c:9307: Test failed: 9418: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9418: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9418: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9418: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9418: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9418: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9418: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9419: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9419: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9419: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9419: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9419: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9419: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9419: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region msg.c:9307: Test failed: 9420: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9420: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Child update region shall match expected region msg.c:9307: Test failed: 9420: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region msg.c:9370: Test failed: 9420: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Child update region shall match expected region
See: https://test.winehq.org/data/patterns.html#user32:msg
These failures started as soon as the test was introduced in the following commit:
commit 5005bb970f14745ff0fe70d5d02d87013f543136 Author: Jinoh Kang jinoh.kang.kr@gmail.com Date: Mon Jun 13 02:22:57 2022 +0900
user32/tests: Test for window exposure behaviours.
https://bugs.winehq.org/show_bug.cgi?id=53891
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |5005bb970f14745ff0fe70d5d02 | |d87013f543136 CC| |jinoh.kang.kr@gmail.com Keywords| |regression, source, | |testcase
https://bugs.winehq.org/show_bug.cgi?id=53891
--- Comment #1 from Jinoh Kang jinoh.kang.kr@gmail.com --- The cause of bug 53891 is likely to be the same as the one behind bug 54202. I checked the final screenshot of testbot batch test run, and found a handful of firewall alerts and crash report dialogs.
https://bugs.winehq.org/show_bug.cgi?id=53891
--- Comment #2 from François Gouget fgouget@codeweavers.com --- Note that the firewall alerts are very common but usually don't cause these user32:msg failures.
To take some recent examples: * 2023-04-01 w7u_2qxl-32 has the firewall dialog but not these failures https://testbot.winehq.org/JobDetails.pl?Key=131380&s101=1#k101
* 2023-04-01 w7pro64-64 has the firewall dialog and more and these failures https://testbot.winehq.org/JobDetails.pl?Key=131383&s101=1#k101
* 2023-03-31 w7u_de has only the firewall dialog and these failures https://testbot.winehq.org/JobDetails.pl?Key=131316&s102=1#k102
So the firewall and other dialogs appear to be red herrings.
Side note: you can find a bunch of runs with these failures there: https://testbot.winehq.org/FailureDetails.pl?Key=296
https://bugs.winehq.org/show_bug.cgi?id=53891
--- Comment #3 from Jinoh Kang jinoh.kang.kr@gmail.com --- Fixed in fa038c3c3714cd1293e4de6aad44c1440ab845b3. No failures since September 1st.
https://bugs.winehq.org/show_bug.cgi?id=53891
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #4 from Zeb Figura z.figura12@gmail.com --- (In reply to François Gouget from comment #2)
Side note: you can find a bunch of runs with these failures there: https://testbot.winehq.org/FailureDetails.pl?Key=296
Looking just now, this link reports one failure.
https://bugs.winehq.org/show_bug.cgi?id=53891
--- Comment #5 from Jinoh Kang jinoh.kang.kr@gmail.com ---
Side note: you can find a bunch of runs with these failures there: https://testbot.winehq.org/FailureDetails.pl?Key=296
Reporting successful reproduction:
* Identical symptom: unexpectedly empty update region, as reported by test_swp_paint_regions() * Identical platform version: Windows 7 (w7*). * Identical observation of relevant environment state: desktop creation and switching was successful, so firewall alert dialogs are unrelated.
Further actions:
- Capture the screenshot at the exact point in time when the relevant failure has happened. - Test hypothesis 1: the window was obscured by another window. - Test hypothesis 2: the window was created hidden or minimized. - Test hypothesis 3: a Windows API call failed, but its error status is not being checked or flagged. - Test hypothesis 4: transient failure of environment or interference from other USER-related programs.
https://bugs.winehq.org/show_bug.cgi?id=53891
--- Comment #6 from Jinoh Kang jinoh.kang.kr@gmail.com --- I think this is fixed in 1d401e1a395e26d0f5a297ddc42321863d27bfc9.
Hypothesis 2 "window is invisible" confirmed after repeated testing, with 99% reproduction rate in ~1,000 iterations.
Triagers/admins: let's mark this fixed, whilist keeping the pattern in testbot to reopen on next failure.
https://bugs.winehq.org/show_bug.cgi?id=53891
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1d401e1a395e26d0f5a297ddc42 | |321863d27bfc9 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #7 from Gijs Vermeulen gijsvrm@gmail.com --- Marking FIXED by 1d401e1a395e26d0f5a297ddc42321863d27bfc9, feel free to reopen if you can still reproduce.
https://bugs.winehq.org/show_bug.cgi?id=53891
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 10.0-rc6.