[Bug 29251] New: Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

Bug #: 29251
           Summary: Thousands of identical fixme lines in console output
           Product: Wine
           Version: 1.3.34
          Platform: x86
               URL: http://www.winuae.net/files/InstallWinUAE2200.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Hi,

This issue is shown with WinUAE, an Amiga emulator. It does happen with the
latest WinUAE release (2.3.3), but is easier to reproduce with earlier
versions.

With certain settings, thousands of identical fixme messages are "spammed" to
the console output:
  fixme:d3d_surface:surface_cpu_blt Filter WINED3DTEXF_LINEAR not supported in
software blit.

It would be nice if the fixme could be printed once only. I tested Wine 1.3.34.
To reproduce:

- If using Wine 1.3.28 or later, first do "winetricks ddr=gdi" for there to be
any emulator output at all (see bug 29245).
 - Download an example disk image, e.g.
http://www.amigaemulator.org/files/rsi1.adf.gz
 - Download and run the WinUAE 2.2.0 installer from
http://www.winuae.net/files/InstallWinUAE2200.exe
 - Run winuae.exe
 - Click OK at the dialog box about system ROMs. The WinUAE Properties window
opens.
 - Click Floppy drives in the tree view at the left of the window.
 - Click the ... button to the right of the DF0: entry (at top right of
window), and select the rsi1.adf.gz file.
 - Click Start. The emulation begins.
 - After a while, press F12 to bring up the WinUAE Properties window. Click
Filter in the tree view. Change Filter Settings from none to Null filter.
 - To work around Wine bug 10643, click in the emulation window and press F12.
 - Click OK to continue emulation.
 - Notice how the fixme is printed over and over.

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

Mark K  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Austin English  2011-12-06 12:23:22 CST ---
FIXME's are not bugs. Use 'WINEDEBUG=-all' or similar.

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

--- Comment #2 from Mark K  2011-12-07 06:44:21 CST ---
Could you reopen this with Importance set to Enhancement then? There have been
many other cases where "noisy" fixmes have been dealt with, so I think this is
a valid enhancement request.

Some examples of previous similar commits; I've marked ones you committed
yourself with (*):
cmd: Quiet a noisy 'FOR /F' fixme.
d3dx9_36: Quiet a noisy fixme.
tapi32: Quiet a few noisy fixme's.
xinput1_3: Quiet a noisy fixme.
uxtheme: Quiet a noisy fixme.
imm32: Quiet ImmGetOpenStatus fixme. (*)
dwmapi: Silence a noisy fixme.
mscms: Quiet a noisy fixme.
ddraw: Display fixme only once in IDirectDrawImpl_WaitForVerticalBlank.
ddraw: Display fixme only once in IDirect3DVertexBufferImpl_Optimize.
gdi32: Quiet a noisy fixme. (*)
wininet: Quiet a noisy fixme. (*)
advapi32: Quiet a noisy fixme. (*)

Another noisy d3d-related fixme is this one:
fixme:d3d_surface:wined3d_surface_blt Blit clipping not implemented.

To demonstrate that, I booted a Lubuntu 11.10 CD (which uses the nouveau driver
on my system):
- Run WinUAE 2.3.3
- Change filter type from Null filter to None.
- Start emulation.
- Drag the emulation window until it is partly off-screen.
- Wine prints the same fixme over and over:
    fixme:d3d_surface:wined3d_surface_blt Blit clipping not implemented.

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Vitaliy Margolen  2011-12-07 09:10:42 CST ---
(In reply to comment #2)
> Could you reopen this with Importance set to Enhancement then?

No. If you have few particular fixmes that are being printed way too many times
- open separate bugs for them.

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

--- Comment #4 from Mark K  2011-12-07 10:30:08 CST ---
That's what this report is for; in the description I mention that this fixme is
printed over and over:

fixme:d3d_surface:surface_cpu_blt Filter WINED3DTEXF_LINEAR not supported in
software blit

You could change the title to reflect that specific message if you want. I'll
open another bug for the noisy fixme I mentioned in comment 2.

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

--- Comment #5 from Austin English  2011-12-07 12:33:40 CST ---
(In reply to comment #2)
> Could you reopen this with Importance set to Enhancement then? There have been
> many other cases where "noisy" fixmes have been dealt with, so I think this is
> a valid enhancement request.

No, fixme's are not bugs in and of themselves, please don't file more.
> Some examples of previous similar commits; I've marked ones you committed
> yourself with (*):
> cmd: Quiet a noisy 'FOR /F' fixme.
> d3dx9_36: Quiet a noisy fixme.
> tapi32: Quiet a few noisy fixme's.
> xinput1_3: Quiet a noisy fixme.
> uxtheme: Quiet a noisy fixme.
> imm32: Quiet ImmGetOpenStatus fixme. (*)
> dwmapi: Silence a noisy fixme.
> mscms: Quiet a noisy fixme.
> ddraw: Display fixme only once in IDirectDrawImpl_WaitForVerticalBlank.
> ddraw: Display fixme only once in IDirect3DVertexBufferImpl_Optimize.
> gdi32: Quiet a noisy fixme. (*)
> wininet: Quiet a noisy fixme. (*)
> advapi32: Quiet a noisy fixme. (*)

Yes, I'm aware, though it's not worth opening a bug over, just send a 1 minute
patch.
> Another noisy d3d-related fixme is this one:
> fixme:d3d_surface:wined3d_surface_blt Blit clipping not implemented.

There was opposition to silencing it on irc, so I won't send a patch for this
(or bug 29264).

[Bug 29251] Thousands of identical fixme lines in console output

http://bugs.winehq.org/show_bug.cgi?id=29251

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |DUPLICATE

--- Comment #6 from Dmitry Timoshkov  2011-12-08 00:17:20 CST ---
It's rather a duplicate.

*** This bug has been marked as a duplicate of bug 15435 ***