[Bug 23112] New: flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

Summary: flash player install crashes
           Product: Wine
           Version: 1.2-rc2
          Platform: x86-64
               URL: http://fpdownload.macromedia.com/get/flashplayer/curre
                    nt/install_flash_player_ax.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download, Installer
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28726)
 --> (http://bugs.winehq.org/attachment.cgi?id=28726)
terminal output

Running winetrickstest today, I noticed that the flash sha1sum changed. Updated
to the latest, but it crashes on launch.

Terminal output attached.

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

--- Comment #1 from Austin English   2010-06-10 18:34:19 ---
Hm...only seems to happen if ~/.wine doesn't exist. If you run wineboot first,
it installs fine.

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

--- Comment #2 from Jeff Zaroyko   2010-06-12 22:55:01 ---
Crashes here for me too, seems to be some sort of race condition? With an
existing prefix, 4/5 times it will crash, other times it shows the installer
dialog and proceed normally.

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

--- Comment #3 from Alexandre Julliard   2010-06-23 13:36:09 ---
That's a bug in the installer, it calls GetTempFileName twice but deletes the
file first, so there is a possibility that both calls return the same file name
(in our case, this happens if the tick counter hasn't incremented yet).

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

--- Comment #4 from Rico   2010-06-23 15:35:07 ---
Probably GetTempFileName() should increment by call count and not by the time
(e.g. http://bugs2.winehq.org/attachment.cgi?id=21841)? Is there a reason why
the time is used? XP seems to use a static counter (see
http://www.winehq.org/pipermail/wine-devel/2008-December/071317.html for a
test) - not sure about other win versions.

Does this patch fix the problem?

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Alexandre Julliard   2010-06-24 11:16:19 ---
Should be fixed by 9f7bc109d20a07367875fcd6044dbaad41d9eb7e.

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2010-06-25 12:41:43 ---
Closing bugs fixed in 1.2-rc5.

[Bug 23112] flash player install crashes

http://bugs.winehq.org/show_bug.cgi?id=23112

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9f7bc109d20a07367875fcd6044
                   |                            |dbaad41d9eb7e
                 CC|                            |[e-mail]
          Component|-unknown                    |kernel32