[Bug 21494] New: wine(64) regedit foo.reg fails

http://bugs.winehq.org/show_bug.cgi?id=21494

Summary: wine(64) regedit foo.reg fails
           Product: Wine
           Version: 1.1.37
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: msvcrt
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Backtrace:
=>0 0x00007f0b7ab3cce1 read_i+0x20b()
[/home/austin/64-wine-git/dlls/msvcrt/file.c:1779] in msvcrt
(0x00007f0b7b3bee30)
  1 0x000000000000002c (0x00007f0b7b3bee30)
  2 0x00007f0b7da01660 in ld-linux-x86-64.so.2 (+0xd6660) (0x00007f0b7b3bee30)
  3 0x0000000000000200 (0x00007f0b7b3bee30)
  4 0x00007f0b7b3bee1c (0x00007f0b7b3bee30)
0x00007f0b7ab3cce1 read_i+0x20b
[/home/austin/64-wine-git/dlls/msvcrt/file.c:1779] in msvcrt: Disasm NIY

1779                if (bufstart[num_read-1] == '\r')

Changing num_read to DWORD_PTR fixes the crash, but that causes compiler
warnings. Probably an easy fix, but my brain is tired...

P.S., easy to test with:
$ WINE=/path/to/64bit/wine sh winetricks nocrashdialog

[Bug 21494] wine(64) regedit foo.reg fails

http://bugs.winehq.org/show_bug.cgi?id=21494

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]-
                   |                            |darmstadt.de

--- Comment #1 from Andrew Nguyen   2010-01-27 15:25:53 ---
Austin suspected that commit e6f1ae029e39d24ca3c56175df966ffb39ba532e was the
culprit, which is:

commit e6f1ae029e39d24ca3c56175df966ffb39ba532e
Author: Uwe Bonnes 
Date:   Sat Jan 16 17:24:19 2010 +0100

msvcrt: Handle CR at buffer boundary and test case.

Reverting this change allows the import to succeed.

[Bug 21494] wine(64) regedit foo.reg fails

http://bugs.winehq.org/show_bug.cgi?id=21494

--- Comment #2 from Uwe Bonnes   2010-01-27 15:50:10 ---
Austin,

probably we need to test for EOF first. I will try.

[Bug 21494] wine(64) regedit foo.reg fails

http://bugs.winehq.org/show_bug.cgi?id=21494

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Andrew Nguyen   2010-02-01 13:05:29 ---
The crash is fixed by commit 92ac665d3771f709d8ca8305eb974f57e0e1bcac.

[Bug 21494] wine(64) regedit foo.reg fails

http://bugs.winehq.org/show_bug.cgi?id=21494

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2010-02-05 11:39:21 ---
Closing bugs fixed in 1.1.38.