[Bug 33383] New: Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

Bug #: 33383
           Summary: Hiding application to Mac OS X Dock causes crash.
           Product: Wine
           Version: 1.5.28
          Platform: x86-64
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Now that the Mac OS X driver is implemented when hiding any application to the
Dock (via command+h) it crashes Wine. I'm using the latest "wine-revel" package
from Macports.

Thanks!

[Bug 33383] Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winemac.drv

[Bug 33383] Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Ken Thomases  2013-04-17 12:53:50 CDT ---
I am not able to reproduce this.  I tested using the wine-devel @1.5.28_0 port
from MacPorts on Mac OS X 10.6.8.  (I assume that "wine-revel" was a typo.)

I'm confused by what you're describing.  Command-H does not hide a Wine-hosted
program running under the Mac driver.  The key sequence is simply sent to the
program as an Alt-H key sequence.  (Supporting the ability to type Alt-H is why
Command-H isn't mapped to Hide.)

In addition, the Mac driver doesn't include a "Hide" item in its application
menu.  It should and eventually will, but doesn't currently.  You can hide a
Wine process using the Dock or Command-Tab application switcher, but that
doesn't cause crashing in my testing.

What version of Mac OS X are you using?  What specific Windows apps have you
seen crash?  Can you attach a crash backtrace?

Is it possible that you have some third-party software installed on your Mac
which is capturing Command-H and doing something funky with it?

[Bug 33383] Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

--- Comment #2 from [e-mail] 2013-04-17 16:10:14 CDT ---
Created attachment 44202
  --> http://bugs.winehq.org/attachment.cgi?id=44202
foobar2000 backtrace

[Bug 33383] Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

--- Comment #3 from [e-mail] 2013-04-17 16:14:56 CDT ---
Sorry about the typo, it it indeed "wine-devel @1.5.28_0". I am running Mac OS
X 10.8.3 and have confirmed this behavior on two Macs configured with the same
software.

I noticed you can hide the application by selecting "hide" within the dock menu
for the application and it behaves as expected, however when you press
command+h (which you mentioned maps to alt+h) it will intermittently crash the
application. If the application does not crash, it executes the alt+h
keystrokes as expected.

I've attached a backtrace and the application I am using is foobar2000 1.2.5
beta 2.

Thanks!

[Bug 33383] Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

--- Comment #4 from Ken Thomases  2013-04-17 16:39:39 CDT ---
Since you're using a beta of foobar2000, the problem might just be a bug with
that. Have you tried the last stable release (1.2.4)?

In your original description of this bug, you suggested the problem affects
"any application". Can you confirm that anything other than foobar2000 crashes?

What function of the program does Alt-H perform? Do you get the crash if you
invoke that feature another way, such as with a menu or button?

Are you sure this crash does not happen if you use the X11 driver? You can
configure Wine to use the X11 driver by setting the following registry setting:

[HKEY_CURRENT_USER\Software\Wine\Drivers]
"Graphics"="x11"

[Bug 33383] Hiding application to Mac OS X Dock causes crash.

http://bugs.winehq.org/show_bug.cgi?id=33383

--- Comment #5 from Ken Thomases  2013-04-17 16:58:47 CDT ---
I was able to reproduce the crash of foobar2000 on Alt-H with the X11 driver. I
had to configure XQuartz's preferences to make the Option key send Alt because
Command-H does hide XQuartz. But once I did that, Option-H crashed the same
way.

So, it's not related to the Mac driver.

It seems to be in the drawing of menus.

[Bug 33383] Foobar2000 crashes on Alt-H

http://bugs.winehq.org/show_bug.cgi?id=33383

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|winemac.drv                 |-unknown
            Summary|Hiding application to Mac   |Foobar2000 crashes on Alt-H
                   |OS X Dock causes crash.     |

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

--- Comment #6 from Austin English  ---
This is your friendly reminder that there has been no bug activity for over a
year. Is this still an issue in current (1.7.37 or newer) wine? If so, please
attach the terminal output in 1.7.37 (see http://wiki.winehq.org/FAQ#get_log).

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail] ---
Created attachment 51175
  --> https://bugs.winehq.org/attachment.cgi?id=51175
foobar2000: menu trace log and backtrace

i think i have same issue on Linux.
i can reproduce this with latest version of wine, foobar2000.

OS: Debian GNU/Linux 8.0 (jessie)
wine: wine-1.7.39 (built from git repository)
foobar2000: 1.3.8 (i used portable installation)

it seems that MENU_TrackKbdMenuBar tries to draw a menu item in array but the
index is out of bounds.
the index is obtained by sending WM_MENUCHAR to a window in function
MENU_FindItemByKey.
checking the index fixed issue for me.

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] ---
(In reply to teru from comment #7)
> Created attachment 51175 [details]
> foobar2000: menu trace log and backtrace
>
> i think i have same issue on Linux.
> i can reproduce this with latest version of wine, foobar2000.
>
> OS: Debian GNU/Linux 8.0 (jessie)
> wine: wine-1.7.39 (built from git repository)
> foobar2000: 1.3.8 (i used portable installation)
>
> it seems that MENU_TrackKbdMenuBar tries to draw a menu item in array but
> the index is out of bounds.
> the index is obtained by sending WM_MENUCHAR to a window in function
> MENU_FindItemByKey.
> checking the index fixed issue for me.

Since you are aware how to fix it, would you able to form a patch and send it
over wine?

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #9 from [e-mail] ---
The component field is definitely user32. Someone should set it.

I didnt test, but it's quite safe to assume that issue is still valid against
1.9.20.

Can someone form a patch based on comment 7?

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

Ken Thomases  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

Dan Dascalescu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Dan Dascalescu  ---
3+ years later, still seeing this issue with Wine devel 2.1: foobar2000 crashes
when I press any Alt+<key> accelerator, e.g. Alt+F.

Also, foobar2000 starts up WAY, WAY slower in Wine2.1. Like, 30+ seconds vs.
instant in Wine 1.8, and often it doesn't start at all.

[Bug 33383] Foobar2000 crashes on Alt-H

https://bugs.winehq.org/show_bug.cgi?id=33383

--- Comment #11 from Dmitry Timoshkov  ---
(In reply to Dan Dascalescu from comment #10)
> 3+ years later, still seeing this issue with Wine devel 2.1: foobar2000
> crashes when I press any Alt+<key> accelerator, e.g. Alt+F.

Could you please retest with wine-staging 2.1? Presumably this is a duplicate
of bug 40704 which has a staged patch referenced.

[Bug 33383] Foobar2000 crashes on Alt-H

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33383

Maik Wagner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Maik Wagner  ---
Trying to reproduce this in wine 6.21 in a fresh prefix and I am not
experiencing these problems with foobar2000 1.6.8

[Bug 33383] Foobar2000 crashes on Alt-H

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33383

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Ken Sharp  ---
Reported fixed

[Bug 33383] Foobar2000 crashes on Alt-H

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=33383

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  ---
Closing bugs fixed in 7.11.