[Bug 15318] New: Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Summary: Google Chrome pasting in the url field pastes it twice
           Product: Wine
           Version: 1.1.4
          Platform: PC-x86-64
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: minor
          Priority: P2
         Component: richedit
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail]

Created an attachment (id=16149)
 --> (http://bugs.winehq.org/attachment.cgi?id=16149)
+richedit in git

Pretty self explanatory...I'll get a +richedit...

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #1 from Austin English   2008-09-17 21:12:00 ---
Created an attachment (id=16150)
 --> (http://bugs.winehq.org/attachment.cgi?id=16150)
+richedit with native riched20/30

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #2 from Dan Kegel   2008-09-17 21:14:38 ---
Interestingly, if you hit ^Z, it undoes the second paste,
leaving you with just what you wanted.

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #3 from Austin English   2008-09-17 21:18:01 ---
(In reply to comment #2)
> Interestingly, if you hit ^Z, it undoes the second paste,
> leaving you with just what you wanted.

Interesting...I had to do it 2-3 times though.

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #4 from Dan Kegel   2008-09-17 21:20:05 ---
Yeah, I think I did too.  Does native richedit avoid the problem?

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #5 from Austin English   2008-09-17 21:21:05 ---
(In reply to comment #4)
> Yeah, I think I did too.  Does native richedit avoid the problem?

Yeah, thought I mentioned that. I'm not sure if it's riched20 or 30 that fixes
it though. About to run, didn't see which one did...

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail],         |
                   |[e-mail],     |
                   |[e-mail],        |
                   |[e-mail],       |
                   |[e-mail],          |
                   |[e-mail]       |

--- Comment #6 from Austin English   2008-09-17 21:21:56 ---
I really need to notice those damn cc's...

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Dylan Smith   2008-10-21 01:44:56 ---
I used AppDb's HOWTO for installing and running Chrome.

I found that the workaround for this issue is:
$sh winetricks riched30

The following just caused chrome to crash:
$sh winetricks riched20

The problem seems to be that there are 2 WM_PASTE messages being sent:
#1 is sent on WM_KEYDOWN probably by chrome's window proc for the richedit
control
#2 is sent on WM_CHAR by Wine's window proc

It seems like chrome replaced the window proc for the richedit control and
falls back on Wine's for some functionality.

Commenting out the SendMessageW(editor->hWnd, WM_PASTE, 0, 0) in the WM_CHAR
case for richedit's window proc does fix the problem for chrome, which isn't a
fix, but confirms some of my analysis.

I suspect that pasting should be done in WM_KEYDOWN, and that is why chrome
avoids calling Wine's window proc for this message when it is for a Ctrl-v.

I still need to make a test to fix this properly, so I will need to figure out
how to simulate a Ctrl-V with a keyboard message through SendMessage. The
richedit tests have a comment that says "Native riched20 won't obey WM_CHAR
messages or WM_KEYDOWN/WM_KEYUP messages, probably because it inspects the
keyboard state itself."

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #8 from Dan Kegel   2008-10-21 09:17:46 ---
Excellent, sounds like you've got it mostly figured out!

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #9 from Dylan Smith   2008-10-21 19:43:33 ---
Created an attachment (id=16785)
 --> (http://bugs.winehq.org/attachment.cgi?id=16785)
richedit: Handle ctrl-key shortcuts on WM_KEYDOWN.

I did some more tests to confirm my theory, and as expected it seems like all
the Ctrl-<key> shortcuts are being handled in WM_KEYDOWN by native richedit. 
This patch moves the handling of these shortcuts from WM_CHAR to handling them
on WM_KEYDOWN.

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

--- Comment #10 from Dylan Smith   2008-10-22 10:17:23 ---
(From update of attachment 16785)
In git as commit 5bcb15dd7f5182ba90d43e07f27373e054f4ebe7

I think this bug is fixed now.

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Austin English   2008-10-22 10:42:55 ---
Yep, fixed.

[Bug 15318] Google Chrome pasting in the url field pastes it twice

http://bugs.winehq.org/show_bug.cgi?id=15318

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2008-10-24 11:13:57 ---
Closing bugs fixed in 1.1.7.