[Bug 30568] New: numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

Bug #: 30568
           Summary: numeric keypad's period (decimal point) does not work
           Product: Wine
           Version: 1.5.3
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

I've tested this in the latest Steam client as well as Quicken Deluxe 2003.
Other numeric keypad keys (numbers) work fine, but the decimal point (period)
does not.  The main keyboard period works normally.

As a sanity check, I verified that it is not a problem with the keyboard by
testing it in an xterm.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv

--- Comment #1 from Austin English  2012-05-02 13:43:27 CDT ---
What type of keyboard/locale?

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #2 from Bob Igo  2012-05-02 13:54:55 CDT ---
US keyboard layout and locale.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1
    Regression SHA1|                            |bdae6d7dc05628920db38b6ad23
                   |                            |983835f475581

--- Comment #3 from Austin English  2012-05-02 15:04:36 CDT ---
Confirming. Regression, introduced by bdae6d7dc05628920db38b6ad23983835f475581.

You can also see this in wine notepad.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #4 from Dmitry Timoshkov  2012-05-02 23:21:18 CDT ---
Works fine here. What keyboard layout and locale are you using?
Attach +event,+key,+keyboard,+xim log.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #5 from Bob Igo  2012-05-03 10:20:16 CDT ---
Created attachment 40013
  --> http://bugs.winehq.org/attachment.cgi?id=40013
requested debug log

I ran notepad.exe and pressed numpad "." several times.  The period never
appeared in notepad, but I see from the log that at least something recognized
it.

This is on a US keyboard, using en_US[.UTF-8] layout.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #6 from Bob Igo  2012-05-03 10:22:38 CDT ---
In case it matters, both systems where I have seen this are Ubuntu 12.04 x86_64
desktop installations, using this PPA to get wine 1.5.x:
https://launchpad.net/~ubuntu-wine/+archive/ppa

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #7 from Dmitry Timoshkov  2012-05-03 11:40:17 CDT ---
(In reply to comment #5)
> Created attachment 40013 [details]
> requested debug log
>
> I ran notepad.exe and pressed numpad "." several times.  The period never
> appeared in notepad, but I see from the log that at least something recognized
> it.
>
> This is on a US keyboard, using en_US[.UTF-8] layout.

Thanks. It looks like your X11 fails to report correct NumLock state (it
reports that it's off, but that shouldn't be the case) and therefore fails
to translate XK_KP_Separator because NumLock state in XKeyEvent structure
is wrong.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #8 from Bob Igo  2012-05-03 11:42:11 CDT ---
That's interesting, because when I turn numlock off, I can't enter the number
keys on the keypad.  Only when I turn numlock on can I enter numbers.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #9 from Bob Igo  2012-05-03 11:58:15 CDT ---
Created attachment 40014
  --> http://bugs.winehq.org/attachment.cgi?id=40014
numlock on; test; off; test

Just in case I monkeyed the last test, here is one I just did.  I turned on
numlock, ran notepad.ext then pressed DEL/. 7/HOME, 8/UP, 9/PGUP.  Then I
turned numlock off and pressed a few of the same keys, ending with DEL/.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #10 from Dmitry Timoshkov  2012-05-03 11:58:19 CDT ---
Created attachment 40015
  --> http://bugs.winehq.org/attachment.cgi?id=40015
Force NumLock state on for '.' on keypad

Does the attached patch help?

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #11 from Austin English  2012-05-03 12:02:00 CDT ---
(In reply to comment #10)
> Created attachment 40015 [details]
> Force NumLock state on for '.' on keypad
>
> Does the attached patch help?

Doesn't help here.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #12 from Austin English  2012-05-03 12:04:01 CDT ---
Created attachment 40016
  --> http://bugs.winehq.org/attachment.cgi?id=40016
log with patch, bzip2'ed

Here's a log with the patch applied. Started with numlock off:
456
del/.
numlock on
456
del/.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #13 from Dmitry Timoshkov  2012-05-03 12:06:35 CDT ---
(In reply to comment #9)
> Created attachment 40014 [details]
> numlock on; test; off; test
>
> Just in case I monkeyed the last test, here is one I just did.  I turned on
> numlock, ran notepad.ext then pressed DEL/. 7/HOME, 8/UP, 9/PGUP.  Then I
> turned numlock off and pressed a few of the same keys, ending with DEL/.

In that log NumLock state is inverted, i.e. it's reported on when it supposed
to be off and vice versa.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40015|0                           |1
        is obsolete|                            |

--- Comment #14 from Dmitry Timoshkov  2012-05-07 07:18:39 CDT ---
Created attachment 40074
  --> http://bugs.winehq.org/attachment.cgi?id=40074
winex11.drv: Use XK_KP_Decimal as a fallback if XK_KP_Separator doesn't work.

Does the attached patch help?

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #15 from Austin English  2012-05-07 14:01:12 CDT ---
(In reply to comment #14)
> Created attachment 40074 [details]
> winex11.drv: Use XK_KP_Decimal as a fallback if XK_KP_Separator doesn't work.
>
> Does the attached patch help?

Works for me, thanks.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8ed11d8bb11e60c4dcb113564b4
                   |                            |457da809db5bf
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Austin English  2012-05-08 16:34:56 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/8ed11d8bb11e60c4dcb113564b4...

Thanks Dmitry!

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from [e-mail] 2012-05-09 09:06:48 CDT ---
I have the same issue. In all my wine programs (notepad included). How do I
apply the patch to see if it works for me? 
Thanks!

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #18 from Austin English  2012-05-09 13:43:01 CDT ---
(In reply to comment #17)
> I have the same issue. In all my wine programs (notepad included). How do I
> apply the patch to see if it works for me? 
> Thanks!

http://wiki.winehq.org/FAQ#compile_wine

or wait for the next release (Friday) and packages to be built by your distro.

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #19 from [e-mail] 2012-05-09 13:50:27 CDT ---
Thank you... I had just found that myself. Sometimes I forget to "Google it".

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

--- Comment #20 from [e-mail] 2012-05-09 13:51:05 CDT ---
(In reply to comment #18)
> (In reply to comment #17)
> > I have the same issue. In all my wine programs (notepad included). How do I
> > apply the patch to see if it works for me? 
> > Thanks!
>
> http://wiki.winehq.org/FAQ#compile_wine
>
> or wait for the next release (Friday) and packages to be built by your distro.

Thank you... I had just found that myself. Sometimes I forget to "Google it".

[Bug 30568] numeric keypad's period (decimal point) does not work

http://bugs.winehq.org/show_bug.cgi?id=30568

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Alexandre Julliard  2012-05-11 13:22:06 CDT ---
Closing bugs fixed in 1.5.4.