[Bug 39580] New: error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

Bug ID: 39580
           Summary: error using va_start() macro
           Product: Wine
           Version: 1.7.54
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build-env
          Assignee: [e-mail]
          Reporter: [e-mail]

Clang-3.8 can't continue
~~~
/Users/sergey/ProjectsML/wine-sherry/dlls/avifil32/api.c:2303:5: error:
'va_start' used in Win64 ABI function
    va_start(vl, lpOptions);
    ^
/Users/sergey/src/llvm-build/Release/bin/../lib/clang/3.8.0/include/stdarg.h:33:29:
note: expanded from macro
      'va_start'
#define va_start(ap, param) __builtin_va_start(ap, param)
                            ^
/Users/sergey/ProjectsML/wine-sherry/dlls/avifil32/api.c:2346:5: error:
'va_start' used in Win64 ABI function
    va_start(vl, lpOptions);
    ^
/Users/sergey/src/llvm-build/Release/bin/../lib/clang/3.8.0/include/stdarg.h:33:29:
note: expanded from macro
      'va_start'
#define va_start(ap, param) __builtin_va_start(ap, param)
                            ^
2 errors generated.
make[1]: *** [api.o] Error 1
make[1]: *** Waiting for unfinished jobs....

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

--- Comment #1 from Sergey Isakov  ---
Resolved by

~~~
#ifdef __LP64__
    __builtin_ms_va_list vl;
#else
    va_list vl;
#endif

...

#ifdef __LP64__
    __builtin_ms_va_start(vl, lpOptions);
#else
    va_start(vl, lpOptions);
#endif

...

Is it good workaround?

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |NOTOURBUG

--- Comment #2 from Dmitry Timoshkov  ---
https://llvm.org/bugs/show_bug.cgi?id=8851

Probably you should know before spending more time on this that Wine can't
work on 64-bit MacOS X due to technical incompatibilities.

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

--- Comment #3 from Sergey Isakov  ---
(In reply to Dmitry Timoshkov from comment #2)
> https://llvm.org/bugs/show_bug.cgi?id=8851
>
> Probably you should know before spending more time on this that Wine can't
> work on 64-bit MacOS X due to technical incompatibilities.

Wine works on OSX 10.9.5 which is always 64bit.

As well my compilation wine64 works installing winrar-64bit
WINEARCH=win64 wine64 c:/tests/winrar-x64-520.exe

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

--- Comment #4 from Sergey Isakov  ---
Created attachment 52745
  --> https://bugs.winehq.org/attachment.cgi?id=52745
working wine64 on OSX 10.9.5

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

--- Comment #5 from Sergey Isakov  ---
(In reply to Dmitry Timoshkov from comment #2)
> https://llvm.org/bugs/show_bug.cgi?id=8851
>
> Probably you should know before spending more time on this that Wine can't
> work on 64-bit MacOS X due to technical incompatibilities.

As you see recent Clang has support for this function and I reported a bug in
wine sources that uses va_list instead of _builtin_ms_va_list. They are not the
same for the clang.

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

Sergey Isakov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|NOTOURBUG                   |---

--- Comment #6 from Sergey Isakov  ---
It is not resolved in mainstream.
A solution is in comment 1.

[Bug 39580] error using va_start() macro

https://bugs.winehq.org/show_bug.cgi?id=39580

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|build-env                   |-unknown

--- Comment #7 from Nikolay Sivov  ---
Try this one
https://www.winehq.org/pipermail/wine-patches/2015-November/144935.html.

[Bug 39580] AVISave[A,W] is using va_* instead of __ms_va_* definitions for va_list

https://bugs.winehq.org/show_bug.cgi?id=39580

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|error using va_start()      |AVISave[A,W] is using va_*
                   |macro                       |instead of __ms_va_*
                   |                            |definitions for va_list

[Bug 39580] AVISave[A,W] is using va_* instead of __ms_va_* definitions for va_list

https://bugs.winehq.org/show_bug.cgi?id=39580

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |82a9faae2c4f00d177971bd1e83
                   |                            |0dc89117e6607
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Nikolay Sivov  ---
Fixed with 82a9faae2c4f00d177971bd1e830dc89117e6607.

[Bug 39580] AVISave[A,W] is using va_* instead of __ms_va_* definitions for va_list

https://bugs.winehq.org/show_bug.cgi?id=39580

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.8-rc3.