[Bug 32643] New: getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

Bug #: 32643
           Summary: getsockopt() does not indicate WSAEFAULT when setting
                    optlen too small
           Product: Wine
           Version: 1.5.20
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: winsock
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Using the attached WSA code will cause an error on Windows but NOT on WINE.
If you change "optlen" value to at least 4, the example the code will run
smoothly on both platforms.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

--- Comment #1 from Alexander Schlarb  2013-01-03 13:37:00 CST ---
Created attachment 43072
  --> http://bugs.winehq.org/attachment.cgi?id=43072
The bug code

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #2 from Bruno Jesus  2013-01-05 16:31:55 CST ---
I can confirm this issue in wine 1.5.21.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

--- Comment #3 from Bruno Jesus  2013-01-05 16:46:54 CST ---
This is really weird, it only happens with SO_ERROR. It needs tests in other OS
like OSX or BSD. Maybe it's a special rule regarding SO_ERROR in linux.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

--- Comment #4 from Bruno Jesus  2013-01-07 17:36:30 CST ---
I see now that it's a implementation detail that is also present in the minix
source, it only copies the amount of bytes passed which can be < 4. So we have
to do it in our side. A have a few tests already.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

http://bugs.winehq.org/show_bug.cgi?id=32643

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

https://bugs.winehq.org/show_bug.cgi?id=32643

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #5 from Austin English  ---
Is this still an issue in current (1.7.36 or newer) wine? If so, please attach
terminal output.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

https://bugs.winehq.org/show_bug.cgi?id=32643

--- Comment #6 from Bruno Jesus  ---
Still in wine 1.7.34. I have a quite long patch to test the parameters of all
socket options, it will take longer to make proper tests.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32643

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |source

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32643

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Hans Leidekker  ---
Test passes on Wine.

[Bug 32643] getsockopt() does not indicate WSAEFAULT when setting optlen too small

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32643

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc5.