http://bugs.winehq.org/show_bug.cgi?id=26101
Summary: riched20/editor tests show a ton of valgrind warnings Product: Wine Version: 1.3.13 Platform: x86 OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: minor Priority: P2 Component: richedit AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Created an attachment (id=33289) --> (http://bugs.winehq.org/attachment.cgi?id=33289) valgrind log
Most seem related to: 12 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by heap_alloc (editor.h:30) by ME_MakeStringB (string.c:35) by ME_MakeStringN (string.c:46) by ME_InsertTextFromCursor (caret.c:576) by ME_HandleMessage (editor.c:3557) by RichEditWndProc_common (editor.c:4491) by RichEditWndProcA (editor.c:4516) by ??? (winproc.c:172) by call_window_proc (winproc.c:242) by WINPROC_call_window (winproc.c:908) by call_window_proc (message.c:2201) by send_message (message.c:3042) by SendMessageA (message.c:3187) by test_scrollbar_visibility (editor.c:2752) by func_editor (editor.c:7112) by run_test (test.h:556) by main (test.h:624)
there's also: 12 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by heap_alloc (editor.h:30) by ME_MakeStringB (string.c:35) by ME_MakeStringN (string.c:46) by ME_InsertTextFromCursor (caret.c:576) by RTFFlushUnicodeOutputBuffer (reader.c:2558) by RTFFlushOutputBuffer (reader.c:2603) by ME_RTFParAttrHook (editor.c:826) by ControlClass (reader.c:2364) by RTFRouteToken (reader.c:342) by RTFRead (reader.c:310) by ME_StreamIn (editor.c:1488) by ME_Paste (editor.c:1998) by ME_KeyDown (editor.c:2305) by ME_HandleMessage (editor.c:4020) by RichEditWndProc_common (editor.c:4491) by RichEditWndProcA (editor.c:4516) by ??? (winproc.c:172) by call_window_proc (winproc.c:242)
...
12 bytes in 1 blocks are definitely lost at notify_alloc (heap.c:254) by RtlAllocateHeap (heap.c:1701) by HeapAlloc (heap.c:267) by GlobalAlloc (heap.c:386) by set_dataobject_format (clipboard.c:2071) by OleSetClipboard (clipboard.c:2134) by ME_Copy (editor.c:2022) by ME_KeyDown (editor.c:2317) by ME_HandleMessage (editor.c:4020) by RichEditWndProc_common (editor.c:4491) by RichEditWndProcA (editor.c:4516) by ??? (winproc.c:172) by call_window_proc (winproc.c:242) by WINPROC_call_window (winproc.c:908) by call_window_proc (message.c:2201) by send_message (message.c:3042) by SendMessageA (message.c:3187) by test_WM_PASTE (editor.c:4805) by func_editor (editor.c:7131) by run_test (test.h:556)
and more. I'll attach the full log.
http://bugs.winehq.org/show_bug.cgi?id=26101
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #1 from Dan Kegel dank@kegel.com 2011-10-15 15:48:47 CDT --- I get two non-leak errors when I run valgrind on "make editor.ok":
Conditional jump or move depends on uninitialised value(s) by wine_dbgstr_wn (debug.c:421) by ME_CallWordBreakProc (debug.h:257) by ME_MoveCursorWords (caret.c:741)
and
Conditional jump or move depends on uninitialised value(s) at WINPROC_CallProcWtoA (unicode.h:200) by WINPROC_call_window (winproc.c:901) by call_window_proc (message.c:2211) by send_message (message.c:3084) by SendMessageW (message.c:3264) by test_EM_FINDWORDBREAK_A (editor.c:7117) by func_editor (editor.c:7189) by run_test (test.h:556) Uninitialised value was created by a stack allocation at test_EM_FINDWORDBREAK_A (editor.c:7095)
I'll attach a log.
http://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #2 from Dan Kegel dank@kegel.com 2011-10-15 15:49:23 CDT --- Created attachment 36922 --> http://bugs.winehq.org/attachment.cgi?id=36922 valgrind log of "make tests" in riched20/tests
http://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #3 from Austin English austinenglish@gmail.com 2012-09-26 15:08:51 CDT --- Still in wine-1.5.13-346-g0445393
https://bugs.winehq.org/show_bug.cgi?id=26101
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #33289|0 |1 is obsolete| | Attachment #36922|0 |1 is obsolete| |
--- Comment #4 from Austin English austinenglish@gmail.com --- Created attachment 48231 --> https://bugs.winehq.org/attachment.cgi?id=48231 valgrind log in wine-1.7.17-42-g24c5728
https://bugs.winehq.org/show_bug.cgi?id=26101
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind
https://bugs.winehq.org/show_bug.cgi?id=26101
Jactry Zeng jactry92@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jactry92@gmail.com
--- Comment #5 from Jactry Zeng jactry92@gmail.com --- Created attachment 49366 --> https://bugs.winehq.org/attachment.cgi?id=49366 possible fix
Hi Austin, Dan, (In reply to Austin English from comment #0)
Created attachment 33289 [details] valgrind log
Here is a possible fix.
https://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #6 from Austin English austinenglish@gmail.com --- (In reply to Jactry Zeng from comment #5)
Created attachment 49366 [details] possible fix
Hi Austin, Dan, (In reply to Austin English from comment #0)
Created attachment 33289 [details] valgrind log
Here is a possible fix.
The patch helps, though there are still the uninitialized values in test_EM_FINDWORDBREAK_A from comment #1 (that would be a separate bug, of course).
https://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #7 from Jactry Zeng jactry92@gmail.com --- Hi, (In reply to Austin English from comment #6)
(In reply to Jactry Zeng from comment #5)
Created attachment 49366 [details] possible fix
Hi Austin, Dan, (In reply to Austin English from comment #0)
Created attachment 33289 [details] valgrind log
Here is a possible fix.
The patch helps, though there are still the uninitialized values in test_EM_FINDWORDBREAK_A from comment #1 (that would be a separate bug, of course).
Thanks for your testing!
I cannot find the error in comment #1, but there was another one: ==28062== Conditional jump or move depends on uninitialised value(s) ==28062== at 0x4E21938: bitmapinfoheader_from_user_bitmapinfo (dib.c:182) ==28062== by 0x4E24462: GetDIBits (dib.c:1217) ==28062== by 0x5135DB5: create_icon_pixmaps.isra.10 (window.c:546) ==28062== by 0x5137F17: fetch_icon_data (window.c:631) ==28062== by 0x513ABAB: X11DRV_WindowPosChanged (window.c:2325) ==28062== by 0x4D4D057: set_window_pos (winpos.c:2147) ==28062== by 0x4D4FB78: USER_SetWindowPos (winpos.c:2220) ==28062== by 0x4D4D2D6: SetWindowPos (winpos.c:2294) ==28062== by 0x4D4E95E: show_window (winpos.c:1122) ==28062== by 0x4D4EC92: ShowWindow (winpos.c:1220) ==28062== by 0x4C15C83: main (wineboot.c:932) ==28062== Uninitialised value was created by a stack allocation ==28062== at 0x5135C98: create_icon_pixmaps.isra.10 (window.c:530) ==28062==
Which has been reported as Bug 30827.
Is the command I used right? I'm not so familiar to valgrind,: $ valgrind --tool=memcheck --leak-check=full --trace-children=yes --workaround-gcc296-bugs=yes --num-callers=20 ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so editor &> ~/editor_log.txt
https://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #8 from Jactry Zeng jactry92@gmail.com --- (In reply to Jactry Zeng from comment #7)
==27370== Conditional jump or move depends on uninitialised value(s) ==27370== at 0x4F5893C: bitmapinfoheader_from_user_bitmapinfo (dib.c:182) ==27370== by 0x4F5B45A: GetDIBits (dib.c:1217) ==27370== by 0x54A3DB5: create_icon_pixmaps.isra.10 (window.c:546) ==27370== by 0x54A5F17: fetch_icon_data (window.c:631) ==27370== by 0x54A8BAB: X11DRV_WindowPosChanged (window.c:2325) ==27370== by 0x4E84057: set_window_pos (winpos.c:2147) ==27370== by 0x4E86B78: USER_SetWindowPos (winpos.c:2220) ==27370== by 0x4E842D6: SetWindowPos (winpos.c:2294) ==27370== by 0x4E8595E: show_window (winpos.c:1122) ==27370== by 0x4E85C92: ShowWindow (winpos.c:1220) ==27370== by 0x4E7F8D3: WIN_CreateWindowEx (win.c:1667) ==27370== by 0x4E78FFE: CreateWindowExA (win.c:1719) ==27370== by 0x4C145F4: func_editor (editor.c:38) ==27370== by 0x4C140E3: main (test.h:584) ==27370== Uninitialised value was created by a stack allocation ==27370== at 0x54A3C98: create_icon_pixmaps.isra.10 (window.c:530)
https://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #9 from Austin English austinenglish@gmail.com --- (In reply to Jactry Zeng from comment #7)
Hi, (In reply to Austin English from comment #6)
(In reply to Jactry Zeng from comment #5)
Created attachment 49366 [details] possible fix
Hi Austin, Dan, (In reply to Austin English from comment #0)
Created attachment 33289 [details] valgrind log
Here is a possible fix.
The patch helps, though there are still the uninitialized values in test_EM_FINDWORDBREAK_A from comment #1 (that would be a separate bug, of course).
Thanks for your testing!
I cannot find the error in comment #1, but there was another one: ==28062== Conditional jump or move depends on uninitialised value(s) ==28062== at 0x4E21938: bitmapinfoheader_from_user_bitmapinfo (dib.c:182) ==28062== by 0x4E24462: GetDIBits (dib.c:1217) ==28062== by 0x5135DB5: create_icon_pixmaps.isra.10 (window.c:546) ==28062== by 0x5137F17: fetch_icon_data (window.c:631) ==28062== by 0x513ABAB: X11DRV_WindowPosChanged (window.c:2325) ==28062== by 0x4D4D057: set_window_pos (winpos.c:2147) ==28062== by 0x4D4FB78: USER_SetWindowPos (winpos.c:2220) ==28062== by 0x4D4D2D6: SetWindowPos (winpos.c:2294) ==28062== by 0x4D4E95E: show_window (winpos.c:1122) ==28062== by 0x4D4EC92: ShowWindow (winpos.c:1220) ==28062== by 0x4C15C83: main (wineboot.c:932) ==28062== Uninitialised value was created by a stack allocation ==28062== at 0x5135C98: create_icon_pixmaps.isra.10 (window.c:530) ==28062==
Which has been reported as Bug 30827.
Is the command I used right? I'm not so familiar to valgrind,: $ valgrind --tool=memcheck --leak-check=full --trace-children=yes --workaround-gcc296-bugs=yes --num-callers=20 ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so editor &> ~/editor_log.txt
See https://github.com/austin987/wine_misc/tree/master/valgrind for my valgrind scripts/suppression files.
I use: export VALGRIND_OPTS="-q --trace-children=yes --track-origins=yes --gen-suppressions=all --suppressions=$WINESRC/tools/valgrind/valgrind-suppressions-ignore --suppressions=$WINESRC/tools/valgrind/valgrind-suppressions-external --suppressions=$WINESRC/tools/valgrind/valgrind-suppressions-known-bugs --suppressions=$WINESRC/tools/valgrind/valgrind-suppressions-gecko --leak-check=full --num-callers=20 --workaround-gcc296-bugs=yes --vex-iropt-register-updates=allregs-at-mem-access"
https://bugs.winehq.org/show_bug.cgi?id=26101
--- Comment #10 from Austin English austinenglish@gmail.com --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/063b3bc9dbe359611bbe4bc392..., I filed bug 37159 for the other issues.
https://bugs.winehq.org/show_bug.cgi?id=26101
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |063b3bc9dbe359611bbe4bc3924 | |5649a9576ef8e Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #11 from Austin English austinenglish@gmail.com --- (In reply to Austin English from comment #10)
Fixed by https://source.winehq.org/git/wine.git/commitdiff/ 063b3bc9dbe359611bbe4bc39245649a9576ef8e, I filed bug 37159 for the other issues.
Really fixed.
https://bugs.winehq.org/show_bug.cgi?id=26101
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.25.
-
wine-bugs＠winehq.org