[Bug 21320] New: wine/list.h has namespace conflicts with sys/queue.h

List overview All Threads

newer

older

[Bug 21334] New: build broken on...

[Bug 21291] New: System call...

wine-bugs＠winehq.org

11 Jan 2010 11 Jan '10

12:43 a.m.

http://bugs.winehq.org/show_bug.cgi?id=21320

Summary: wine/list.h has namespace conflicts with sys/queue.h Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: jeremyhu@freedesktop.org

sys/queue.h on FreeBSD, darwin, etc provide LIST_ENTRY macros which conflict with those in wine/list.h ... this has led to problems such as:

http://trac.macports.org/ticket/22342

A workaround for this was pushed into wine a while back, but it is merely a hackish workaround. If you permute the order in which headers are included, or if system headers happen to add an include on sys/queue.h, you may end up not being able to build wine. This is what happened in the above external ticket.

If you simply add a '#include <sys/queue.h>' to /usr/include/dispatch/dispatch.h, wine stops building here on darwin. I'm sure it would be easy to find a similar case on FreeBSD.

One fix is to avoid conflicting with the sys/queue.h namespace and use something like WINE_LIST_ENTRY

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

11 Jan 11 Jan

12:43 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

Jeremy Huddleston jeremyhu@freedesktop.org changed:

wine-bugs＠winehq.org

8:23 p.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

Dmitry Timoshkov dmitry@codeweavers.com changed:

wine-bugs＠winehq.org

13 Jan 13 Jan

10:48 p.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

Austin English austinenglish@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |wine-2010@ryandesign.com

--- Comment #1 from Austin English austinenglish@gmail.com 2010-01-13 16:48:08 --- *** Bug 21358 has been marked as a duplicate of this bug. ***

wine-bugs＠winehq.org

17 Jan 17 Jan

12:32 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

--- Comment #2 from Austin English austinenglish@gmail.com 2010-01-16 18:32:19 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2010-January/083812.html

wine-bugs＠winehq.org

18 Jan 18 Jan

5:14 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

Dmitry Timoshkov dmitry@codeweavers.com changed:

--- Comment #3 from Dmitry Timoshkov dmitry@codeweavers.com 2010-01-17 23:14:18 --- http://www.winehq.org/pipermail/wine-devel/2010-January/081179.html:

Austin English <austinenglish at gmail.com> writes:

...

Subject: [PATCH 1/7] include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OSX

Don't do that. Fix the includes order in the files that fail to compile.

-- Alexandre Julliard julliard at winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

wine-bugs＠winehq.org

5:15 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

Dmitry Timoshkov dmitry@codeweavers.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED

--- Comment #4 from Dmitry Timoshkov dmitry@codeweavers.com 2010-01-17 23:15:08 --- Closing invalid.

wine-bugs＠winehq.org

5:50 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

Jeremy Huddleston jeremyhu@freedesktop.org changed:

--- Comment #5 from Jeremy Huddleston jeremyhu@freedesktop.org 2010-01-17 23:50:43 --- Well then re-opening, so you can fix the build-failure by re-ordering includes (which I think is a less valid solution).

wine-bugs＠winehq.org

19 Jan 19 Jan

6:33 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

--- Comment #6 from Dmitry Timoshkov dmitry@codeweavers.com 2010-01-19 00:33:18 --- What is the problem exactly? Which module/file in Wine fails to compile?

wine-bugs＠winehq.org

8:53 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

--- Comment #7 from Jeremy Huddleston jeremyhu@freedesktop.org 2010-01-19 02:53:43 --- As referenced in the MacPorts ticket (http://trac.macports.org/ticket/22342), dlls/winecoreaudio.drv/audio.c can fail to compile.

You can see the patch that I used to reorder the includes here:

http://trac.macports.org/browser/trunk/dports/x11/wine-crossover-games/files...

but this is of course no guarantee that something else won't go wront in the future.

Another file may eventually include <sys/queue.h> and cause these problems all over again... the proper fix is for wine to not clobber those macros.

wine-bugs＠winehq.org

10:04 a.m.

New subject: [Bug 21320] wine/list.h has namespace conflicts with sys/queue.h

http://bugs.winehq.org/show_bug.cgi?id=21320

--- Comment #8 from Alexandre Julliard julliard@winehq.org 2010-01-19 04:04:44 --- No, the proper fix is to ensure that system headers are always included before Wine headers. We can't prefix every single definition with WINE_ on the off chance that some system header decides to use the same name. There are plenty of similar cases already, including some defines in Win32 headers which of course can't be renamed.