[Bug 29922] New: [PATCH] BOOL conflict on

http://bugs.winehq.org/show_bug.cgi?id=29922

Bug #: 29922
           Summary: [PATCH] BOOL conflict on
           Product: Wine
           Version: 1.4-rc4
          Platform: x86
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 38936
  --> http://bugs.winehq.org/attachment.cgi?id=38936
BOOL.patch

wine's BOOL can conflict with ObjC's on Mac OS X.  Please apply this patch.

[Bug 29922] [PATCH] BOOL conflict on Mac

http://bugs.winehq.org/show_bug.cgi?id=29922

Jeremy Huddleston  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[PATCH] BOOL conflict on    |[PATCH] BOOL conflict on
                   |                            |Mac

[Bug 29922] [PATCH] BOOL conflict on Mac

http://bugs.winehq.org/show_bug.cgi?id=29922

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Dmitry Timoshkov  2012-02-17 20:45:42 CST ---
http://wiki.winehq.org/SubmittingPatches

[Bug 29922] [PATCH] BOOL conflict on Mac

http://bugs.winehq.org/show_bug.cgi?id=29922

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38936|application/octet-stream    |text/plain
          mime type|                            |

[Bug 29922] [PATCH] BOOL conflict on Mac

http://bugs.winehq.org/show_bug.cgi?id=29922

Jeremy Huddleston  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #2 from Jeremy Huddleston  2012-02-18 00:28:51 CST ---
I don't plan on submitting patches to you frequently enough to make it worth my
time to read your policies and subscribe to your lists.  This is a trivial
build failure fix, and you can either apply it or you can wait until someone
else hits it and go through the pain of making it yourself when that happens.

[Bug 29922] [PATCH] BOOL conflict on Mac

http://bugs.winehq.org/show_bug.cgi?id=29922

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Dmitry Timoshkov  2012-02-18 00:42:20 CST ---
Patches are not picked up from bugzilla, and the submission policy is to
make the author send the patches, not somebody else on his behalf.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Jeremy Huddleston  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |
            Summary|[PATCH] BOOL conflict on    |wine's BOOL type can
                   |Mac                         |conflict on Mac's ObjC BOOL

--- Comment #4 from Jeremy Huddleston  2012-02-18 00:50:54 CST ---
Ok, well then I won't be submitting patches to you, but this is still a bug, so
it should stay open until someone else decides to fix it.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Jerome Leclanche  2012-02-18 18:29:03 CST ---
Do you wish to be given credit for your patch? Someone else can send it to
wine-patches in your place.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

--- Comment #6 from Alexandre Julliard  2012-02-19 05:59:29 CST ---
(In reply to comment #4)
> Ok, well then I won't be submitting patches to you, but this is still a bug, so
> it should stay open until someone else decides to fix it.

Then file a proper bug, showing the exact error and the exact compiler and OS
version you are using.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

--- Comment #7 from Jeremy Huddleston  2012-02-19 12:50:46 CST ---
(In reply to comment #5)
> Do you wish to be given credit for your patch? Someone else can send it to
> wine-patches in your place.

No, I don't care about credit.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

--- Comment #8 from Jeremy Huddleston  2012-02-19 12:51:02 CST ---
(In reply to comment #6)
> (In reply to comment #4)
> > Ok, well then I won't be submitting patches to you, but this is still a bug, so
> > it should stay open until someone else decides to fix it.
>
> Then file a proper bug, showing the exact error and the exact compiler and OS
> version you are using.

I can't do that.  Read between the lines.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #9 from Alexandre Julliard  2012-02-19 13:16:16 CST ---
Nothing to fix then. File a new bug if/when this happens in a public version.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Jeremy Huddleston  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #10 from Jeremy Huddleston  2012-02-19 14:17:04 CST ---
It is still a valid concern, so reopening.  You still have conflicts.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #11 from Alexandre Julliard  2012-02-19 16:41:24 CST ---
No we don't, the code builds just fine on Mac.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

--- Comment #12 from Jerome Leclanche  2012-02-19 16:42:35 CST ---
(In reply to comment #10)
Jeremy, until you provide the information required to reproduce the broken
build (OS, compiler, setup), this bug will not be looked after.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Jeremy Huddleston  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #13 from Jeremy Huddleston  2012-02-19 18:01:31 CST ---
I suggest you join the ADC and try building wine on the latest development
versions available.  The patch I've provided is good only on the merrits of
pure *correctness* in that you have a BOOL declared in your winedefs.h (I
believe that was it) and there is another one in <objc/objc.h> which you can
conflict with.

If you don't want to take this patch on those grounds alone, then feel free to
come back here and take it when someone else reports the bug.  We're shipping
with it in MacPorts to protect our users, so that's all I really care about.  I
can't force you to take patches upstream, and based on my experience here, I
won't be providing them in the future.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #14 from Vitaliy Margolen  2012-02-19 18:07:29 CST ---
Would bugzilla admin please remove / ban this user?

Jeremy, you've been told by the only person who commits stuff to Wine -
Everything working fine, there is nothing to fix.

Period, conversation over. If you reopen this bug it will be an indication to
bad your user record.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

--- Comment #15 from Jeremy Huddleston  2012-02-19 18:56:22 CST ---
Wow, that just solidifies my desire to not help you out in the future.  You can
fix your own bugs.

[Bug 29922] wine's BOOL type can conflict on Mac's ObjC BOOL

http://bugs.winehq.org/show_bug.cgi?id=29922

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Jerome Leclanche  2012-02-24 05:44:02 CST ---
Closing