[Bug 11574] New: Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Summary: Picasa cannot upload to web albums
           Product: Wine
           Version: 0.9.55.
          Platform: PC
               URL: http://picasa.google.com/
        OS/Version: Linux
            Status: UNCONFIRMED
          Keywords: download, regression
          Severity: minor
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

After upgrading from wine 0.9.54 to 0.9.55, Picasa can no longer upload to
Picasa Web Albums. To reproduce, select a picture in Picasa, select the "web
albums" button on the bottom, and login.

Regression test says:

c132dd9360bdb40a45f7329a25324b10f8763091 is first bad commit
commit c132dd9360bdb40a45f7329a25324b10f8763091
Author: Hans Leidekker 
Date:   Fri Feb 1 14:40:42 2008 +0100

wininet: Send HTTP/1.1 requests by default.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Hans Leidekker   2008-02-13 04:00:56 ---
Hi Lei, can you please attach a +wininet trace?

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #2 from Lei Zhang   2008-02-13 13:28:05 ---
Created an attachment (id=10753)
 --> (http://bugs.winehq.org/attachment.cgi?id=10753)
+wininet trace

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Hans Leidekker   2008-02-16 02:52:59 ---
This is interesting because Picasa explicitly asks for HTTP/1.1 in the
relevant requests. Since we don't honour version overrides it looks
like Picasa somehow depended on us sending 1.0 requests in spite of
having asked for 1.1 requests.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #4 from Hans Leidekker   2008-02-16 07:58:07 ---
Indeed, my patch merely exposes another bug in Wine. This is the response to a
1.0 request (notice the Content-Length header):

HTTP/1.0 200 OK
Content-Type: text/html; charset=UTF-8
Content-Length: 77
Cache-control: private, must-revalidate, max-age=0
Date: Fri, 15 Feb 2008 21:04:46 GMT
Server: GFE/1.3
Connection: Keep-Alive

And this is the response to a 1.1 request:

HTTP/1.1 200 OK
Content-Type: application/rss+xml; charset=UTF-8
Cache-Control: max-age=0, must-revalidate
Transfer-Encoding: chunked
Date: Sat, 16 Feb 2008 08:59:01 GMT
Server: GFE/1.3

Notice the Transfer-Encoding header and the absence of a Content-Length
header. Picasa queries the message size right after receiving a 200 response,
which fails for 1.1 requests because Wine is currently unable to receive and
decode chunked messages.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Hans Leidekker   2008-02-22 02:29:20 ---
*** Bug 11668 has been marked as a duplicate of this bug. ***

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Michael Moss  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Dan Kegel   2008-02-28 14:12:35 ---
Hans, should we revert your change until Wine can handle chunked encodings?

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #7 from Hans Leidekker   2008-02-29 04:05:53 ---
> Hans, should we revert your change until Wine can handle chunked encodings?

Possibly. It would be nice to have HTTP/1.1 support in Wine 1.0 though.

Implementing chunked response handling requires some careful surgery in
the guts of wininet but I think it can be done in the 1.0 time frame. I'll
have a look after I'm done fiddling with Photoshop and mscms.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Federico Ferrari  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #8 from Lei Zhang   2008-03-06 15:28:25 ---
Another Picasa feature that's broken due to this is the download album feature.
Run Picasa as follows:

/path/to/wine 'C:\Program Files\Picasa2\Picasa2.exe'
picasa://downloadfeed/?url=http%3A%2F%2Fpicasaweb.google.com%2Fdata%2Ffeed%2Fback_compat%2Fuser%2Fzhanglei%2Falbumid%2F5169717603899925425%3Fkind%3Dphoto%26alt%3Drss%26imgdl%3D1

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #9 from Dan Kegel   2008-03-20 15:30:43 ---
Created an attachment (id=11518)
 --> (http://bugs.winehq.org/attachment.cgi?id=11518)
Possible patch to revert back to http 1.0 as default

Does this patch look about right for making current wine default 
to http 1.0 again?

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #10 from Hans Leidekker   2008-03-21 05:01:50 ---
Created an attachment (id=11521)
 --> (http://bugs.winehq.org/attachment.cgi?id=11521)
wininet: Implement chunked transfers.

Reverting to 1.0 needs more than that. My patch implementing the version
override must be reverted and possibly Rob's patch that makes wininet
default to keep alive semantics.

But let's not go backward ;-) Here's a first cut at chunked transfers that
allows me to upload pictures in Picasa. Can you try it? Note that the patch
may apply with an offset because I have another unsent patch in my tree.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #11 from Lei Zhang   2008-03-21 15:12:49 ---
(In reply to comment #10)
> But let's not go backward ;-) Here's a first cut at chunked transfers that
> allows me to upload pictures in Picasa. Can you try it? Note that the patch
> may apply with an offset because I have another unsent patch in my tree.

Yes, I can upload to Picasaweb with this patch.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #12 from Lei Zhang   2008-03-21 19:41:22 ---
Although there is more work to be done. Before commit c132dd93, after you
connect to Picasaweb, if you select "Add to an existing album," it will give
you the entire listing. With wine-git and this patch, I only get a list of
about 10 albums .

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #13 from Hans Leidekker   2008-03-22 04:04:50 ---
> Although there is more work to be done.

That's why I called it a first cut ;-) It breaks when the chunk size is
larger than the read buffer, which explains why you see a partial list.
I'm working on it.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11521|0                           |1
        is obsolete|                            |

--- Comment #14 from Hans Leidekker   2008-03-22 15:29:05 ---
Created an attachment (id=11549)
 --> (http://bugs.winehq.org/attachment.cgi?id=11549)
wininet: Implement chunked reads.

This version should handle chunks that exceed the buffer size correctly.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #15 from Lei Zhang   2008-03-23 14:01:48 ---
Created an attachment (id=11573)
 --> (http://bugs.winehq.org/attachment.cgi?id=11573)
+seh,+winsock trace for second patch

With the patch in attachment 11549, Picasa hangs when trying to connect to Web
Albums. Attached is +seh,+winsock log, minus quartz warnings.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #16 from Hans Leidekker   2008-03-23 14:32:41 ---
Thanks for testing Lei. No hang here, I successfully uploaded a picture to
an existing album. Can you attach a +wininet trace and perhaps a "bt all"
from the hang?

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11573|0                           |1
        is obsolete|                            |

--- Comment #17 from Lei Zhang   2008-03-24 01:56:19 ---
Created an attachment (id=11587)
 --> (http://bugs.winehq.org/attachment.cgi?id=11587)
+seh,+wininet trace for second patch

s/winsock/wininet/

I meant to give you the right log -- wasn't awake in the morning.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #18 from Hans Leidekker   2008-03-24 07:16:32 ---
The wininet trace looks good. Can you attach a +relay,+tid,+seh trace and
attach a backtrace from when it hangs (i.e. start winedbg and type "bt all")?

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #19 from Lei Zhang   2008-03-24 11:06:06 ---
Created an attachment (id=11604)
 --> (http://bugs.winehq.org/attachment.cgi?id=11604)
bottom portion of +wininet,+relay,+seh,+tid,+heap trace

Looks like we're crashing in the heap code. This may be unrelated to your
patch. I need to run some more tests.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #20 from Lei Zhang   2008-03-24 19:42:17 ---
Did more testing. It's definitely crashing with your code when I use my
personal account, which has 46 albums. If I create a new test account, which 0
albums, I don't get the crash.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11549|0                           |1
        is obsolete|                            |

--- Comment #21 from Hans Leidekker   2008-03-25 10:26:37 ---
Created an attachment (id=11641)
 --> (http://bugs.winehq.org/attachment.cgi?id=11641)
wininet: Implement chunked reads.

Try this improved patch, it survived a test with 15 existing albums.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

--- Comment #22 from Lei Zhang   2008-03-25 10:54:04 ---
Patch #3 worked well for me. I successfully uploaded several albums.

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #23 from Lei Zhang   2008-03-26 09:43:56 ---
Patch committed:

http://www.winehq.org/pipermail/wine-cvs/2008-March/041704.html

[Bug 11574] Picasa cannot upload to web albums

http://bugs.winehq.org/show_bug.cgi?id=11574

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #24 from Alexandre Julliard   2008-04-04 10:07:05 ---
Closing bugs fixed in 0.9.59.