https://bugs.winehq.org/show_bug.cgi?id=48261
Bug ID: 48261 Summary: Batman: Arkham Knight hangs when trying to close upgrade screen (regression) Product: Wine Version: 4.21 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs@winehq.org Reporter: erik.hacklin@gmail.com Distribution: ---
With wine 4.21, when trying to close the upgrade screen, the game hangs. Game still processes input to a certain amount. Lower right button text still updates when you use inputs from the keyboard or from a controller. The upgrade screen icon layout is different and some icons are missing entirely. I have included examples of how it looks when it works and when it doesn't.
After a bisect with wine-staging 4.20 - 4.21 and another without staging patches, the result turned out to be this commit 'ad96d9195e4b524a7bf8ea7250aa384ee07bca0a'.
Reverting the commit fixes the issue and the menu works as expected.
How to reproduce:
- Run the game with wine-staging 4.21 - Open the menu and browse upgrades - Try to close the menu - Game will remain stuck in the menu
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #1 from Erik Hacklin erik.hacklin@gmail.com --- Created attachment 65923 --> https://bugs.winehq.org/attachment.cgi?id=65923 Upgrade screen (4.20)
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #2 from Erik Hacklin erik.hacklin@gmail.com --- Created attachment 65924 --> https://bugs.winehq.org/attachment.cgi?id=65924 Upgrade screen (4.21)
https://bugs.winehq.org/show_bug.cgi?id=48261
Erik Hacklin erik.hacklin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #3 from Erik Hacklin erik.hacklin@gmail.com --- Link to a video showing the bug: https://www.youtube.com/watch?v=L_AMAa4aMio
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #4 from Erik Hacklin erik.hacklin@gmail.com --- Created attachment 65925 --> https://bugs.winehq.org/attachment.cgi?id=65925 Patch reverting the changes of the commit responsible for the regression
https://bugs.winehq.org/show_bug.cgi?id=48261
Erik Hacklin erik.hacklin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |ArchLinux Regression SHA1| |ad96d9195e4b524a7bf8ea7250a | |a384ee07bca0a
https://bugs.winehq.org/show_bug.cgi?id=48261
Erik Hacklin erik.hacklin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |erik.hacklin@gmail.com, | |julliard@winehq.org
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #5 from Erik Hacklin erik.hacklin@gmail.com --- Created attachment 65927 --> https://bugs.winehq.org/attachment.cgi?id=65927 Savegame used
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #6 from Erik Hacklin erik.hacklin@gmail.com --- Installing vcrun2010 can be used to workaround the issue.
https://bugs.winehq.org/show_bug.cgi?id=48261
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick@piezo-forte.be
--- Comment #7 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
This commit looks too simple to be faulty. It must trigger a failure somewhere else.
Please, attach a WINEDEBUG=+msvcrt terminal output. You can find instructions to get a debugging trace there (point 10.1.2 - How do I get a debug trace): https://wiki.winehq.org/FAQ#get_log
Regards.
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #8 from Erik Hacklin erik.hacklin@gmail.com --- Hello Olivier,
Hopefully I did this correctly. I have attached the log you requested.
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #9 from Erik Hacklin erik.hacklin@gmail.com --- Created attachment 65939 --> https://bugs.winehq.org/attachment.cgi?id=65939 Log with WINEDEBUG=+msvcrt enabled
https://bugs.winehq.org/show_bug.cgi?id=48261
Olivier F. R. Dierick o.dierick@piezo-forte.be changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1
--- Comment #10 from Olivier F. R. Dierick o.dierick@piezo-forte.be --- Hello,
Unfortunately now I see that you're using Lutris.
It's a third party tool for which we don't give support here, because it uses heavy customisations that we know nothing about.
Lutris removed the WINEDEBUG variable so the log is missing the msvcrt debug trace.
--- quote from log --- 000b:fixme:winediag:start_process Wine TkG 4.21 is a testing version containing experimental patches. 000b:fixme:winediag:start_process Please don't report bugs about it on winehq.org and use https://github.com/Tk-Glitch/PKGBUILDS/issues instead. --- end quote ---
You should do what is said on those lines, or you could report the issue on the Lutris bug tracker itself: https://github.com/lutris/lutris/issues
If you want to continue on this bug then, please retest with plain wine-devel/wine-staging and attach a new terminal output from it. Otherwise, the bug will be marked invalid.
Regards.
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #11 from Erik Hacklin erik.hacklin@gmail.com --- Hello,
My apologies for wasting time with invalid logs. I will get a proper log with wine-staging.
https://bugs.winehq.org/show_bug.cgi?id=48261
--- Comment #12 from Zebediah Figura z.figura12@gmail.com --- (In reply to Olivier F. R. Dierick from comment #7)
This commit looks too simple to be faulty. It must trigger a failure somewhere else.
It's happened before, quite often. The commit might be right, but it also might not (the lack of tests is a bit disturbing). Just counting by the number of lines changed isn't a good way to judge whether a commit is a likely candidate for a regression.
That native CRT libraries fix the problem is probably good enough confirmation that the bisect is accurate.
https://bugs.winehq.org/show_bug.cgi?id=48261
Erik Hacklin erik.hacklin@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #65939|0 |1 is obsolete| |
--- Comment #13 from Erik Hacklin erik.hacklin@gmail.com --- Created attachment 65960 --> https://bugs.winehq.org/attachment.cgi?id=65960 Log with WINEDEBUG=+msvcrt enabled (wine-staging 4.21-1)
https://bugs.winehq.org/show_bug.cgi?id=48261
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Batman: Arkham Knight hangs |Batman: Arkham Knight hangs |when trying to close |when trying to close |upgrade screen (regression) |upgrade screen
https://bugs.winehq.org/show_bug.cgi?id=48261
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEEDINFO |RESOLVED Fixed by SHA1| |763868243399c6230afe03110b2 | |8c2ae271845f6
--- Comment #14 from Alexandre Julliard julliard@winehq.org --- Hopefully fixed by 763868243399c6230afe03110b28c2ae271845f6.
https://bugs.winehq.org/show_bug.cgi?id=48261
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.0-rc2.