[Bug 16594] New: Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Summary: Oberon game launcher does not show the buttons to launch
                    the game.
           Product: Wine
           Version: 1.1.11
          Platform: Other
               URL: http://gamecenter.oberon-
                    media.com/game.htm?code=115770900&RefId=&origin=pindex_n
                    g_r
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: mshtml
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

This is a regression from previous versions.

If you run the installer and then get it to launch the game, you see the
launcher backdrop but no buttons are displayed. This is a HTML control that is
produced by Launch.exe in the install folder.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #1 from Lei Zhang   2008-12-22 12:29:39 ---
Time for a regression test?

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #2 from Austin English   2008-12-22 13:17:53 ---
http://wiki.winehq.org/RegressionTesting

Does the demo have the same problem?

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #3 from Reece Dunn   2008-12-22 13:20:29 ---
The demo should have the same problem (affects all Oberon games) - it is the
same as the full game, but with a 1 hour playing limit on it.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #4 from Reece Dunn   2008-12-22 17:12:26 ---
I have run git bisect and have the following results:

commit 7a8cfdee6dc3aca8579ae5660d6c9694d78cbb88 - bad [fix crash]
commit c3bdda810243ed6c8d6b9960d1df3b534653b438 - crash
commit 6906c2f1baf039dc7069d179a3e5d5c2f9e9b2c7 - good

6906... is the last commit that displayed the buttons. c3bdd... (the next
commit along) causes Launch.exe to crash. 7a8cf... is the first commit that
does not display buttons, but is also the commit that fixes the crash.

Therefore, the commit that caused this regression is somewhere in
6906c2..7a8cfd. Since the commits in this range crash, I cannot proceed
further.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #5 from Austin English   2008-12-22 18:22:23 ---
(In reply to comment #4)
> I have run git bisect and have the following results:
>
> commit 7a8cfdee6dc3aca8579ae5660d6c9694d78cbb88 - bad [fix crash]
> commit c3bdda810243ed6c8d6b9960d1df3b534653b438 - crash
> commit 6906c2f1baf039dc7069d179a3e5d5c2f9e9b2c7 - good
>
> 6906... is the last commit that displayed the buttons. c3bdd... (the next
> commit along) causes Launch.exe to crash. 7a8cf... is the first commit that
> does not display buttons, but is also the commit that fixes the crash.
>
> Therefore, the commit that caused this regression is somewhere in
> 6906c2..7a8cfd. Since the commits in this range crash, I cannot proceed
> further.

You can still test using:
http://wiki.winehq.org/ReverseRegressionTesting

Short version:
$ git bisect reset
$ git bisect good 6906c2f1baf039dc7069d179a3e5d5c2f9e9b2c7
$ git bisect bad 7a8cfdee6dc3aca8579ae5660d6c9694d78cbb88

Now, if HEAD is BEFORE c3bdda810243^:
$ ./configure && make depend && make
$ ~/wine-git/wine foo.exe

If HEAD is AFTER c3bdda810243^, use:
$ git show c3bdda810243ed6c8d6b9960d1df3b534653b438 | patch -p1 -R &&
./configure && make depend && make && git show
c3bdda810243ed6c8d6b9960d1df3b534653b438 | patch -p1
$ ~/wine-git/wine foo.exe

Rinse, lather, repeat.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #6 from Reece Dunn   2008-12-23 08:21:05 ---
Thanks Austin.

Applying that technique, i found that all the commits in the range where it was
crashing were good using that technique.

Further investigation has revealed that the commit that causes this bug is...
c3bdda810243ed6c8d6b9960d1df3b534653b438!

commit c3bdda810243ed6c8d6b9960d1df3b534653b438
Author: Jacek Caban 
Date:   Wed Sep 24 18:19:46 2008 +0200

mshtml: Use ActiveScript for JavaScript in file protocol documents.

I have verified this by building the first bad non-crash commit with and
without the commit reverted.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #7 from Austin English   2008-12-23 11:37:58 ---
The download shows this as well.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #8 from Austin English   2008-12-23 11:38:21 ---
Created an attachment (id=18151)
 --> (http://bugs.winehq.org/attachment.cgi?id=18151)
+mshtml in git

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Paul "TBBle" Hampson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Paul "TBBle" Hampson   2009-01-29 18:10:12 ---
Probably need a +jscript trace as well, since the +mshtml trace indicates that
JScript is being switched to successfully.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Reece Dunn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13459

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

--- Comment #10 from Reece Dunn   2009-11-08 05:25:19 ---
The buttons are now being displayed in the latest git, but they don't contain
any text.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

surfing86  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from surfing86  2011-03-01 11:11:07 CST ---
I have a similar problem with World of Tanks Launcher.
http://bugs.winehq.org/show_bug.cgi?id=25898

I don't know if my bug 25898 is a duplicated of this or not.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Jacek Caban  2011-07-09 10:39:57 CDT ---
Please retest the bug, it's most likely fixed.
> I don't know if my bug 25898 is a duplicated of this or not.

It doesn't seem to be.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |c3bdda810243ed6c8d6b9960d1d
                   |                            |f3b534653b438

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from André H.  2011-10-03 10:52:44 CDT ---
still not retested after 3 month. (i also bet it's fixed)

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Jacek Caban  2011-10-07 11:25:19 CDT ---
Still not retested and problems shown by logs are fixed for a while now.
Resolving fixed. If there are more problems, please file a new bug.

[Bug 16594] Oberon game launcher does not show the buttons to launch the game.

http://bugs.winehq.org/show_bug.cgi?id=16594

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  2011-10-10 13:11:36 CDT ---
Closing bugs fixed in 1.3.30.