[Bug 52639] New: comctl32:toolbar test_visual() fails in Wine with the Light theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52639

Bug ID: 52639
           Summary: comctl32:toolbar test_visual() fails in Wine with the
                    Light theme
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

In comctl32:toolbar, test_visual() fails in Wine with the Light theme

toolbar.c:2674: Test failed: Expected same content.

https://test.winehq.org/data/patterns.html#comctl32:toolbar

A bisect pointed to the following commit as the trigger for this failure, thus
establishing the link with the Light theme:

commit ccc2c6c613264aa228bd6b113dffebc7bcf2c1f3
Author: Zhiyi Zhang 
Date:   Wed Mar 2 14:21:48 2022 +0800

wine.inf: Enable Light theme by default.

Signed-off-by: Zhiyi Zhang 
    Signed-off-by: Alexandre Julliard

[Bug 52639] comctl32:toolbar test_visual() fails in Wine with the Light theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52639

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase
    Regression SHA1|                            |ccc2c6c613264aa228bd6b113df
                   |                            |febc7bcf2c1f3

[Bug 52639] comctl32:toolbar test_visual() fails in Wine with the Light theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52639

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zhiyi Zhang  ---
It's not happening on my machine. Maybe something is different on TestBots. I
will take a look when I am free.

[Bug 52639] comctl32:toolbar test_visual() fails in Wine with the Light theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52639

--- Comment #2 from François Gouget  ---
One thing they have in common is that they all run Debian 11. But the failures
happen on my desktop which runs KDE while the TestBot boxes run fvwm. So it
does not seem to be related to the window manager.

[Bug 52639] comctl32:toolbar test_visual() fails in Wine with the Light theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52639

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |7de22a743827e4a74b228b851f5
                   |                            |08db9eee1f8d1
             Status|NEW                         |RESOLVED

--- Comment #3 from Zhiyi Zhang  ---
Fixed by 7de22a743827e4a74b228b851f508db9eee1f8d1

[Bug 52639] comctl32:toolbar test_visual() fails in Wine with the Light theme

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52639

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 7.4.