http://bugs.winehq.org/show_bug.cgi?id=29934
Bug #: 29934 Summary: Weird Worlds: Launcher no longer launches the game Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: samurai_no_densetsu@yahoo.es Classification: Unclassified
Weird Worlds's launcher no longer works as expected. Since this is a regression, I did a regression test but it was unsuccessful.
The launcher works fine from wine-1.0 to wine-1.3.25, including the stable version wine-1.2.3. So I tried to bisect 1.3.25 against 1.4-rc4.
When I was doing the bisection learned that between wine-1.3.27 and wine-1.3.33 (both included) the launcher didn't even appear, and manually had to skip all that range, and within wine-1.3.34 to wine-1.4-rc4 the menu launcher is there but no longer launches the game. Can't provide a regression id as the issue clearly raised between wine-1.3.27 and wine-1.3.33, versions in which the launcher does not start so is virtually impossible to test.
Didn't noticed earlier as the game can be launched from scripts or commandline this way: wine weird.exe -skiplauncher -game default
Luckyly there's a demo showing the same behaviour here: http://www.shrapnelgames.com/Demos/DD_WW_win.html
I wish I could add more info, but that's all I have right now.
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #1 from joaopa jeremielapuree@yahoo.fr 2012-02-18 22:06:06 CST --- Created attachment 38959 --> http://bugs.winehq.org/attachment.cgi?id=38959 winedbg output
With wine-1.4.rc4 and the demo, no launcher appears and I have the attached backtrace.
http://bugs.winehq.org/show_bug.cgi?id=29934
Dmitry Timoshkov dmitry@baikal.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Version|unspecified |1.4-rc4
http://bugs.winehq.org/show_bug.cgi?id=29934
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW URL| |http://www.shrapnelgames.co | |m/Demos/DD_WW_win.html CC| |mstefani@redhat.com Ever Confirmed|0 |1
--- Comment #2 from Michael Stefaniuc mstefani@redhat.com 2012-02-19 03:00:22 CST --- Filling some fields
http://bugs.winehq.org/show_bug.cgi?id=29934
PommeGolden lapommegolden@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lapommegolden@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #3 from Austin English austinenglish@gmail.com 2012-02-20 05:23:27 CST --- First regression was: austin@aw21 ~/wine-git $ git bisect bad 76fecde8fb2d335e4855bec6d36ffe16cbed04f3 is the first bad commit commit 76fecde8fb2d335e4855bec6d36ffe16cbed04f3 Author: Stefan D��singer stefan@codeweavers.com Date: Fri Aug 26 14:22:40 2011 +0200
ddraw: Introduce a function to convert a DDSURFACEDESC to a DDSURFACEDESC2.
:040000 040000 5e597610866aded4d579f3406fb158e950e740c3 5bffaefddf571ab094cca924f12bc5544ade8c1b M dlls
which causes the game to crash before getting to the launcher. It was fixed by: austin@aw21 ~/wine-git $ git bisect good c3d6061593601463ac96d632956b645c4c6342c2 is the first bad commit commit c3d6061593601463ac96d632956b645c4c6342c2 Author: Stefan D��singer stefan@codeweavers.com Date: Sat Oct 15 15:41:17 2011 +0200
ddraw: Add more tests and fixes for SetSurfaceDesc.
:040000 040000 e41a0d16193c8e6c21ec29980e2bfb0d9d334708 ce9aa6283c6b6feca2a5014839c13e861c1cc8d7 M dlls
See also bug 28259 and bug 28885. Haven't tried the second one yet, ddraw has a few conflicts for those patches on older versions :.
http://bugs.winehq.org/show_bug.cgi?id=29934
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hverbeet@gmail.com Regression SHA1| |94ae743ea668e49d40ae4e2dc5f | |e1f5d9be018cb
--- Comment #4 from Austin English austinenglish@gmail.com 2012-02-20 06:32:18 CST --- Well, the other regression is our old friend: 94ae743ea668e49d40ae4e2dc5fe1f5d9be018cb is the first bad commit commit 94ae743ea668e49d40ae4e2dc5fe1f5d9be018cb Author: Henri Verbeet hverbeet@codeweavers.com Date: Tue Aug 30 20:12:31 2011 +0200
ddraw: Make the OpenGL renderer the default one.
interestingly though, using 'winetricks ddr=gdi' on current git crashes the game before the launcher starts.
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #5 from Athrun samurai_no_densetsu@yahoo.es 2012-02-20 08:59:18 CST --- I am concerned about if we are experiencing the same bug. I have noticed that the demo is based on the old 1.0 release that had extra issues (in wine the demo worked fine circa wine-1.2.x to wine-1.3.25 but can't be sure right now), so, to ensure that we aren't looking at different bugs I developed a method to ensure that this isn't happening (is a little bit hackish method though).
Steps are the following:
There's a upgrade patch for the full version at: http://download.shrapnelgames.com/downloads/weirdworlds_v122patch.exe , please download it.
It is just a self extracting zip file, but don't install it, just "unzip weirdworlds_v122patch.exe" somewhere, and there will be a bunch of files. Rename the extracted weird.exe to weird_v1.22.exe (or whatever you want name it), and copy only weird_v1.22.exe to the folder where the demo is installed, this is very important as if you copy all the files the game will expect the full version of thegame and will fail to start.
Run the game with "wine weird_v1.22.exe" (or if you want to see if the game starts without launcher "wine weird_v1.22.exe -skiplauncher -game default"). The game will start, show the intro credits, and will hang or crash at the main screen, but this is expected due to the missing files, and can be closed with alt+f4.
Joaopa, Austin, will you be kind enough to give it a try this way?
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #6 from Henri Verbeet hverbeet@gmail.com 2012-02-21 07:07:35 CST --- Created attachment 39005 --> http://bugs.winehq.org/attachment.cgi?id=39005 hack
The issue (in the demo at least) is that wined3d sets a pixel format on the window. When the application itself then tries to initialize GL and set a pixel format on the window SetPixelFormat() fails because one is already set. The attached hack is a workaround, but it's probably non-trivial to fix this properly.
http://bugs.winehq.org/show_bug.cgi?id=29934
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #7 from Austin English austinenglish@gmail.com 2012-02-21 17:30:34 CST --- (In reply to comment #6)
Created attachment 39005 [details] hack
The issue (in the demo at least) is that wined3d sets a pixel format on the window. When the application itself then tries to initialize GL and set a pixel format on the window SetPixelFormat() fails because one is already set. The attached hack is a workaround, but it's probably non-trivial to fix this properly.
works, though if directdrawrenderer is set to gdi, still broken (though I assume that's deprecated and going away).
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #8 from Athrun samurai_no_densetsu@yahoo.es 2012-02-21 19:34:46 CST --- Confirming that with the hack the full version also works.
http://bugs.winehq.org/show_bug.cgi?id=29934
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #9 from joaopa jeremielapuree@yahoo.fr 2013-04-19 22:18:10 CDT --- Still a bug in current wine?
http://bugs.winehq.org/show_bug.cgi?id=29934
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |directx-d3d
http://bugs.winehq.org/show_bug.cgi?id=29934
HH winebugs@mailinator.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winebugs@mailinator.com
--- Comment #10 from HH winebugs@mailinator.com --- Still a bug in wine 1.7.2
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #11 from Ken Thomases ken@codeweavers.com --- (In reply to comment #6)
The issue (in the demo at least) is that wined3d sets a pixel format on the window. When the application itself then tries to initialize GL and set a pixel format on the window SetPixelFormat() fails because one is already set. The attached hack is a workaround, but it's probably non-trivial to fix this properly.
I didn't look into how/when the game is using ddraw vs. OpenGL but is there any value in modifying wglSetPixelFormatWINE() so that it can reset a window's pixel format back to 0? The driver could clear its internal format-related state. User32's __wine_set_pixel_format() doesn't protect against resetting the pixel format. The wineserver will not remove PAINT_HAS_PIXEL_FORMAT from the window's paint_flags, which I believe means the window won't draw via its surface, but if the game is going to use OpenGL that should be fine.
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #12 from Henri Verbeet hverbeet@gmail.com --- (In reply to comment #11)
I didn't look into how/when the game is using ddraw vs. OpenGL but is there any value in modifying wglSetPixelFormatWINE() so that it can reset a window's pixel format back to 0?
We'd have to do that on every exit from wined3d, i.e. essentially on every context_release() call, since we can't know if the application is going to use OpenGL some time in the future. I guess it would probably work, but I suspect there would be a performance impact.
http://bugs.winehq.org/show_bug.cgi?id=29934
Johan Gardhage johan.gardhage@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |johan.gardhage@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #13 from Ken Thomases ken@codeweavers.com --- Please see bug 35718, comment 39, which has a patch to test which should also work for this bug. Thanks.
http://bugs.winehq.org/show_bug.cgi?id=29934
Ken Thomases ken@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ken@codeweavers.com
http://bugs.winehq.org/show_bug.cgi?id=29934
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gyebro69@gmail.com See Also| |http://bugs.winehq.org/show | |_bug.cgi?id=35718
--- Comment #14 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Ken Thomases from comment #13)
Please see bug 35718, comment 39, which has a patch to test which should also work for this bug. Thanks.
This bug seems to affect only the demo version (v1.00), but not the full version (v1.30) on my system, tested with current git (wine-1.7.17-28-g5ef5490). With the mentioned patch from bug #35718 the demo version runs too.
Fedora 20 Nvidia binary drivers 337.12
https://bugs.winehq.org/show_bug.cgi?id=29934
Linards linards.liepins@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |linards.liepins@gmail.com
--- Comment #15 from Linards linards.liepins@gmail.com --- (In reply to Béla Gyebrószki from comment #14)
(In reply to Ken Thomases from comment #13)
Please see bug 35718, comment 39, which has a patch to test which should also work for this bug. Thanks.
This bug seems to affect only the demo version (v1.00), but not the full version (v1.30) on my system, tested with current git (wine-1.7.17-28-g5ef5490). With the mentioned patch from bug #35718 the demo version runs too.
Fedora 20 Nvidia binary drivers 337.12
Could you re-test, please?
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #16 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Linards from comment #15)
Could you re-test, please?
The problem is present in wine-1.7.46-296-gcf7a118 and with game version 1.22. Weird Worlds v1.30 starts properly though.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #17 from Linards linards.liepins@gmail.com --- (In reply to Béla Gyebrószki from comment #16)
(In reply to Linards from comment #15)
Could you re-test, please?
The problem is present in wine-1.7.46-296-gcf7a118 and with game version 1.22. Weird Worlds v1.30 starts properly though.
I think the best way would be to create seperate AppDB entry for version 1.30 ; And create new AppDB test result entry for version 1.22. It then would be obvious that game was the problem, not wine binaries.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #18 from Linards linards.liepins@gmail.com --- (In reply to Béla Gyebrószki from comment #16)
(In reply to Linards from comment #15)
Could you re-test, please?
The problem is present in wine-1.7.46-296-gcf7a118 and with game version 1.22. Weird Worlds v1.30 starts properly though.
Besides, this bug is FIXED, because with same wine version game works.
https://bugs.winehq.org/show_bug.cgi?id=29934
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #19 from super_man@post.com --- Can this bug be tested anymore? The download url is dead. Google gives steam version of the game.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #20 from joaopa jeremielapuree@yahoo.fr --- Bug still there with current wine
http://www.fileplanet.com/161340/download/Weird-Worlds:-Return-to-Infinite-S...
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #21 from super_man@post.com --- (In reply to joaopa from comment #20)
Bug still there with current wine
http://www.fileplanet.com/161340/download/Weird-Worlds:-Return-to-Infinite- Space-Demo
Confirming. Does't work either wine 1.9.6 or staging 1.9.6.
Maybe related line fixme:wgl:X11DRV_wglChoosePixelFormatARB unused pfAttribFList
https://bugs.winehq.org/show_bug.cgi?id=29934
Andrew Kanaber akanaber@chiark.greenend.org.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |akanaber@chiark.greenend.or | |g.uk
--- Comment #22 from Andrew Kanaber akanaber@chiark.greenend.org.uk --- I bisected for the regression since Weird Worlds worked with wine 1.6.2, the first bad commit is c92451f295242110bf016facf0e80564f3643d94 wined3d: Always use the same formats in context_create() when "always_offscreen" is enabled.
Since it worked in the 1.6 series this is presumably a different bug than the one that was first reported in 1.4, but with the same symptom that the Weird Worlds launcher no longer starts the game[1], so I believe this is what the more recent reports here are discussing.
[1] launcher window appears as expected, clicking "START" just closes the window instead of running the game
https://bugs.winehq.org/show_bug.cgi?id=29934
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #23 from winetest@luukku.com --- (In reply to Andrew Kanaber from comment #22)
Can you provide a working download?
https://bugs.winehq.org/show_bug.cgi?id=29934
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia@gmail.com URL|http://www.shrapnelgames.co |http://www.fileplanet.com/1 |m/Demos/DD_WW_win.html |61340/download/Weird-Worlds | |:-Return-to-Infinite-Space- | |Demo
https://bugs.winehq.org/show_bug.cgi?id=29934
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx@gmail.com, | |dimesio@earthlink.net
--- Comment #24 from winetest@luukku.com --- (In reply to winetest from comment #23)
(In reply to Andrew Kanaber from comment #22)
Can you provide a working download?
Actually the url field seems to work. Installed the exe, launched the game via the installer and have no issues gettin into game.
Fixed?
wine 2.0rc4-git.
https://bugs.winehq.org/show_bug.cgi?id=29934
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox_xerox2000@yahoo.co.uk
https://bugs.winehq.org/show_bug.cgi?id=29934
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #25 from André H. nerv@dawncrow.de --- Does https://source.winehq.org/git/wine.git/commit/5fd9344362d43d13ee3131fa5619f2... help here?
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #26 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to André H. from comment #25)
Does https://source.winehq.org/git/wine.git/commit/ 5fd9344362d43d13ee3131fa5619f25d57dd5f03 help here?
No, it doesn't help.
Tested with Weird Worlds Demo 1.00 and Weird Worlds 1.22 (full).
wine-2.0-rc5-24-gb510dcc OpenGL vendor string: NVIDIA Corporation OpenGL renderer string: GeForce GT 730/PCIe/SSE2 OpenGL core profile version string: 4.5.0 NVIDIA 375.26
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #27 from winetest@luukku.com --- I just retested, fresh wineprefix, download taken from fileplanet.
The installer suggest lauching the game via the installer. This works. Now I tried to cd into the directory and start the launcher. Launcher starts, game starts...
I can't reproduce this.
$ wine --version wine-2.0-rc5-24-gb510dcc
I don't have full game.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #28 from Andrew Kanaber akanaber@chiark.greenend.org.uk --- Still broken for me in Wine 3.2, testing the demo from fileplanet in a clean wineprefix. Any debugging suggestions? Thanks.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #29 from joaopa jeremielapuree@yahoo.fr --- For me launcher now starts. But game still crashes. And I still have the infamous
fixme:wgl:X11DRV_wglChoosePixelFormatARB unused pfAttribFLis
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #30 from joaopa jeremielapuree@yahoo.fr --- I forgot to say that it is with wine-.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #31 from joaopa jeremielapuree@yahoo.fr --- Original issue is fixed in wine-4.9. X11DRV_wglChoosePixelFormatARB problem is a duplicate of bug 14640. Can an administrator close this bug as fixed?
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #32 from Andrew Kanaber akanaber@chiark.greenend.org.uk --- With 4.9, Weird Worlds does get as far as changing the screen resolution before dieing, whereas with earlier wines it just failed immediately. So that's an improvement I guess.
I also see the "fixme:wgl:X11DRV_wglChoosePixelFormatARB unused pfAttribFList" message.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #33 from joaopa jeremielapuree@yahoo.fr --- The policy of wine is one bug per report. Original bug is fixed as you confirm. Can an administrator close this bug as FIXED?
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #34 from joaopa jeremielapuree@yahoo.fr --- For me the game is plainly playable with wine-6.18.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #35 from Andrew Kanaber akanaber@chiark.greenend.org.uk --- Confirmed, fixed for me too with 6.18. Thanks.
https://bugs.winehq.org/show_bug.cgi?id=29934
--- Comment #36 from joaopa jeremielapuree@yahoo.fr --- Reported fixed by the two last comments. Can an administrator close thus bug as FIXED?
https://bugs.winehq.org/show_bug.cgi?id=29934
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #37 from Michael Stefaniuc mstefani@winehq.org --- Reported resolved.
https://bugs.winehq.org/show_bug.cgi?id=29934
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #38 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc2.