[Bug 40833] New: Batman: Arkham Origins Blackgate no sound during gameplay (except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Bug ID: 40833
           Summary: Batman: Arkham Origins Blackgate no sound during
                    gameplay (except cutscenes)
           Product: Wine
           Version: 1.9.12
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: xaudio2
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ---

Created attachment 54794
  --> https://bugs.winehq.org/attachment.cgi?id=54794
log

Using native xaudio2_7 is a workaround.

wine-1.9.12-161-g754c681

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

--- Comment #1 from Andrew Eikum  ---
There's a suspicious crash on the audio thread:

14383.024:002b:trace:xaudio2:do_engine_tick Calling OnVoiceProcessingPassStart
with BytesRequired: 7680
14383.024:002b:trace:xaudio2:XA2SRC_GetState 0x17f558, 0x1f1e968, 0x0
14383.024:002b:trace:xaudio2:XA2SRC_GetState returning d3de0, queued: 4
14383.026:002b:trace:seh:raise_exception code=c0000005 flags=0 addr=0x7b0f4f63
ip=7b0f4f63 tid=002b

Probably need to add some debug logging to find out precisely where it's
crashing.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

--- Comment #2 from Andrew Eikum  ---
Created attachment 54797
  --> https://bugs.winehq.org/attachment.cgi?id=54797
additional xaudio debug logging

Can you apply this patch and build, then get me another audio log?

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

--- Comment #3 from Andrey Gusev  ---
Created attachment 54818
  --> https://bugs.winehq.org/attachment.cgi?id=54818
log2

Log with patch.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

--- Comment #4 from Andrew Eikum  ---
Thanks. I think this is because the application has two XAudio2 instances
running at the same time. This eventually causes a problem where we have the
wrong context selected when we try to do OpenAL operations. Probably we should
have a lock and use alcMakeContextCurrent before doing any OpenAL operations.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

--- Comment #5 from Andrew Eikum  ---
Created attachment 54830
  --> https://bugs.winehq.org/attachment.cgi?id=54830
xaudio2: Always set current OpenAL context before making AL calls

Can you see if this patch helps?

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54830|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Eikum  ---
Created attachment 54832
  --> https://bugs.winehq.org/attachment.cgi?id=54832
xaudio2: Always set current OpenAL context before making AL calls

That one was broken, try this one instead.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54832|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Eikum  ---
Created attachment 54844
  --> https://bugs.winehq.org/attachment.cgi?id=54844
xaudio2: Always set current OpenAL context before making AL calls

One more version to test.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

--- Comment #8 from Andrey Gusev  ---
(In reply to Andrew Eikum from comment #7)
> Created attachment 54844 [details]
> xaudio2: Always set current OpenAL context before making AL calls
>
> One more version to test.

Also works.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |49078e00a51876df38d0c572193
                   |                            |195be6700bad0
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Andrey Gusev  ---
Fixed by commit
http://source.winehq.org/git/wine.git/commit/49078e00a51876df38d0c572193195b...

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.14.

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.8.x
                 CC|                            |[e-mail]

[Bug 40833] Batman: Arkham Origins Blackgate no sound during gameplay ( except cutscenes)

https://bugs.winehq.org/show_bug.cgi?id=40833

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #11 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.4.