https://bugs.winehq.org/show_bug.cgi?id=37750
Bug ID: 37750 Summary: Assassin's Creed: graphical issues in the menus and in-game Product: Wine Version: 1.7.29 Hardware: x86 OS: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: gyebro69@gmail.com CC: hverbeet@gmail.com Regression SHA1: ee8a5b7dd1e554ef32229c766715f23ba17c9f6c Distribution: ---
Created attachment 50263 --> https://bugs.winehq.org/attachment.cgi?id=50263 screenshot (comparison)
Text in the menus is too bright/blurred. There are visual glitches in the game as well, as you can see in the attached screenshot.
These messages are filling the terminal as soon as the problem appears:
err:d3d:wined3d_debug_callback 0x35a3538: "GL_INVALID_VALUE error generated. Size and/or offset out of range.". err:d3d_surface:wined3d_volume_upload_data >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glTexSubImage3D @ volume.c / 114
I see the same messages in a couple of other games as well (Metro: Last Light, Burnout Paradise, XCOM:Enemy Unknown).
The problem is present since
ee8a5b7dd1e554ef32229c766715f23ba17c9f6c is the first bad commit commit ee8a5b7dd1e554ef32229c766715f23ba17c9f6c Author: Henri Verbeet hverbeet@codeweavers.com Date: Wed Oct 8 08:47:20 2014 +0200
wined3d: Track texture allocation per-texture.
:040000 040000 02dba0093d24ae89c3c4ebcb3de609d01a618614 e5bf7a4032c6c2959631cc5b49d7ba9b73a47a2b M dlls
Please let me know if you need debug logs.
wine-1.7.33-40-gca51e11 Fedora 20 Geforce 250 / Nvidia binary drivers 340.65
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #1 from Béla Gyebrószki gyebro69@gmail.com --- Not sure if this is about the exact same problem, but Arx Fatalis also has texture corruption and that was caused by the same commit: ee8a5b7dd1e554ef32229c766715f23ba17c9f6c
You can reproduce the problem with Arx Fatalis demo version: http://www.4players.de/4players.php/download_info/Downloads/Download/3752/Ar...
Texture corruption is present in the intro video as well as in the main game.
wine-1.7.33-146-g102d893 Nvidia binary drivers 340.65
https://bugs.winehq.org/show_bug.cgi?id=37750
mrdeathjr28@yahoo.es changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrdeathjr28@yahoo.es
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #2 from mrdeathjr28@yahoo.es --- Confirmed in my case too using this hardware
Nvidia Drivers 346.22 Linux Mint 17 XFCE Edition 64Bit - Kernel 3.13.0.24 CPU: INTEL Pentium G3220 (Nucleo Haswell 22nm) 3.0Ghz (Dual-Core) Stock Clock MEM: 8GB DDR3 1333 (2x4) Patriot value (128 bit dual channel: 21.3 gb/s) GPU: Zotac Nvidia Geforce GT630 (GK208 28nm: 384 Shaders / 8 ROPS) Zone Edition Passive Cooling 2GB DDR3 1800Mhz 64Bit (14.4Gb/s) BOARD: MSI H81M E33
Youtube gameplay video
https://www.youtube.com/watch?v=sg44Rs18Jo0
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #3 from Béla Gyebrószki gyebro69@gmail.com --- Still present in 1.7.36, Nvidia binary drivers 340.76
The rendering problem in Assassin's Creed doesn't exist with the latest CSMT patchset.
In comment #1 I could have been wrong, the other games that also have graphical issues due to commit ee8a5b are old, Directx 6/7 games (like Arx Fatalis, Fleet Command or Simon the Sorcerer 3D) whereas AC is using Directx9. Using CSMT doesn't resolve the graphical issues in those old games so that could be a different problem.
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #4 from Béla Gyebrószki gyebro69@gmail.com --- The graphical issues in Assassin's Creed are still present even after http://source.winehq.org/git/wine.git/commitdiff/e53d22b0c002bbea2dfa3fc40d9...
On the other hand, the problem is fixed in the other games (Fleet Command, Simon the Sorcerer 3D etc).
wine-1.7.36-144-g4d43d36 Nvidia binary drivers 340.76
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #5 from mrdeathjr28@yahoo.es --- With wine 1.7.39 + nvidia 349.12 graphics errors stay but now dont appear all in white, now appears more darker
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #6 from Henri Verbeet hverbeet@gmail.com --- If it's not too much effort, could you try bisecting the CSMT patches to see which patch fixes it? Either way, could you please attach a +tid,+d3d9,+d3d,+d3d_surface,+d3d_texture log?
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #7 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Henri Verbeet from comment #6)
If it's not too much effort, could you try bisecting the CSMT patches to see which patch fixes it? Either way, could you please attach a +tid,+d3d9,+d3d,+d3d_surface,+d3d_texture log?
The generated log is almost 700 MB in uncompressed form even though I removed the intro videos and ran the game until it reached the point in the menus where the problem is clearly visible. Download link to the compressed log: https://drive.google.com/open?id=0B-tTbLKBl-tOOE1FZHhXS3g4U2M
The commit that fixes the problem should be
44de8bdf554f05c0b416a1e356515579422174ff is the first bad commit commit 44de8bdf554f05c0b416a1e356515579422174ff Author: Stefan Dösinger stefan@codeweavers.com Date: Sat Jul 6 22:52:06 2013 +0200
wined3d: Ignore buffer->resource.map_count in the CS
This fixes sporadic test failures caused by preload refusing to load data into the GL buffer.
It's fine to preload or create a VBO if a DISCARD or NOOVERWRITE map is happening at the same time. A non-dynamic map will finish the CS before incrementing map_count.
During bisecting there was a skipped commit when the game crashed on start, there were 2 commits when so many artefacts were rendered that I could barely decide whether the issue was present or not.
'git checkout 44de8bdf554f05c0b416a1e356515579422174ff' --> the reported problem doesn't exist but there are many other graphical glitches in the game 'git reset --hard HEAD^' --> the problem is present (along with other glitches)
I used Stefan's git repository to do the bisect.
https://bugs.winehq.org/show_bug.cgi?id=37750
Matteo Beniamino beniamino@tautologica.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |beniamino@tautologica.org
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #8 from Henri Verbeet hverbeet@gmail.com --- Created attachment 51270 --> https://bugs.winehq.org/attachment.cgi?id=51270 patch
This is a bit of a guess, but does the attached patch make it any better/worse?
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #9 from Béla Gyebrószki gyebro69@gmail.com --- (In reply to Henri Verbeet from comment #8)
Created attachment 51270 [details] patch
This is a bit of a guess, but does the attached patch make it any better/worse?
I tested your patch and it indeed fixes the issue for me, thank you. Was the debug log helpful for you or the result of the bisect gave you some hints?
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #10 from Henri Verbeet hverbeet@gmail.com --- (In reply to Béla Gyebrószki from comment #9)
I tested your patch and it indeed fixes the issue for me, thank you. Was the debug log helpful for you or the result of the bisect gave you some hints?
Mostly the debug log. The CSMT patch doesn't seem directly related to the issue, I guess it mostly ends up changing the order in which things get called, which happens to make the bug go away. (Which would make sense for this kind of bug.) Similarly, the regression commit isn't directly related to the issue either, the wined3d_texture_bind_and_dirtify() calls were missing before that commit as well, but it cuts down on the amount of times other things end up binding the texture.
https://bugs.winehq.org/show_bug.cgi?id=37750
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |52478e38095e8d1c70fcdbcfb09 | |1dee419c37bc6 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #11 from Béla Gyebrószki gyebro69@gmail.com --- Patch committed as http://source.winehq.org/git/wine.git/commitdiff/52478e38095e8d1c70fcdbcfb09...
Marking fixed.
wine-1.7.40-156-gba00e8e
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #12 from Andrey Gusev andrey.goosev@gmail.com --- *** Bug 38218 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=37750
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.41.
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #14 from mrdeathjr28@yahoo.es --- White color issue on Assasins Creed and colors on Call of duty world at war (single and multiplayer) are corrected in wine 1.7.41
System Specs
Nvidia Drivers 349.12 Linux Mint 17 XFCE Edition 64Bit - Kernel 3.18.0.31 CPU: INTEL Pentium G3220 (Haswell 22nm) 3.0Ghz MEM: 8GB DDR3 1333 (2x4) Patriot value (dual channel: 21.3 gb/s) GPU: Zotac Nvidia Geforce GT630 (GK208 28nm: 384 Shaders / 8 ROPS) Zone Edition Passive Cooling 2GB DDR3 1800Mhz 64Bit (14.4Gb/s) BOARD: MSI H81M E33
https://bugs.winehq.org/show_bug.cgi?id=37750
--- Comment #15 from mrdeathjr28@yahoo.es --- Also correct color issues in facry 3 with wine 1.7.41
System Specs
Nvidia Drivers 349.12 Linux Mint 17 XFCE Edition 64Bit - Kernel 3.18.0.31 CPU: INTEL Pentium G3220 (Haswell 22nm) 3.0Ghz MEM: 8GB DDR3 1333 (2x4) Patriot value (dual channel: 21.3 gb/s) GPU: Zotac Nvidia Geforce GT630 (GK208 28nm: 384 Shaders / 8 ROPS) Zone Edition Passive Cooling 2GB DDR3 1800Mhz 64Bit (14.4Gb/s) BOARD: MSI H81M E33
-
wine-bugs＠winehq.org