[Bug 19948] New: Regression: Starscape OpenGL graphics broken by b5da7f...

http://bugs.winehq.org/show_bug.cgi?id=19948

Summary: Regression: Starscape OpenGL graphics broken by
                    b5da7f...
           Product: Wine
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

b5da7f49d332ed5d64be1256e14035af74a7efa2 (wined3d: Don't reuse random GL
contexts during initialization.) breaks Starscape OpenGL graphics (on nvidia).

To reproduce:

Download demo (http://www.moonpod.com/English/downloads.php), install, start,
choose OpenGL mode (Direct3D will not work in any case), screen stays black
with bad commit (music still playing). Game is reported to work up to Wine
1.1.22 (see
http://appdb.winehq.org/objectManager.php?sClass=version&iId=13590&i...).

git bisect output:

$ git bisect good
b5da7f49d332ed5d64be1256e14035af74a7efa2 is first bad commit
commit b5da7f49d332ed5d64be1256e14035af74a7efa2
Author: Henri Verbeet 
Date:   Thu Jul 2 10:01:37 2009 +0200

wined3d: Don't reuse random GL contexts during initialization.

Obviously there's no guarantee about the state of such a context. The
specific
    problem is that it might have GL_UNPACK_CLIENT_STORAGE_APPLE enabled,
causing
    some glTexImage2D() calls to fail, but it's a bad idea in general.

:040000 040000 91e52fba45ce42a6e4c1fce4281308745aea44cf
ae1eecf091bdc72d34e708399ebd1670b198e00f M      dlls

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                URL|                            |http://www.moonpod.com/Engl
                   |                            |ish/downloads.php
            Version|unspecified                 |1.1.25
            Summary|Regression: Starscape       |Starscape OpenGL mode -
                   |OpenGL graphics broken by   |screen stays black
                   |b5da7f...                   |

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #1 from Henri Verbeet   2009-09-11 09:31:20 ---
That commit doesn't make any difference for me. Both with
50e9ad66e2d6b170d47b0e79cc4e04fb219a1455 (the commit before
b5da7f49d332ed5d64be1256e14035af74a7efa2) and current git I get a black screen.
In both versions it becomes visible when I click inside the window.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #2 from M.Kiesel   2009-09-11 10:35:55 ---
That's odd. With 50e9ad66e2d6b170d47b0e79cc4e04fb219a1455 everything works for
me (Moonpod intro, game intro, Demo nag screen are shown). With
b5da7f49d332ed5d64be1256e14035af74a7efa2, I have to click blindly until I reach
the main menu screen which then gets shown (didn't notice that before). I just
rechecked multiple times. Running Debian 1:7.3+18, kwin 4:3.5.9.dfsg.1-5
(non-compositing!), NVIDIA-Linux-x86-185.18.36, linux-image-686-bigmem 2.6.30-5
here. No winetricks et al, just installed Starscape to a vanilla wine dir. Any
way I can help debugging this?

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #3 from Henri Verbeet   2009-09-11 11:12:11 ---
I probably means it's a pre-existing bug that somehow depends on timing or
memory layout. I'll see if I can fix it, but those are usually harder than
plain regressions.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #4 from Henri Verbeet   2009-09-16 08:37:42 ---
Created an attachment (id=23619)
 --> (http://bugs.winehq.org/attachment.cgi?id=23619)
patch

Does this hack work? This bug could turn out to be a bit problematic to fix.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #5 from M.Kiesel   2009-09-16 16:47:15 ---
Yes, the patch seems to fix the problem/symptom. Thanks a lot! Want to keep
this report until a proper fix has been done (you seem to say that the patch is
not a proper fix)?

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #6 from Henri Verbeet   2009-09-17 05:21:42 ---
(In reply to comment #5)
> Yes, the patch seems to fix the problem/symptom. Thanks a lot! Want to keep
> this report until a proper fix has been done (you seem to say that the patch is
> not a proper fix)?

Yeah, that patch is certainly not something we want in Wine in that form. The
application creates a GL context and makes it active, then creates a D3D
device. After it's done with the D3D device, it expects the GL context to still
be the thread's current GL context.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Ken Sharp   2009-09-17 18:01:06 ---
*** Bug 20078 has been marked as a duplicate of this bug. ***

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #8 from Wylda   2009-09-17 18:33:04 ---
(In reply to comment #4)
> Created an attachment (id=23619)

--> (http://bugs.winehq.org/attachment.cgi?id=23619) [details]
> patch
>
> Does this hack work? This bug could turn out to be a bit problematic to fix.

Quake 3 with punkbuster is also affected by black screen, but when i applied
your patch to 1.1.29, quake 3 began to work :)

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Xavier Vachon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Xavier Vachon   2009-09-27 08:38:00 ---
*** Bug 20176 has been marked as a duplicate of this bug. ***

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail]  2009-10-05 07:34:09 ---
*** Bug 20268 has been marked as a duplicate of this bug. ***

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Jeff Zaroyko   2009-10-05 17:02:17 ---
*** Bug 20271 has been marked as a duplicate of this bug. ***

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Brian Vuyk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #12 from Brian Vuyk   2009-10-06 08:10:22 ---
*** This bug has been confirmed by popular vote. ***

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #13 from Brian Vuyk   2009-10-07 07:46:08 ---
This patch fixed the issue in bug 20271, which is marked as duplicate above.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #14 from Wylda   2009-10-22 04:30:20 ---
Created an attachment (id=24276)
 --> (http://bugs.winehq.org/attachment.cgi?id=24276)
Simcity4's console diff between working and fail to start

Hi Henri, your patch "b5da7f49d332ed5d64be1256e14035af74a7efa2 is first bad
commit" strikes again. This time in Sim City 4 Deluxe.

When i try to run this game under OpenGL mode (wine simcity\ 4.exe -d:opengl)
and high resolution (1920x1200) it won't start. Console diff attached.

Physical screen resolutions:
1920x1200  *** Crash during game start ***
1680x1050  *** WORKS ***
1600x1200  *** WORKS ***
1600x1024  *** WORKS ***
1440x900   *** WORKS ***
1400x1050  *** WORKS ***
1280x960   *** WORKS ***
1280x768   *** WORKS ***
1152x864   *** WORKS ***
1024x768   *** WORKS ***

This affect only OpenGL mode. DirectX mode and Software renderer modes are OK.

So Henri what do you think about statement "fix regression first, than others"?

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #15 from Henri Verbeet   2009-10-22 04:42:01 ---
(In reply to comment #14)
> So Henri what do you think about statement "fix regression first, than others"?

I think it shows you don't understand the problem.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #16 from Wylda   2009-10-22 05:02:48 ---
(In reply to comment #15)
> > So Henri what do you think about statement "fix regression first, than others"?
>
> I think it shows you don't understand the problem.

...and i don't even want to understand. I just want to use resolution
1920x1200. It's simple...

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #17 from Henri Verbeet   2009-10-22 05:31:47 ---
(In reply to comment #16)
> (In reply to comment #15)
> > > So Henri what do you think about statement "fix regression first, than others"?
> >
> > I think it shows you don't understand the problem.
>
> ...and i don't even want to understand. I just want to use resolution
> 1920x1200. It's simple...

Good luck.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #18 from Wylda   2009-10-22 05:35:12 ---
Thank you ;) Anyway try to find another games which were ruined by your work.

Four is not bad, certainly can be better...

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #19 from Henri Verbeet   2009-10-22 05:44:53 ---
(In reply to comment #18)
> Thank you ;) Anyway try to find another games which were ruined by your work.
>
> Four is not bad, certainly can be better...

In order to make sure you don't miss anything, I'd suggest starting at
ed77348a9e6ae81dfd7c95109aac087e595373ff.

(And just for the record, since there are other people affected by this bug
that *did* provide constructive input, I already have an idea of how to fix
this... it'll just take some time.)

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #20 from Wylda   2009-10-22 05:55:07 ---
(In reply to comment #19)
> In order to make sure you don't miss anything, I'd suggest starting at
> ed77348a9e6ae81dfd7c95109aac087e595373ff.

Not sure if i understand. Should i do:

git checkout ed77348a9e6ae81dfd7c95109aac087e595373ff

and test Simcity?
> (And just for the record, since there are other people affected by this bug
> that *did* provide constructive input,

believe me i do (try to do) my best...
> I already have an idea of how to fix this... it'll just take some time.)

Gladly will be the first one who test your patch.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #21 from Xavier Vachon   2009-10-23 16:55:48 ---
With current git (1.1.32), the hack fails to compile.

patching file dlls/wined3d/context.c
Hunk #1 succeeded at 1090 (offset 32 lines).
Hunk #2 succeeded at 1239 (offset 32 lines).
Hunk #3 FAILED at 1275.
Hunk #4 succeeded at 1513 (offset 39 lines).
1 out of 4 hunks FAILED -- saving rejects to file dlls/wined3d/context.c.rej
patching file dlls/wined3d/directx.c
Hunk #1 succeeded at 217 (offset -9 lines).
Hunk #2 succeeded at 238 (offset -9 lines).
Hunk #3 succeeded at 255 (offset -9 lines).
Hunk #4 succeeded at 322 (offset -9 lines).
patching file dlls/wined3d/wined3d_private.h
Hunk #1 succeeded at 1061 (offset -142 lines).

Contents of context.c.rej

***************
*** 1272,1277 ****
          }
          goto out;
      }
      ret->gl_info = &This->adapter->gl_info;
      ret->surface = (IWineD3DSurface *) target;
      ret->current_rt = (IWineD3DSurface *)target;
--- 1275,1282 ----
          }
          goto out;
      }
+     ret->prev_dc = prev_dc;
+     ret->prev_gl_ctx = prev_gl_ctx;
      ret->gl_info = &This->adapter->gl_info;
      ret->surface = (IWineD3DSurface *) target;
      ret->current_rt = (IWineD3DSurface *)target;

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #22 from Henri Verbeet   2009-10-28 10:37:50 ---
Please retry with current git, should be fixed by
c0050b8ec91b60d6d6a646095cc22f9856eafeda and related commits.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #23 from Wylda   2009-10-28 14:22:03 ---
Created an attachment (id=24415)
 --> (http://bugs.winehq.org/attachment.cgi?id=24415)
Sim city 4 deluxe - switch itself to windowed mode and not fully painted

(In reply to comment #22)
> Please retry with current git, should be fixed by
> c0050b8ec91b60d6d6a646095cc22f9856eafeda and related commits.

Hi Henri, i tested current wine (wine-1.1.32-166-g9bd6887) and have good and
bad news.

Good: Quake 3 is fixed :)

Bad: SimCity 4 is not fixed maybe half-fixed. As i said before, in 1.1.32 you
can not start simcity by command "wine simcity\ 4.exe -d:opengl" and regression
test showed commit "b5da7f49d332ed5d64be1256e14035af74a7efa2". Now with current
git, i'm able to run it, but it switch itself to windowed mode and setup really
low resolution. Moreover the resolution, the window is not fully painted.
Attachment says it better.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #24 from Xavier Vachon   2009-10-28 16:00:02 ---
(In reply to comment #22)
> Please retry with current git, should be fixed by
> c0050b8ec91b60d6d6a646095cc22f9856eafeda and related commits.

The main menu of Neverwinter Nights now works.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #25 from M.Kiesel   2009-10-28 18:38:18 ---
Starscape seems fixed now. Thanks a lot!

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #26 from Austin English   2009-10-28 19:30:32 ---
(In reply to comment #25)
> Starscape seems fixed now. Thanks a lot!

Marking fixed.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #27 from Wylda   2009-10-29 00:59:27 ---
(In reply to comment #26)
> Marking fixed.

Hi Austin, you were too quick here. I don't think this is fully fixed. See 
comment #23. Please consider reopen.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #28 from Dmitry Timoshkov   2009-10-29 02:17:58 ---
Not completely fixed yet.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #29 from Henri Verbeet   2009-10-29 04:48:22 ---
(In reply to comment #23)
> Bad: SimCity 4 is not fixed maybe half-fixed. As i said before, in 1.1.32 you
> can not start simcity by command "wine simcity\ 4.exe -d:opengl" and regression
> test showed commit "b5da7f49d332ed5d64be1256e14035af74a7efa2". Now with current
> git, i'm able to run it, but it switch itself to windowed mode and setup really
> low resolution. Moreover the resolution, the window is not fully painted.
> Attachment says it better.

Did the hack originally posted here
(http://bugs.winehq.org/attachment.cgi?id=23619) work for SimCity 4?

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #30 from Wylda   2009-10-30 05:50:26 ---
(In reply to comment #29)
> Did the hack originally posted here
> (http://bugs.winehq.org/attachment.cgi?id=23619) work for SimCity 4?

Hi Henri, good point. This is a mixture of two things, sorry :( This patch
really fixed originally reported problem for Sim city, i.e. starting @1920x1200
was fixed and is fixed in current git.

Sorry again and thank you for your work. This bug should be closed now.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #31 from Austin English   2009-10-30 14:13:21 ---
(In reply to comment #30)
> (In reply to comment #29)
> > Did the hack originally posted here
> > (http://bugs.winehq.org/attachment.cgi?id=23619) work for SimCity 4?
>
> Hi Henri, good point. This is a mixture of two things, sorry :( This patch
> really fixed originally reported problem for Sim city, i.e. starting @1920x1200
> was fixed and is fixed in current git.
>
> Sorry again and thank you for your work. This bug should be closed now.

Fixed then.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #32 from Brian Vuyk   2009-11-02 11:54:07 ---
As reported in #13 above, the hack in #4 fixed the problem in WWII Online:
Battleground Europe. However, the issue is still present with the latest HEAD -
that is, c0050b8ec91b60d6d6a646095cc22f9856eafeda and the related commits
didn't fix it for this game.

I would be happy to provide whatever debug output I can to help get this fixed.

For the exact report of how this is broken in WWIIOL, see
http://bugs.winehq.org/show_bug.cgi?id=20271, which was marked as a duplicate
of this bug.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #33 from Henri Verbeet   2009-11-04 03:58:36 ---
(In reply to comment #32)
> As reported in #13 above, the hack in #4 fixed the problem in WWII Online:
> Battleground Europe. However, the issue is still present with the latest HEAD -
> that is, c0050b8ec91b60d6d6a646095cc22f9856eafeda and the related commits
> didn't fix it for this game.
>
> I would be happy to provide whatever debug output I can to help get this fixed.

A +d3d,+wgl log would be useful. Note that I probably won't have time to look
at this during the next couple of days though.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #34 from Alexandre Julliard   2009-11-13 12:44:19 ---
Closing bugs fixed in 1.1.33.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #35 from Marcel de Vries   2010-04-21 08:49:28 ---
Created an attachment (id=27492)
 --> (http://bugs.winehq.org/attachment.cgi?id=27492)
Log of +d3d,+wgl

Hi,

This bug (still) isn't fixed with WWII Online.

Here is the output requested in comment #33. This is with
c0050b8ec91b60d6d6a646095cc22f9856eafeda. The bugs exists from wherever this
started until current git.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

Marcel de Vries  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #36 from Jeff Zaroyko   2010-04-21 09:03:29 ---
(In reply to comment #35)
> Created an attachment (id=27492)

--> (http://bugs.winehq.org/attachment.cgi?id=27492) [details]
> Log of +d3d,+wgl
>
> Hi,
>
> This bug (still) isn't fixed with WWII Online.
>
> Here is the output requested in comment #33. This is with
> c0050b8ec91b60d6d6a646095cc22f9856eafeda. The bugs exists from wherever this
> started until current git.

Please test in the release it was reported to be fixed in. 1.1.33 to confirm
this is the same bug.  If it works with 1.1.33 file a new one.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #37 from Marcel de Vries   2010-04-21 09:16:24 ---
(In reply to comment #36)
> Please test in the release it was reported to be fixed in. 1.1.33 to confirm
> this is the same bug.  If it works with 1.1.33 file a new one.

Just tested it with 1.1.33, the bug still exists.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #38 from Jeff Zaroyko   2010-04-21 09:20:49 ---
(In reply to comment #37)
> (In reply to comment #36)
> > Please test in the release it was reported to be fixed in. 1.1.33 to confirm
> > this is the same bug.  If it works with 1.1.33 file a new one.
>
> Just tested it with 1.1.33, the bug still exists.

As this bug fixed Starscape which is what it is titled, can you file a new bug
for your application?  Better than lumping them all together.

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #39 from Marcel de Vries   2010-04-21 09:23:49 ---
(In reply to comment #38)
> (In reply to comment #37)
> As this bug fixed Starscape which is what it is titled, can you file a new bug
> for your application?  Better than lumping them all together.

What about reopening http://bugs.winehq.org/show_bug.cgi?id=20271 ?

[Bug 19948] Starscape OpenGL mode - screen stays black

http://bugs.winehq.org/show_bug.cgi?id=19948

--- Comment #40 from Jeff Zaroyko   2010-04-21 09:26:25 ---
(In reply to comment #39)
> (In reply to comment #38)
> > (In reply to comment #37)
> > As this bug fixed Starscape which is what it is titled, can you file a new bug
> > for your application?  Better than lumping them all together.
>
> What about reopening http://bugs.winehq.org/show_bug.cgi?id=20271 ?

Well spotted, thanks.