[Bug 28229] New: http://source.winehq.org/patches/data/foo doesn't have proper character set header

http://bugs.winehq.org/show_bug.cgi?id=28229

Summary: http://source.winehq.org/patches/data/foo doesn't have
                    proper character set header
           Product: WineHQ.org
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: www-unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Patches with non-ascii characters in them, e.g.
   http://source.winehq.org/patches/data/78111
do not render properly in web browsers.
Let's see what http headers are set:

$ wget -S http://source.winehq.org/patches/data/78111
HTTP request sent, awaiting response... 
  HTTP/1.1 200 OK
  Date: Mon, 29 Aug 2011 21:53:21 GMT
  Server: Apache/2.2.9 (Debian) mod_ssl/2.2.9 OpenSSL/0.9.8g mod_wsgi/2.5
Python/2.5.2
  Last-Modified: Mon, 29 Aug 2011 21:50:01 GMT
  ETag: "1509746-f335-4ababe07eb440"
  Accept-Ranges: bytes
  Content-Length: 62261
  Keep-Alive: timeout=5
  Connection: Keep-Alive
  Content-Type: text/plain
Length: 62261 (61K) [text/plain]

text/plain doesn't give much idea what character set is in use.

$ hexdump 78111 -C | head
00000000  46 72 6f 6d 3a 20 41 6e  64 72 c3 a9 20 48 65 6e  |From: Andr.. Hen|

http://www.utf8-chartable.de/ says that 'c3 a9' is é, so the page is
probably utf-8, and following http://www.w3.org/International/O-HTTP-charset
the page should probably be served with
   Content-Type: text/plain; charset=utf-8
rather than
   Content-Type: text/plain

(although until the entire wine tree is in utf-8, it's kind of hard to say
whether patches can actually be represented properly in utf-8.)

[Bug 28229] http://source.winehq.org/patches/data/foo doesn't have proper character set header

http://bugs.winehq.org/show_bug.cgi?id=28229

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source
                 CC|                            |[e-mail]

--- Comment #1 from Ken Sharp  2013-07-13 17:52:01 CDT ---
Still true.

[Bug 28229] http://source.winehq.org/patches/data/foo doesn' t have proper character set header

https://bugs.winehq.org/show_bug.cgi?id=28229

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #2 from Alex Henrie  ---
All text files in the Wine codebase are now in UTF-8. I'm pretty sure that the
server admin just has to add this line to httpd.conf:

AddDefaultCharset UTF-8

Jeremy, do you have root access to the source.winehq.org server?

[Bug 28229] http://source.winehq.org/patches/data/foo doesn' t have proper character set header

https://bugs.winehq.org/show_bug.cgi?id=28229

Jeremy Newman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Jeremy Newman  ---
Done.

[Bug 28229] http://source.winehq.org/patches/data/foo doesn' t have proper character set header

https://bugs.winehq.org/show_bug.cgi?id=28229

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Rosanne DiMesio  ---
Closing fixed website bug.