[Bug 16143] New: msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Summary: msxml1: Can't set an attribute to Null
           Product: Wine
           Version: 1.1.8
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

While assigning a XML node attribute with "Null" an exception (OLE-Error
80004001) occurs.

PS
I'm still using an old library for XML - I think it's using MSXML1

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #1 from Alistair Leslie-Hughes   2008-11-21 03:04:51 ---
Can you supply some sample code to show the issue?

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #2 from Tahtu   2008-11-21 03:12:45 ---
Under Delphi I'm using this code:

IXMLNode.Attributes['test'] := Null;

Delphi realize this as:

IXMLNode.SetAttribute('test', Null);

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #3 from Austin English   2008-11-21 07:46:03 ---
Please attach terminal output. Do you have a compiled binary?

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #4 from Tahtu   2008-11-21 07:59:12 ---
Created an attachment (id=17388)
 --> (http://bugs.winehq.org/attachment.cgi?id=17388)
Terminal log

Currently I have the complete application only (4 MB). To process this bug you
have to handle some steps of it.

Should I upload it with a procedure description?

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #5 from Austin English   2008-11-21 08:29:13 ---
(In reply to comment #4)
> Created an attachment (id=17388)

--> (http://bugs.winehq.org/attachment.cgi?id=17388) [details]
> Terminal log
>
> Currently I have the complete application only (4 MB). To process this bug you
> have to handle some steps of it.
>
> Should I upload it with a procedure description?

It would be best if you could strip it down to a simple program that shows the
problem, and nothing more.

If not, upload it somewhere (not here, bugzilla only accepts up to 1 MB). Don't
upload it if you don't own the copyright/have permission.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #6 from Tahtu   2008-11-21 08:35:10 ---
http://www.mysqlfront.de/MySQL-Front.exe

Please add a new session by setting a name on the "Basic" tab and the server on
the "Connection" tab - maybe "localhost".

After that click to the [Ok] button and close the program. While closing the
application the bug occurrs.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Keywords|                            |download

--- Comment #7 from Austin English   2008-11-21 16:53:11 ---
=>1 0x7ef85b42 __regs_RtlRaiseException+0x5a() in ntdll (0x0032f758)
  2 0x7efd1c1b __wine_call_from_32_regs+0xc3() in ntdll (0x0032fabc)
  3 0x7ef85b52 RtlRaiseException+0x6() in ntdll (0x0032fb34)
  4 0x005068bf in mysql-front (+0x1068bf) (0x0032fb5c)
  5 0x005bc378 in mysql-front (+0x1bc378) (0x0032fbc4)
  6 0x004077b3 in mysql-front (+0x77b3) (0x0032fc1c)
  7 0x005f337e in mysql-front (+0x1f337e) (0x0032fd90)
  8 0x005f5dc4 in mysql-front (+0x1f5dc4) (0x0032fe40)
  9 0x005f8be1 in mysql-front (+0x1f8be1) (0x0032fe98)
  10 0x005f6a1a in mysql-front (+0x1f6a1a) (0x0032fef8)
  11 0x7ee1e649 start_process+0xe4() in kernel32 (0x0032ffe8)
  12 0xb7e9a9db wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000)

Confirming.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #8 from Alistair Leslie-Hughes   2008-11-21 18:31:50 ---
I have submitted a patch to fix this.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #9 from Lei Zhang   2008-11-26 13:01:29 ---
Which patch? Has it been committed?

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Alistair Leslie-Hughes   2008-11-26 13:25:33 ---
Currently they haven't been accepted.

http://www.winehq.org/pipermail/wine-patches/2008-November/064975.html
http://www.winehq.org/pipermail/wine-patches/2008-November/064974.html

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Tahtu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.8                       |1.1.10

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.10                      |1.1.8

--- Comment #11 from Vitaliy Margolen   2008-12-06 12:40:16 ---
Please don't change original reported Wine version.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Tahtu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.8                       |1.1.10

--- Comment #12 from Tahtu   2008-12-06 12:42:52 ---
If you fix this bug I would not have a reason to change it. ;-)

Since the bug is still presten there is a reason to change it.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.10                      |1.1.8

--- Comment #13 from Vitaliy Margolen   2008-12-06 13:10:31 ---
DO NOT change original reported Wine version!!!

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Tahtu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.8                       |1.1.10

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.10                      |1.1.8

--- Comment #14 from James Hawkins   2008-12-06 13:14:24 ---
Tahtu, stop changing the version.  As a part of *our* development process,
which means fixing this bug, the version field is the earliest known broken
version.  If a new release is still broken, a comment stating that is all that
is needed.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #15 from Vitaliy Margolen   2008-12-06 13:15:20 ---
If you do not play by rules do not bother reporting bugs to bugzilla in the
future.

Closing invalid.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Vitaliy Margolen   2008-12-06 13:15:26 ---
Closing

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Tahtu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.8                       |1.1.10

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Tahtu  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|INVALID                     |

--- Comment #17 from Tahtu   2008-12-06 13:18:03 ---
Bug is still present.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.10                      |1.1.8

--- Comment #18 from Lei Zhang   2008-12-07 03:07:06 ---
Stop changing the original reported version. Please behave. Causing mischief
just wastes everyone's time.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #19 from Alistair Leslie-Hughes   2008-12-07 03:08:44 ---
Can you please attach a log of 
WINEDEBUG=+msxml wine <program>

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Rich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Rich   2009-01-09 22:54:18 ---
Link is now broken.

Download can now be found at
http://mysqlfront.sprintserve.net/MySQL-Front_Setup.exe - I don't believe I can
add a URL to this bug.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #21 from Rich   2009-01-09 22:57:10 ---
Created an attachment (id=18605)
 --> (http://bugs.winehq.org/attachment.cgi?id=18605)
WINEDEBUG=+msxml output

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #22 from Rich   2009-01-09 22:58:06 ---
Bug tested and reproduced on wine-1.1.12-395-gf9ed74a

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://mysqlfront.sprintserv
                   |                            |e.net/MySQL-Front_Setup.exe

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #23 from Nikolay Sivov   2010-01-10 17:47:51 ---
(In reply to comment #20)
> http://mysqlfront.sprintserve.net/MySQL-Front_Setup.exe

I can't reproduce this crash with 1.1.36. Let's wait for another confirmation.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #24 from Andrew Nguyen   2010-01-11 04:58:02 ---
This isn't fixed in wine-1.1.36 with my copy of MySQL-Front installed from
MySQL-Front_Setup.exe with sha1sum e9ec8b7afa0205bd17a8416582404721f81b2fe9. I
can upload the installer somewhere if necessary.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #25 from Nikolay Sivov   2010-01-11 05:00:54 ---
(In reply to comment #24)
> This isn't fixed in wine-1.1.36 with my copy of MySQL-Front installed from
> MySQL-Front_Setup.exe with sha1sum e9ec8b7afa0205bd17a8416582404721f81b2fe9. I
> can upload the installer somewhere if necessary.

Ok. I tried another one. Please attach new +msxml for that.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #26 from Andrew Nguyen   2010-01-11 05:12:37 ---
Created an attachment (id=25663)
 --> (http://bugs.winehq.org/attachment.cgi?id=25663)
MySQL-Front +msxml trace (lzma compressed)

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #27 from Nikolay Sivov   2010-01-16 14:36:38 ---
Created an attachment (id=25758)
 --> (http://bugs.winehq.org/attachment.cgi?id=25758)
IXMLDOMElement::removeAttribute() implementation

Andrew, please try this patch.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25758|0                           |1
        is obsolete|                            |

--- Comment #28 from Nikolay Sivov   2010-01-16 15:45:38 ---
Created an attachment (id=25759)
 --> (http://bugs.winehq.org/attachment.cgi?id=25759)
IXMLDOMElement::removeAttribute() implementation (try2)

Try this instead. It's based on DOMNode.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #29 from Andrew Nguyen   2010-01-16 17:16:56 ---
Thanks, that patch does indeed solve the crash.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

--- Comment #30 from Nikolay Sivov   2010-01-16 17:37:50 ---
(In reply to comment #29)
> Thanks, that patch does indeed solve the crash.

The second one "try2"? If so I'll submit it next week.

P.S. It looks like this application just wants a successful return code.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

--- Comment #31 from Andrew Nguyen   2010-01-16 17:42:10 ---
Yes, I was using the try2 patch.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #32 from Nikolay Sivov   2010-01-18 16:14:42 ---
Patch sent:

http://www.winehq.org/pipermail/wine-patches/2010-January/083864.html

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #33 from Nikolay Sivov   2010-01-20 16:54:30 ---
Should be fixed by commit 7724b053e24d974b8a0005b5cb921e18cb30541c.

Reopen if still a problem.

[Bug 16143] msxml1: Can't set an attribute to Null

http://bugs.winehq.org/show_bug.cgi?id=16143

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #34 from Alexandre Julliard   2010-01-22 11:01:55 ---
Closing bugs fixed in 1.1.37.