[Bug 15937] New: [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

Summary: [PATCH] Pens of width = 1 scale on Windows, don't on
                    Wine
           Product: Wine
           Version: CVS/GIT
          Platform: All
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=17115)
 --> (http://bugs.winehq.org/attachment.cgi?id=17115)
Possible patch (tested)

Basically it's the same story as this one:
http://www.winehq.org/pipermail/wine-patches/2006-February/024133.html
http://source.winehq.org/git/?p=wine.git;a=commit;h=75e8166d7487461ead74e856...

but Windows behaves like there's "greater or equal" check, at least with Protel
99 SE (again :-). Please see the attachments and you'll see what I'm talking
about. Those (poly)lines are draw with a pen created by CreatePenIndirect().
It's easy to check there that pen->lopnWidth.x == 1.

Dmitry, I'm CCing you because you're already familiar with the problem and had
that app running lately.

[Bug 15937] [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

--- Comment #1 from Krzysztof Kotlenga   2008-11-06 13:13:18 ---
Created an attachment (id=17116)
 --> (http://bugs.winehq.org/attachment.cgi?id=17116)
Wine screenshot - current

[Bug 15937] [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

--- Comment #2 from Krzysztof Kotlenga   2008-11-06 13:14:10 ---
Created an attachment (id=17117)
 --> (http://bugs.winehq.org/attachment.cgi?id=17117)
Wine screenshot - patched

[Bug 15937] [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

--- Comment #3 from Krzysztof Kotlenga   2008-11-06 13:16:39 ---
Created an attachment (id=17118)
 --> (http://bugs.winehq.org/attachment.cgi?id=17118)
Windows screenshot

(BTW, Another problem with vertically rotated text is visible)

[Bug 15937] [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
           Platform|All                         |Other
            Version|CVS/GIT                     |1.1.7

--- Comment #4 from Dmitry Timoshkov   2008-11-06 20:20:41 ---
Please send the patch to wine-patches omitting the /* XXX Is below correct */
comment.

[Bug 15937] [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Dmitry Timoshkov   2008-11-07 09:50:55 ---
The patch has been committed.

[Bug 15937] [PATCH] Pens of width = 1 scale on Windows, don't on Wine

http://bugs.winehq.org/show_bug.cgi?id=15937

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2008-11-07 10:47:12 ---
Closing bugs fixed in 1.1.8.