[Bug 43420] New: UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

Bug ID: 43420
           Summary: UnrealEd 3: Cannot fully build map since Wine 2.13
           Product: Wine
           Version: 2.13
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Using Wine 2.12 I can load UnrealEd 3, open or create a new map, and
successfully run "Build all" from the Build menu. However, with Wine 2.13 this
now fails with the following outputted from the app:

```
Build UT2004_Build_[2005-11-23_16.22]

OS: Windows NT 6.1 (Build: 7601)
CPU: GenuineIntel PentiumPro-class processor @ 2893 MHz with 2047MB RAM
Video: Intel(R) HD Graphics 4000 (4352)

General protection fault!

History: UD3DRenderDevice::Unlock <- UViewport::Unlock <-
UWindowsViewport::Unlock <- UUnrealEdEngine::Draw <-
(Cam=U2Viewport0,Flags=850036425 <- UWindowsViewport::Repaint <-
UEditorEngine::RedrawLevel <- UEditorEngine::Exec_Light <- UEditorEngine::Exec
<- (LIGHT APPLY) <- UUnrealEdEngine::Exec <- WPageOptions::BuildLighting <-
WPageOptions::OnBuildClick <- WEditorFrame::OnCommand <- WWindow::WndProc <-
WWindow::StaticProc <- MessagePump <- MainLoop
```

It seems to be specifically caused by the lighting build phases as I can run
any of the other build options just fine but both "Build lighting only" and
"Build changed lighting only" crash the app with the message above.

I'm happy to provide wine debug information if someone can let me know which
class/channel is likely to be most useful as "all" produces far to large an
output.

Note this is UnrealEd.exe provided by UT2004 Editor's Choice Editor from GOG.

[Bug 43420] UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

MagicMyth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |548382e634c7c4df5fe0ae433cd
                   |                            |fad916f7e5784

--- Comment #1 from MagicMyth  ---
I've bisected the bad commit:

548382e634c7c4df5fe0ae433cdfad916f7e5784 is the first bad commit
commit 548382e634c7c4df5fe0ae433cdfad916f7e5784
Author: Alexandre Julliard 
Date:   Tue Jul 18 10:03:51 2017 +0200

wined3d: Make sure we are still using the correct window before setting
pixel format.

Signed-off-by: Henri Verbeet 
    Signed-off-by: Alexandre Julliard

:040000 040000 7a03e778f6105160d10274bcc4ebd13ff01d9680
1b7f53431ecd6c4869a7bcf580cbf946d90e0475 M      dlls

[Bug 43420] UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

--- Comment #2 from Henri Verbeet  ---
(In reply to MagicMyth from comment #1)
> I've bisected the bad commit:
>
> 548382e634c7c4df5fe0ae433cdfad916f7e5784 is the first bad commit
> commit 548382e634c7c4df5fe0ae433cdfad916f7e5784
> Author: Alexandre Julliard 
> Date:   Tue Jul 18 10:03:51 2017 +0200
> wined3d: Make sure we are still using the correct window before setting
>
> pixel format.

Does https://source.winehq.org/patches/data/136159 help?

[Bug 43420] UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

--- Comment #3 from MagicMyth  ---
Brilliant @Henri Verbeet! That patch did the trick.

[Bug 43420] UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

--- Comment #4 from Henri Verbeet  ---
Should be fixed by commits 6a5c37254194aaed783b219957e6f204b2d674de and
3441ba9e039521d38be0d8bdad8eca55393e3a0b.

[Bug 43420] UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

MagicMyth  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |3441ba9e039521d38be0d8bdad8
                   |                            |eca55393e3a0b
         Resolution|---                         |FIXED

--- Comment #5 from MagicMyth  ---
I can confirm the issue is indeed resolved. Thanks very much for the prompt
fix.

That seems to leave just one more issue with UnrealEd 3 before its fully
usable. If you need someone to test code to figure out the issue with bug 37180
just give me a shout.

Thanks again!

[Bug 43420] UnrealEd 3: Cannot fully build map since Wine 2.13

https://bugs.winehq.org/show_bug.cgi?id=43420

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 2.14.