[Bug 17854] New: build broken in rpcrt4 on OpenSolaris

http://bugs.winehq.org/show_bug.cgi?id=17854

Summary: build broken in rpcrt4 on OpenSolaris
           Product: Wine
           Version: 1.1.17
          Platform: PC
               URL: http://source.winehq.org/git/wine.git/?a=commitdiff;h=5f
                    6ae94ad0163341c2cd79a89f29b2187367b5ba
        OS/Version: Solaris
            Status: NEW
          Keywords: download, regression, source
          Severity: critical
          Priority: P2
         Component: rpc
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc
--nostdinc -I. -I. -I../../include -I../../include  -D__WINESRC__ -D_RPCRT4_
-DCOM_NO_WINDOWS_H -DMSWMSG  -foversion.res version.rc
../../tools/winegcc/winegcc  -B../../tools/winebuild -shared ./rpcrt4.spec   
cproxy.o cpsf.o cstub.o ndr_clientserver.o ndr_contexthandle.o ndr_es.o
ndr_fullpointer.o ndr_marshall.o ndr_ole.o ndr_stubless.o rpc_assoc.o
rpc_async.o rpc_binding.o rpc_epmap.o rpc_message.o rpc_server.o
rpc_transport.o rpcrt4_main.o   epm_c.o  version.res  -o rpcrt4.dll.so
-lsecur32 -luser32 -luuid -ladvapi32 -lkernel32 -lntdll -Wb,-dsecur32
-Wb,-duser32 ../../libs/port/libwine_port.a   -lsocket -lnsl 
Undefined                       first referenced
 symbol                             in file
InternetReadFileExA                 rpc_transport.o
InternetQueryDataAvailable          rpc_transport.o
HttpQueryInfoW                      rpc_transport.o
InternetCloseHandle                 rpc_transport.o
InternetSetStatusCallbackW          rpc_transport.o
InternetReadFile                    rpc_transport.o
HttpSendRequestW                    rpc_transport.o
rpcrt4_ip_tcp_get_top_of_tower      rpc_transport.o
InternetWriteFile                   rpc_transport.o
HttpOpenRequestW                    rpc_transport.o
InternetConnectW                    rpc_transport.o
HttpSendRequestExW                  rpc_transport.o
InternetOpenW                       rpc_transport.o
rpcrt4_ip_tcp_parse_top_of_tower    rpc_transport.o
ld: fatal: Symbol referencing errors. No output written to rpcrt4.dll.so
collect2: ld returned 1 exit status
winegcc: gcc failed
make: *** [rpcrt4.dll.so] Error 2

Probably related, these warnings appeared after this patch:
gcc -c -I. -I. -I../../include -I../../include  -D__WINESRC__ -D_RPCRT4_
-DCOM_NO_WINDOWS_H -DMSWMSG -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
-Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith  -g -O2  -o
rpc_transport.o rpc_transport.c
rpc_transport.c: In function `rpcrt4_ncacn_ip_tcp_parse_top_of_tower':
rpc_transport.c:1424: warning: implicit declaration of function
`rpcrt4_ip_tcp_parse_top_of_tower'
rpc_transport.c: In function `rpcrt4_ncacn_http_get_top_of_tower':
rpc_transport.c:2348: warning: implicit declaration of function
`rpcrt4_ip_tcp_get_top_of_tower'
rpc_transport.c: At top level:
rpc_transport.c:1423: warning: 'rpcrt4_ncacn_ip_tcp_parse_top_of_tower' defined
but not used

Reverting the patch allows wine to build/run fine.

[Bug 17854] build broken in rpcrt4 on OpenSolaris

http://bugs.winehq.org/show_bug.cgi?id=17854

--- Comment #1 from Rob Shearman   2009-03-26 08:38:50 ---
I'm not sure why you're seeing undefined symbol errors for the wininet
functions when wininet is in DELAYIMPORTS in dlls/rpcrt4/Makefiles.in, but I
see the rpcrt4_ip_tcp_get_top_of_tower/rpcrt4_ip_tcp_parse_top_of_tower issues
when I undefine HAVE_SOCKETPAIR in rpc_transport.c and I've sent a patch for
this:
http://www.winehq.org/pipermail/wine-patches/2009-March/071148.html

[Bug 17854] build broken in rpcrt4 on OpenSolaris

http://bugs.winehq.org/show_bug.cgi?id=17854

--- Comment #2 from Rob Shearman   2009-03-26 08:43:25 ---
Note that I believe socketpair should be available on Solaris/OpenSolaris, so
it may be worth checking why socketpair is not being detected by configure in
this case.

[Bug 17854] build broken in rpcrt4 on OpenSolaris

http://bugs.winehq.org/show_bug.cgi?id=17854

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English   2009-03-26 23:13:02 ---
(In reply to comment #2)
> Note that I believe socketpair should be available on Solaris/OpenSolaris, so
> it may be worth checking why socketpair is not being detected by configure in
> this case.

Looks like AJ committed a fix:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=98bec05ed7dbecf6d869f7...

That, along with his and your other fixes allow it to compile fine in git.
Looks like it's passing all those tests as well, same as Linux :-).

[Bug 17854] build broken in rpcrt4 on OpenSolaris

http://bugs.winehq.org/show_bug.cgi?id=17854

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2009-03-27 13:57:32 ---
Closing bugs fixed in 1.1.18.