[Bug 45266] New: SHFileOperation FO_MOVE fails to move files to target directory

https://bugs.winehq.org/show_bug.cgi?id=45266

Bug ID: 45266
           Summary: SHFileOperation FO_MOVE fails to move files to target
                    directory
           Product: Wine
           Version: 2.0
          Hardware: x86
                OS: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]

When moving multiple files to one target directory, the SHFileOperation is
aborted with ERROR_CANCELLED.

I think it's caused by an erroneous check at
https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/shell32/shlfileop.c#l...

if (!(lpFileOp->fFlags & FOF_MULTIDESTFILES) &&
    !flFrom->bAnyDirectories &&
    flFrom->dwNumFiles > flTo->dwNumFiles)
{
    return ERROR_CANCELLED;
}

If the target is one single directory, FOF_MULTIDESTFILES is not set.
flFrom->bAnyDirectories is false, since no directories are moved. And
flFrom->dwNumFiles > flTo->dwNumFiles since we move multiple files to one
target directory.

I'm not sure what's the reasoning behind !flFrom->bAnyDirectories anyway. Maybe
it's just a typo and should read !flTo->bAnyDirectories

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

https://bugs.winehq.org/show_bug.cgi?id=45266

Florian Heidenreich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

https://bugs.winehq.org/show_bug.cgi?id=45266

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

https://bugs.winehq.org/show_bug.cgi?id=45266

--- Comment #1 from Florian Heidenreich  ---
The issue can be reproduced using Mp3tag v2.88a from
https://download.mp3tag.de/mp3tagv288asetup.exe

1.) Load a directory with some MP3 files via Ctrl+D
2.) Select multiple files
3.) Choose 'Edit > Move...'

As a result, the files are not moved due to the issue described above.

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=45266

Ziqing Hui  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=45266

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |https://download.mp3tag.de/
                   |                            |mp3tagv288asetup.exe

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=45266

--- Comment #2 from Ziqing Hui  ---
I'm working on rewritting move_files().

[Bug 45266] SHFileOperation FO_MOVE fails to move files to target directory

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=45266

--- Comment #3 from Ziqing Hui  ---
Submitted MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/8209