[Bug 17564] New: 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Summary: 7-zip file manager interface selection problem
           Product: Wine
           Version: 1.1.15
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

In the 7-Zip File manager if you try to select objects with shift + arrows or
mouse the objects count is not updated!

Another (minor) problem is that with ctrl + arrows should only mantain the
currently highlighted items and change the selected item (without choosing it)

7-zip 4.64
Wine 1.1.5 - Ubuntu 8.04

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #1 from Gabriele Moabiti   2009-03-01 04:54:47 ---
Try also to select an item then press the dx button of mouse .. the object
count is increased and never decreased.
There is something strange with this listview.. I don't think is trivial but it
should be at least minor

NOTE: It's not cosmetics-only because the operations  are also effected

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #2 from Nikolay Sivov   2009-03-07 11:23:11 ---
Created an attachment (id=19830)
 --> (http://bugs.winehq.org/attachment.cgi?id=19830)
fix for Ctrl and Space selection

(In reply to comment #0)
> Another (minor) problem is that with ctrl + arrows should only mantain the
> currently highlighted items and change the selected item (without choosing it)

Hi, this patch fixes this issue and another one about selection with space key.
Test with it to confirm.
I'll fix selection with shift soon I hope.

(In reply to comment #1)
> Try also to select an item then press the dx button of mouse .. the object
> count is increased and never decreased.

I can't reproduce this. Which mouse button do you mean?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #3 from Gabriele Moabiti   2009-03-07 14:52:48 ---
(In reply to comment #2)
> fix for Ctrl and Space selection
>
> Hi, this patch fixes this issue and another one about selection with space key.
> Test with it to confirm.

Tested is ok!
> I'll fix selection with shift soon I hope.

I hope too
> > Try also to select an item then press the dx button of mouse .. the object
> > count is increased and never decreased.
>
> I can't reproduce this. Which mouse button do you mean?

sorry [my engRish], the right button
Try to select (with ctrl for example) some items then click the right button ->
for the status bar the elements continue to be selected

Thank you

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #4 from Nikolay Sivov   2009-03-08 06:24:42 ---
Created an attachment (id=19835)
 --> (http://bugs.winehq.org/attachment.cgi?id=19835)
fix for Shift selection

Apply this on top of previous.

I still can't reproduce a problem with right mouse button selection.
Maybe the reason's I'm using 4.65 for test.
Test please 4.64 and 4.65 with these patches and report back. If it's 4.64
specific I think it can be easily fixed (source are available).

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #5 from Gabriele Moabiti   2009-03-08 14:10:59 ---
(In reply to comment #4)
> fix for Shift selection

Shift patch test: OK!
> I still can't reproduce a problem with right mouse button selection.
> Maybe the reason's I'm using 4.65 for test.
> Test please 4.64 and 4.65 with these patches and report back. If it's 4.64
> specific I think it can be easily fixed (source are available).

Same result for 4.64 and 4.65.

I think I was a bit cryptic in the bug description...
Steps to reproduce the problem:

1) Select one or more items
2) Click the right mouse button over a selected item on list (maybe this is a
the condition that bring to the problem) and the popup menu will appear.

The selection now will desappear while the objects remain selected.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #6 from Nikolay Sivov   2009-03-08 14:23:45 ---
(In reply to comment #5)
> Same result for 4.64 and 4.65.
>
> I think I was a bit cryptic in the bug description...
> Steps to reproduce the problem:
> - Select one or more items
> - Click the right mouse button over a selected item on list (maybe this is a
>
> the condition that bring to the problem) and the popup menu will appear.
>
> The selection now will desappear while the objects remain selected.

Are you really using 1.1.15 tree or are updated to current? There are some
changes between 1.1.15 and 1.1.16.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #7 from Gabriele Moabiti   2009-03-08 15:02:37 ---
> Are you really using 1.1.15 tree or are updated to current? There are some
> changes between 1.1.15 and 1.1.16.

I had installed the 1.1.15 (binary) before the 1.1.16 (from source, I patched
always this one of course)
If I open a terminal wine --version says 1.1.16

I have launched  the program from command line (4.64 and 4.65) and YOU ARE
RIGHT, the problem disappear but If I launch it from gnome menu the problem
exists... strange..

the command on gnome menu is
env WINEPREFIX="/home/gabriele/.wine" wine "C:\Program
Files\7-Zip4.65\7zFM.exe" 
and I think it will launch the 1.1.16 because the other problems doesn't appear

If I start from gnome menu the mouse problem still happen... ???strange???

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #8 from Nikolay Sivov   2009-03-08 15:23:33 ---
(In reply to comment #7)
> > Are you really using 1.1.15 tree or are updated to current? There are some
> > changes between 1.1.15 and 1.1.16.
>
> I had installed the 1.1.15 (binary) before the 1.1.16 (from source, I patched
> always this one of course)
> If I open a terminal wine --version says 1.1.16

I see, so it's maybe some mess in versions (and you aren't using the latest
sources).
To be sure:
- remove all wine packages installed (with your package manager or how did you
install them...)
- setup git and get latest source tree (with patches on top of it)
- build, then install

And only after that try app removing .wine directory before that.

P.S. trying to find this right button problem I found another that exists in
today git (with my patches too):

refreshing list with ctlr-R with some selection clears a selection (as it
should) but doesn't update count (read doesn't notify). I'm working on it now.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #9 from Gabriele Moabiti   2009-03-08 15:50:30 ---

Cleaned and re-installed... same problem only if I launch it from nautilus or
gnome menu(?). could you try to execute from nautilus instead of command line?
> P.S. trying to find this right button problem I found another that exists in
> today git (with my patches too):
>
> refreshing list with ctlr-R with some selection clears a selection (as it
> should) but doesn't update count (read doesn't notify). I'm working on it now.

It seems there was many problems on selection!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #10 from Gabriele Moabiti   2009-03-08 16:42:04 ---
NOTE:

I have created launch.sh script in 7Zip intall directory

---- launch.sh
#!/bin/sh
/usr/local/bin/wine 7zFM.exe
--------------

If I double Click to script with nautilus and I choose run in a terminal it
works right with right mouse button while If I choose display it doesn't
work... the only difference for me is the first one has an open terminal window

Maybe It's my mistake but I can't figure why!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #11 from Austin English   2009-03-08 19:49:41 ---
(In reply to comment #10)
> NOTE:
>
> I have created launch.sh script in 7Zip intall directory
>
> ---- launch.sh
> #!/bin/sh
> /usr/local/bin/wine 7zFM.exe
>
> If I double Click to script with nautilus and I choose run in a terminal it
> works right with right mouse button while If I choose display it doesn't
> work... the only difference for me is the first one has an open terminal window
>
> Maybe It's my mistake but I can't figure why!

'Display' doesn't run the script, only displays it.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #12 from Gabriele Moabiti   2009-03-09 04:50:08 ---
> 'Display' doesn't run the script, only displays it.

ehm... 'run'

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #13 from Austin English   2009-03-09 12:48:31 ---
(In reply to comment #12)
> > 'Display' doesn't run the script, only displays it.
>
> ehm... 'run'

I don't ever use that feature, but perhaps you need to mark it as executable
first?

Regardless, that's something you should ask on the Ubuntu forums, it's not
related to this bug.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #14 from Gabriele Moabiti   2009-03-09 13:14:46 ---
> I don't ever use that feature, but perhaps you need to mark it as executable
> first?
> Regardless, that's something you should ask on the Ubuntu forums, it's not
> related to this bug.

the eXecutable flag is set but you 're right, it is off topic ... it is not a
wine bug.
I'll do some test to understand what really happen.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #15 from Nikolay Sivov   2009-03-13 09:31:03 ---
Hi again, Gabriele.
Two patches are in repo now.
http://source.winehq.org/git/wine.git?a=commit;h=b7f0dd64da73a07ec1096a48a78...
http://source.winehq.org/git/wine.git?a=commit;h=24dc6600fccf13b41ae035ea613...

I could check just now with current source or wait for 1.1.17 which is expected
today.
Reported problems are fixed but some others known at least by me (comment #8)
remain.

So feel free to close this and open another for Ctrl-R refreshing for example,
or anything else you'll find out.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #16 from Nikolay Sivov   2009-03-13 09:34:53 ---
(In reply to comment #15)
> I could check just now with current source or wait for 1.1.17 which is expected
> today.

Sorry, meant 'You could ...' of course.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #17 from Nikolay Sivov   2009-04-04 02:26:11 ---
Hi, Gabriele. This should be fixed since 1.1.18. Please test again.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #18 from Gabriele Moabiti   2009-04-08 13:53:13 ---

The ctrl and shift problem seems solved but there is another problem on
selection:

- ENTER select the first (for example) folder
- Press Backspace to return on the parent dir:
the first folder now has a round box (for selection?) while
the second folder is highlighted
- Now click 2 times the down arrow -> 2 object selected...

...and the CTRL-R bug you have reported.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #19 from Nikolay Sivov   2009-04-08 16:27:19 ---
(In reply to comment #18)
> The ctrl and shift problem seems solved but there is another problem on
> selection:
> - ENTER select the first (for example) folder
> - Press Backspace to return on the parent dir:
>
> the first folder now has a round box (for selection?) while
> the second folder is highlighted

Yeah, it's true. It's possible due a broken sorting, but I'm not sure.
> - Now click 2 times the down arrow -> 2 object selected...

Can't reproduce that. I have first item focused and second selected for
example, after down key focus moves to second item so selected item got it.
You mean a VK_DOWN code without any Ctrl,Shifts?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #20 from Gabriele Moabiti   2009-04-08 16:35:04 ---
(In reply to comment #19)
> Can't reproduce that. I have first item focused and second selected for
> example, after down key focus moves to second item so selected item got it.
> You mean a VK_DOWN code without any Ctrl,Shifts?

Yes, only VK_DOWN
I see in the statusbar 2 object selected. If I move the selection to counter
returns to 1
You can also try with an other folder, not only the first one

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #21 from Gabriele Moabiti   2009-04-08 16:37:10 ---
errata:
If I move the selection to counter -> If I move the selection to the rounded
one

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #22 from Nikolay Sivov   2009-04-08 16:44:13 ---
(In reply to comment #20)
> (In reply to comment #19)
> > Can't reproduce that. I have first item focused and second selected for
> > example, after down key focus moves to second item so selected item got it.
> > You mean a VK_DOWN code without any Ctrl,Shifts?
>
> Yes, only VK_DOWN
> I see in the statusbar 2 object selected. If I move the selection to counter
> returns to 1
> You can also try with an other folder, not only the first one

I see it now. After a brief test I've noticed that inside wineprefix tree it
never happens. But trying to move out problem always here. Can you confirm
this?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #23 from Nikolay Sivov   2009-04-08 16:50:44 ---
(In reply to comment #22)
> I see it now. After a brief test I've noticed that inside wineprefix tree it
> never happens. But trying to move out problem always here. Can you confirm
> this?

Forget it. I think the problem is in directory/file detection. When you're
returning to directory without files do you get this bug?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #24 from Gabriele Moabiti   2009-04-08 17:02:42 ---
> Forget it. I think the problem is in directory/file detection. When you're
> returning to directory without files do you get this bug?

Yes

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #25 from Gabriele Moabiti   2009-04-08 17:05:52 ---
and sometimes it works but I think it's only a lucky selection

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #26 from Gabriele Moabiti   2009-04-08 17:26:13 ---

if instead of backspace you use the icon (with mouse) of "up to parent" it has
the same behavior so I think the backspace isn't the problem

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #27 from Nikolay Sivov   2009-04-09 16:40:43 ---
Hi again, Gabriele.

Try this one for Ctrl-R issue:

http://www.winehq.org/pipermail/wine-patches/2009-April/071705.html

Going forward and asking your reasonable question - 'why are additional items
selected after refreshing?' - it's broken sorting to blame which is a very high
priority candidate to fix.

You can see that when no sorting needed (e.g. dir only list) the selection is
refreshed correctly.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #28 from Gabriele Moabiti   2009-04-09 18:10:22 ---
> Going forward and asking your reasonable question - 'why are additional items
> selected after refreshing?' - it's broken sorting to blame which is a very high
> priority candidate to fix.

Tested CTRL-R works as you say!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19830|0                           |1
        is obsolete|                            |

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19835|0                           |1
        is obsolete|                            |

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #29 from Nikolay Sivov   2009-04-10 08:30:43 ---
(In reply to comment #27)
> Try this one for Ctrl-R issue:
>
> http://www.winehq.org/pipermail/wine-patches/2009-April/071705.html

Committed:

http://source.winehq.org/git/wine.git/?a=commit;h=13dfb9b3a6c05c0e6dfe5d6d55...

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #30 from Nikolay Sivov   2009-04-10 17:54:36 ---
Created an attachment (id=20371)
 --> (http://bugs.winehq.org/attachment.cgi?id=20371)
Listview sorting fix

Hi, Gabriele.

Try this please (on top of 1.1.19 tree).
For me it fixes all remaining problems we've dicussed here.

P.S. it's better to test it with any program you use (with listview in it)
to catch maximum regressions if any.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #31 from Gabriele Moabiti   2009-04-10 19:56:05 ---
Hi,
> Try this please (on top of 1.1.19 tree).
> For me it fixes all remaining problems we've dicussed here.

the CTRL-R sometimes now changes the first (top) element of the list (if the
list have a vertical scrollbar of course)

I don't know if it' related but sometimes when z-zip return to the parent dir
the columns other than 'Name' aren't drawn (it seems only for folders).
This happen also in 1.1.18 without sorting patch.
> P.S. it's better to test it with any program you use (with listview in it)
> to catch maximum regressions if any.

I'll try in the next days with other programs!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #32 from Gabriele Moabiti   2009-04-10 19:57:17 ---
Hi,
> Try this please (on top of 1.1.19 tree).
> For me it fixes all remaining problems we've dicussed here.

the CTRL-R sometimes now changes the first (top) element of the list (if the
list has got the vertical scrollbar of course)

I don't know if it's related but sometimes when z-zip returns to the parent dir
the columns other than 'Name' aren't drawn (it seems only for folders).
This happen also in 1.1.18 without sorting patch.
> P.S. it's better to test it with any program you use (with listview in it)
> to catch maximum regressions if any.

I'll try in the next days with other programs!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #33 from Nikolay Sivov   2009-04-11 04:12:42 ---
(In reply to comment #32)
> the CTRL-R sometimes now changes the first (top) element of the list (if the
> list has got the vertical scrollbar of course)

It should change it sometimes to make focused item visible.
If a focused item's visible already no scrolling will be performed.
There's could be a difference in scrolling amount (with native module) but it's
obviously another bug.

Actually I don't see any difference between clean 1.1.19 and my last patch.
Patch doesn't change focused item. Please be more specific here - provide steps
to reproduce.
> I don't know if it's related but sometimes when z-zip returns to the parent dir
> the columns other than 'Name' aren't drawn (it seems only for folders).
> This happen also in 1.1.18 without sorting patch.

It's unrelated of course. And actually I never got this while testing.
If it happens without any additional patches on clean 1.1.19 feel free to file
another report describing whole sequence to reproduce this.
> I'll try in the next days with other programs!

Great.

BTW, am I right you're using 4.65 without 'Alternative selection mode' in
settings?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #34 from Gabriele Moabiti   2009-04-11 05:49:29 ---
> > the CTRL-R sometimes now changes the first (top) element of the list (if the
> > list has got the vertical scrollbar of course)
>
> It should change it sometimes to make focused item visible.
> If a focused item's visible already no scrolling will be performed.
> There's could be a difference in scrolling amount (with native module) but it's
> obviously another bug.
> Actually I don't see any difference between clean 1.1.19 and my last patch.
> Patch doesn't change focused item. Please be more specific here - provide steps
> to reproduce.

Sorry, I wasn't clear. It doesn't change the focused item but change the first
visible item (the top item) of the list. The selected element when I press
CTRL-R is visible in the list of course! This is a schema of what happen:

ELEMENT1 <- top element
ELEMENT2
[ELEMENT3] focused
ELEMENT4
ELEMENT5
...

and after CTRL-R:

ELEMENT2  <- new top element
[ELEMENT3] focused
ELEMENT4
ELEMENT5
...

It isn't terrible but a bit strange
I will provide reproducible steps if needed but you can try with a directory
with many elements..
> BTW, am I right you're using 4.65 without 'Alternative selection mode' in
> settings?

Yes

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20371|0                           |1
        is obsolete|                            |

--- Comment #35 from Nikolay Sivov   2009-04-11 18:09:52 ---
Created an attachment (id=20386)
 --> (http://bugs.winehq.org/attachment.cgi?id=20386)
Keep ranges in sync with states, same for focused, fix sorting

Gabriele, try this patch. I've simplified sorting with some rather deep changes
to other code. A problem with unnecessary scrolling is solved I think.
I'm still requesting to test it with other apps to catch possible regressions.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #36 from Gabriele Moabiti   2009-04-11 18:53:56 ---
> Gabriele, try this patch. I've simplified sorting with some rather deep changes
> to other code. A problem with unnecessary scrolling is solved I think.
> I'm still requesting to test it with other apps to catch possible regressions.

I see the patch ... semplifying is always a good think :)
Sorry but is still present the unnecessary scrolling.
To test it point to a directory in which are present only directories with
simple name like a,b,c,...,z and resize the window to contain only the first
half then try to refresh on each element... Sometimes the unnecessary scrolling
already happen and it's not erratic.. for example in my test the refresh on
directory 'e' set the top on 'e' itself, with directory 'c' on 'b' and so on...

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, source

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #37 from Nikolay Sivov   2009-04-13 02:06:55 ---
(In reply to comment #36)
> I see the patch ... semplifying is always a good think :)
> Sorry but is still present the unnecessary scrolling.
> To test it point to a directory in which are present only directories with
> simple name like a,b,c,...,z and resize the window to contain only the first
> half then try to refresh on each element... Sometimes the unnecessary scrolling
> already happen and it's not erratic.. for example in my test the refresh on
> directory 'e' set the top on 'e' itself, with directory 'c' on 'b' and so on...

Yeah, see it. Let's try to last patches got committed - then I'll try to solve
this.

P.S. http://www.winehq.org/pipermail/wine-patches/2009-April/071794.html

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #38 from Gabriele Moabiti   2009-04-13 15:01:49 ---
> Yeah, see it. Let's try to last patches got committed

Tested ok. I continue to test with other applications
> then I'll try to solve this.

Ok!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20386|0                           |1
        is obsolete|                            |

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #39 from Nikolay Sivov   2009-04-14 16:10:27 ---
Broken selection ranges after sorting are fixed now (including returning to
parent directory):

http://source.winehq.org/git/wine.git/?a=commit;h=9c1a0e468f5cfbe9d863852ed5...

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #40 from Gabriele Moabiti   2009-04-14 17:48:58 ---

For the second problem of comment #32

"I don't know if it's related but sometimes when z-zip returns to the parent
dir
the columns other than 'Name' aren't drawn (it seems only for folders).
This happen also in 1.1.18 without sorting patch."

I have posted 2 files
'step1-no_refresh.png' is taken before I select directory 't' then I press
enter (t was empty) then backspace and the result is shown in
'step2-no_refresh.png'.

I have seen this happen only when I select the latest entirely visible
directory in list.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #41 from Nikolay Sivov   2009-04-15 01:28:44 ---
(In reply to comment #40)
> For the second problem of comment #32
> I have posted 2 files

Where?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #42 from Gabriele Moabiti   2009-04-15 02:08:36 ---
> Where?

I try but I always fail to post these files... maybe a problem on wine bugzilla
(only 37KB) and it's not the fiirst time it happen!

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

--- Comment #43 from Gabriele Moabiti   2009-04-15 04:14:48 ---
Created an attachment (id=20457)
 --> (http://bugs.winehq.org/attachment.cgi?id=20457)
step 1 and 2 of comment #40

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

RD  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #44 from RD   2009-07-20 09:37:11 ---
(In reply to comment #36)
> > Gabriele, try this patch. I've simplified sorting with some rather deep changes
> > to other code. A problem with unnecessary scrolling is solved I think.
> > I'm still requesting to test it with other apps to catch possible regressions.
>
> I see the patch ... semplifying is always a good think :)
> Sorry but is still present the unnecessary scrolling.
> To test it point to a directory in which are present only directories with
> simple name like a,b,c,...,z and resize the window to contain only the first
> half then try to refresh on each element... Sometimes the unnecessary scrolling
> already happen and it's not erratic.. for example in my test the refresh on
> directory 'e' set the top on 'e' itself, with directory 'c' on 'b' and so on...

I am seeing this unnecessary scrolling with wine 1.1.26 and 7-Zip 4.65

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #45 from Bruno Jesus  2011-11-09 19:47:37 CST ---
Seems fixed for me in 1.3.32. Can anyone else retest?

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #46 from Jerome Leclanche  2012-02-26 13:12:25 CST ---
Reported fixed. Please reopen if you are able to reproduce in wine-1.4-rc5.

[Bug 17564] 7-zip file manager interface selection problem

http://bugs.winehq.org/show_bug.cgi?id=17564

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #47 from Alexandre Julliard  2012-03-02 13:01:36 CST ---
Closing bugs fixed in 1.4-rc6.