http://bugs.winehq.org/show_bug.cgi?id=25660
Summary: Half-Life 1 Demo: "The selected D3D mode is not supported by your video card." Product: Wine Version: 1.3.7 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: directx-ddraw AssignedTo: wine-bugs@winehq.org ReportedBy: wylda@volny.cz
Half-Life 1 Demo or full game says "The selected D3D mode is not supported by your video card". Steps to reproduce:
* install the demo * (optional speed-up) rename "media/intro.avi" to "media/intro.avix" * Menu -> Configuration -> Video modes -> (tab) Direct3D -> (choose) 1024x768 * New Game -> "The selected D3D mode is not supported by your video card"
1. I did a regression test between 1.3.6 and 1.3.7:
commit 7661e8986c7bed0a6735f04d6be660cf0f6a7ed0 Author: David Adam david.adam.cnrs@gmail.com Date: Wed Nov 3 07:10:54 2010 +0100
ddraw: Exclusive mode is the corner case for SetCooperative, not the normal mode.
2. No other bug report suffers from this commit.
3. Revert of this patch after git checkout makes that problem go away.
4. Adding author of this patch to CC.
--private keyword: bisected
http://bugs.winehq.org/show_bug.cgi?id=25660
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression URL| |http://pc.ign.com/articles/ | |066/066867p1.html CC| |jeremielapuree@yahoo.fr
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #1 from Wylda wylda@volny.cz 2011-01-07 16:55:13 CST ---
This regression (bisected) is still present in wine-1.3.11.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #2 from Wylda wylda@volny.cz 2011-01-16 09:53:25 CST ---
This regression (bisected) is still present in wine-1.3.11-211-gbaeb0d9.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #3 from joaopa jeremielapuree@yahoo.fr 2011-01-16 11:44:17 CST --- Created an attachment (id=32873) --> (http://bugs.winehq.org/attachment.cgi?id=32873) fix for the regression
Does this patch fix the regression?
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #4 from Wylda wylda@volny.cz 2011-01-16 11:54:18 CST ---
Does this patch fix the regression?
Yes & Thanks! :) Patch applied on top of 1.3.11 and problem gone.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #5 from Wylda wylda@volny.cz 2011-01-22 17:49:46 CST ---
This regression (bisected) is still present in wine-1.3.12.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #6 from joaopa jeremielapuree@yahoo.fr 2011-01-23 20:06:46 CST --- My patch is wrong. Setcooperatilevel looks a lot more complicated that it is implemented in Wine.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #7 from joaopa jeremielapuree@yahoo.fr 2011-06-01 13:31:47 CDT --- Created an attachment (id=34984) --> (http://bugs.winehq.org/attachment.cgi?id=34984) Debug trace with ddraw and d3d channels enabled
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #8 from Wylda wylda@volny.cz 2011-06-18 18:54:33 CDT ---
This regression (bisected) is still present in wine-1.3.22-203-gac90c1b.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #9 from joaopa jeremielapuree@yahoo.fr 2011-06-19 01:44:29 CDT --- My tests about this bug were rejected. Don't know why though. Stefan Dosinger said they were correct, but AJ rejected them.
So, surely I can not fix this bug.
http://bugs.winehq.org/show_bug.cgi?id=25660
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22507
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #10 from Wylda wylda@volny.cz 2011-07-15 15:26:12 CDT ---
This regression (bisected) is still present in wine-1.3.24-174-g4b4dd30.
Stefan Dosinger said they were correct, but AJ rejected them.
Then if you know, that you were wrong with your initial commit and fix was rejected, why don't you ask at least for revert? Or try to push it - persistently. One day, in a weak moment, it will slip in ;)
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #11 from joaopa jeremielapuree@yahoo.fr 2011-07-15 23:51:13 CDT --- The patch that introduced the regression is correct, as the tests showed. This bug was hidden only. When I wrote "My patch is wrong" I meant the attached patch in this bug is uncorrect.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #12 from joaopa jeremielapuree@yahoo.fr 2011-07-28 15:30:26 CDT --- Created an attachment (id=35732) --> (http://bugs.winehq.org/attachment.cgi?id=35732) tests showing that CreateDeviceWindow accepts NULL argument
I attach these tests to not lose them.
http://bugs.winehq.org/show_bug.cgi?id=25660
Henri Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |7661e8986c7bed0a6735f04d6be | |660cf0f6a7ed0
http://bugs.winehq.org/show_bug.cgi?id=25660
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|directx-ddraw |directx-d3d
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #13 from Wylda wylda@volny.cz 2011-12-03 00:10:06 CST ---
This regression (bisected) is still present in wine-1.3.34.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #14 from Henri Verbeet hverbeet@gmail.com 2011-12-23 13:05:58 CST --- Should be fixed by d8153e5364ed9044692ea77c128144e561d6dcae.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #15 from joaopa jeremielapuree@yahoo.fr 2011-12-23 22:40:41 CST --- Indeed, bug is fixed. Thanks, Henri.
http://bugs.winehq.org/show_bug.cgi?id=25660
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |d8153e5364ed9044692ea77c128 | |144e561d6dcae Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #16 from Austin English austinenglish@gmail.com 2011-12-24 13:55:13 CST --- (In reply to comment #15)
Indeed, bug is fixed. Thanks, Henri.
Fixed.
http://bugs.winehq.org/show_bug.cgi?id=25660
--- Comment #17 from Wylda wylda@volny.cz 2011-12-26 14:53:59 CST --- (In reply to comment #15)
Indeed, bug is fixed. Thanks, Henri.
Fixed for me too. Thank you Henri :)
http://bugs.winehq.org/show_bug.cgi?id=25660
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #18 from Alexandre Julliard julliard@winehq.org 2011-12-30 12:56:34 CST --- Closing bugs fixed in 1.3.36.