[Bug 33794] New: Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Bug #: 33794
           Summary: Arabic Entry Box Has Big Errors .
           Product: Wine
           Version: 1.5.31
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: usp10
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

When run wine at Arabic session the entry box has many problems as ::

1 - First it shown empty even it isn't empty .
2 - When try to write it shown reversed .
3 - Shaping false of Arabic letters .
4 - Spaces between letters are not organized .

When run wine at English session the entry box has a problem is ::

1 - Couldn't write in Arabic , show x11 drv keyboard error !

When run wine at Arabic session and Microsoft usp10.dll ::

1 - The entries shown at first time
2 - Arabic letters also don't organized !

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #1 from Mosaab Alzoubi  2013-06-13 07:31:18 CDT ---
Created attachment 44785
  --> http://bugs.winehq.org/attachment.cgi?id=44785
Screen shot of the bug .

At name entry box I write :

مصعب الزعبي

At organization entry box I write :

مشروع ألماسه

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Mosaab Alzoubi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Mosaab Alzoubi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #2 from Aric Stewart  2013-06-14 12:18:40 CDT ---
I have just started looking here but it is not a uniscribe issue. As the
problem persists with native uniscribe as well as our builtin.

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #3 from Mosaab Alzoubi  2013-06-14 15:39:10 CDT ---
When use native usp10 the default value (non Arabic) edit box text shown .

In wine usp10 don't shown !

So I think the usp10 has a work !

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #4 from Mosaab Alzoubi  2013-06-14 15:50:06 CDT ---
Created attachment 44803
  --> http://bugs.winehq.org/attachment.cgi?id=44803
New information !

This is Firefox 21 setup tool :

Some wrongs :

1 - At first line ( title ) (Mozilla Firefox) must align to left , it's shown
right ! Also at second line .

2 - All next lines have a many spaces at first !!!

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #5 from Aric Stewart  2013-06-14 20:53:09 CDT ---
(In reply to comment #3)
> When use native usp10 the default value (non Arabic) edit box text shown .
>
> In wine usp10 don't shown !
>
> So I think the usp10 has a work !

Sorry I don't quite understand.  Does using the native usp10 solve this problem
for you?

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #6 from Mosaab Alzoubi  2013-06-15 05:41:29 CDT ---
No it doesn't solve .

But it change one thing :

The default text ( which written in edit box at dialog start )

In native usp10 >>> It's shown
In wine usp10 >>> dosent shown

!!!

All other problems shared ^_^

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #7 from Aric Stewart  2013-06-19 07:12:24 CDT ---
I have found that this appears to be an issue with ExtTextOut when lpDX is
specified.

Uniscribe (both native and builtin) give positive values for lpDx and when a DC
has LAYOUT_RTL specified this cause ExtTextOut to really seriously
miss-position the characters.

Unfortunately I do not have time to do much more investigation here. Hopefully
someone else familiar with ExtTextOut or LAYOUT_RTL can pick this up.

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #8 from Mosaab Alzoubi  2013-06-19 07:40:23 CDT ---
Thank You Aric for your description .

-----------

Till anybody fix it , please confirm the bug .

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #9 from Mosaab Alzoubi  2013-06-30 20:32:38 CDT ---
Thank you Aric .
I try your patch here http://source.winehq.org/patches/data/96984

Some points :

* At graphic section in winecfg , lately the values in ( virtual desktop size )
and ( dpi box ) shown .

* At entry boxes the default values shown again but having terrible spaces .

* At entry boxes Arabic letters contacts again , also terrible spaces .

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #10 from Aric Stewart  2013-07-02 08:07:07 CDT ---
Chatting with Alexandre he tells me:

"the whole coordinate mapping in ExtTextOut needs to be redone it should be
moved to the drivers, and work in device coords ... it won't happen during code
freeze "

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #11 from Mosaab Alzoubi  2013-07-02 16:12:22 CDT ---
I respect the decision , I still think solving more importance than freezing
.Especially before stable version .

Thank For Your Attention .

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #12 from Mosaab Alzoubi  2013-08-18 23:03:56 CDT ---
This patch solve about 50% of the bug .

http://source.winehq.org/patches/data/96984

Please apply it .

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #13 from Aric Stewart  2013-09-11 20:35:24 CDT ---
This should be resolved for non-truetype fonts.

Commit: 4a300d2423d18abe915ad070b9611e72749dec4d
Author: Aric Stewart 
Date:   Wed Sep 11 07:46:53 2013 -0500

gdi32: GetCharWidth32A/W return positive widths for all layouts and various DC
transforms.

So you examples with winecfg will now be working.

Truetype fonts will still be broken until the ABC values patches is committed.

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #14 from Mosaab Alzoubi  2013-09-12 01:09:09 CDT ---
Created attachment 45922
  --> http://bugs.winehq.org/attachment.cgi?id=45922
That's so better .

I built wine 1.7.1 wich patched by two new patches written by Aric .

http://source.winehq.org/patches/data/98724 (commited)
http://source.winehq.org/patches/data/98721 (still)

They solved this problem.

Thank You Very Much

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #15 from Aric Stewart  2013-09-13 06:28:01 CDT ---
Ok this issue should now be fully resolved with this last commit.

commit 3f4ef58b0fdb771ffacb64812c32aa625892a16f
Author: Aric Stewart 
Date:   Thu Sep 12 13:01:56 2013 -0500

gdi32: ABC value signs remain the same despite any changes in layout
direction or viewport.

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

--- Comment #16 from Mosaab Alzoubi  2013-09-13 09:24:22 CDT ---
Thank You Very Very Much >

^_^

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3f4ef58b0fdb771ffacb64812c3
                   |                            |2aa625892a16f
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Bruno Jesus  2013-09-13 09:28:11 CDT ---
(In reply to comment #16)
> Thank You Very Very Much >
>
> ^_^

Resolving fixed, using the second patch as Fixed SHA1.

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  2013-09-13 13:19:47 CDT ---
Closing bugs fixed in 1.7.2.

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.6.x

[Bug 33794] Arabic Entry Box Has Big Errors .

http://bugs.winehq.org/show_bug.cgi?id=33794

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.6.x                       |---

--- Comment #19 from Alexandre Julliard  2013-11-15 13:40:29 CST ---
Removing 1.6.x milestone from bugs included in 1.6.1.