[Bug 38581] New: Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

Bug ID: 38581
           Summary: Petka 1: some objects render without transparency
           Product: Wine
           Version: 1.7.42
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 51474
  --> https://bugs.winehq.org/attachment.cgi?id=51474
console output

Wine 1.7.42, 32-bit prefix, Debian Unstable amd64
Game works without these glitches under WinXP
There's interesting d3d-related fixmes in terminal (see attachment)

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

ax 34noff  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from ax 34noff  ---
Created attachment 51475
  --> https://bugs.winehq.org/attachment.cgi?id=51475
screenshot 1

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #2 from ax 34noff  ---
Created attachment 51476
  --> https://bugs.winehq.org/attachment.cgi?id=51476
screenshot 2

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #3 from ax 34noff  ---
Created attachment 51477
  --> https://bugs.winehq.org/attachment.cgi?id=51477
screenshot 3

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

ax 34noff  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.buka.ru/cgi-bin/
                   |                            |show.pl?id=100

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |directx-d3d

--- Comment #4 from Henri Verbeet  ---
Looks like a color-keying issue, probably because we don't actually implement
WINED3D_CKEY_COLORSPACE. Does this have a demo or free download?

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #5 from ax 34noff  ---
Yes, it has demo but there's no glitches in it in Wine:
http://www.ag.ru/games/petka-i-vasiliy-ivanovich-spasayut-galaktiku/demos/36...

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #6 from Stefan Dösinger  ---
Is this because the glitches are only visible in a few levels, or because the
demo is an older or newer version of the game than the one you run?

In the former case, can you attach a +ddraw log? In any case try to install
game updates, if any. To my knowledge Windows doesn't support range color keys
either, but maybe that was because I made a mistake when testing this a while
ago (I think I didn't set DDCKEY_COLORSPACE).

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #7 from ax 34noff  ---
Demo is old and has it's own scenes and objects that mostly aren't used in
non-demo.
Running game with WINEDEBUG=+ddraw...

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #8 from ax 34noff  ---
Created attachment 51521
  --> https://bugs.winehq.org/attachment.cgi?id=51521
console output with WINEDEBUG=+ddraw, Wine 1.7.43

zipped because it's large

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #9 from Stefan Dösinger  ---
Created attachment 52152
  --> https://bugs.winehq.org/attachment.cgi?id=52152
ddraw: Return the right error if range color keys are used.

Can you give this patch a try? It changes the error handling if a range color
key is used to match the behavior of my Geforce 7300 driver, which doesn't
support color keys.

If this doesn't fix the game: Which GPU are you running it on Windows? I
haven't found a GPU that supports range color keys on Windows yet. (Tested a
few Nvidia and AMD ones)

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #10 from ax 34noff  ---
The patch doesn't solve the problem.
> Which GPU are you running it on Windows?

I run the game in VirtualBox and VMWare Player. I also ran it before under
Win98 on some old machines. Does the game use hardware acceleration at all in
Windows?

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #11 from ax 34noff  ---
Now i see the only fixme:
> fixme:d3d_surface:surface_cpu_blt Filter WINED3D_TEXF_LINEAR not supported in software blit.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #12 from Stefan Dösinger  ---
Does the transparency issue still show up? The LINEAR filtering FIXME is mostly
harmless.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #13 from Stefan Dösinger  ---
Wrt HW acceleration, it probably doesn't require it at all. However, none of my
windows systems support range color key (DDCKEY_COLORSPACE) with software nor
hardware blits.

I found some online evidence that old GPUs (i810, some SiS cards) support src
key color spaces, but nothing from Nvidia or ATI, and nothing from the DirectX
9 era or newer.

If the game indeed needs range color keys I'll implement this in Wine, but I
need a Windows machine that supports this feature to find out how it is
supposed to work...

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #14 from ax 34noff  ---
(In reply to Stefan Dösinger from comment #12)
> Does the transparency issue still show up?

Yes, it does.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #15 from Stefan Dösinger  ---
Created attachment 52163
  --> https://bugs.winehq.org/attachment.cgi?id=52163
Range color key test

The attached file is a patch for the ddraw test that tests range color keys.
Can you run it on a Windows installation where Petka renders correctly and
attach the output in a text file here? I'll try to attach a pre-built .exe as
well for your convenience, but I don't know if Bugzilla will allow this.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #16 from Stefan Dösinger  ---
Created attachment 52164
  --> https://bugs.winehq.org/attachment.cgi?id=52164
Test binary

The modified test can be run with "ddraw_crosstest.exe ddraw7"

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #17 from ax 34noff  ---
Created attachment 52165
  --> https://bugs.winehq.org/attachment.cgi?id=52165
output of "ddraw_crosstest.exe ddraw7"

p.s. What have i to do with attachment 52163 ?

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #18 from ax 34noff  ---
Comment on attachment 52165
  --> https://bugs.winehq.org/attachment.cgi?id=52165
output of "ddraw_crosstest.exe ddraw7"

VMWare Player 7.1.2, Arch Linux amd64

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #19 from Stefan Dösinger  ---
Ok, no range color key support on this box.

You don't have to do anything special with 52163. I attached it in case you
want to compile the test yourself instead of running my binary.

I'll extend my previous ddraw test with extra debugging...

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52152|0                           |1
        is obsolete|                            |

--- Comment #20 from Stefan Dösinger  ---
Created attachment 52167
  --> https://bugs.winehq.org/attachment.cgi?id=52167
DDCKEY_COLORSPACE patch with extra debug

Hi again,

Can you test the game with this patch? It is a slightly modified version of
52152 that writes the rejected color key to the ERR debug channel. Look (in the
regular output, no debug flags needed) for "Range color keys are not
supported..." and copypaste one of those lines into the bug report.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #21 from Stefan Dösinger  ---
Created attachment 52168
  --> https://bugs.winehq.org/attachment.cgi?id=52168
Write a debug line when converting surfaces

The DDCKEY_COLORSPACE thing may be a red herring altogether. I noticed that the
app calls SetColorKey with a non-range key shortly after the failing
SetColorKey call and before the surface is used for blitting.

I did notice though that the game mixes 16 bit and 32 bit pixel formats. It's
possible that we're doing converted blits, and we don't take the color key
along during the conversion.

This patch adds a debug statement ("converting surface from...") that prints
the color key flags of the source surface. Please run the game with this patch
and look for these lines. Attach the output (no debug flags needed).

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #22 from ax 34noff  ---
Some these lines:
> err:ddraw:ddraw_surface_set_color_key Range color keys are not supported, returning DDERR_NOCOLORKEYHW 00000000 7fffffff.

Can't see any "converting surface from".
Wine Git 32bit build with both patches.
> I did notice though that the game mixes 16 bit and 32 bit pixel formats.

Doesn't it use 8bit (indexed) format for some sprites? I can see significant
dithering on buggy sprites but i don't see it on the rest of picture.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #23 from Stefan Dösinger  ---
Hmm indeed, there's only one 32 bit surface, and it is never used for blitting.
I am running out of ideas.

Is there any way I can get my hands on the real game, other than trying to find
a torrent somewhere?

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #24 from ax 34noff  ---
> Is there any way I can get my hands on the real game, other than trying to find a torrent somewhere?

http://petka-vich.ru/ is official site but i'm unsure if Windows version is
still available for purchase.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |[e-mail]

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from joaopa  ---
Still a bug in current wine?

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #26 from ax 34noff  ---
Wine 2.2, bug still here.
p.s. English name of this game is "Red Comrades Save The Galaxy"

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #27 from joaopa  ---
Is still a bug with current wine (wine-3.19)?

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #28 from ax 34noff  ---
Yes, it is.

[Bug 38581] Petka 1: some objects render without transparency

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #29 from ax 34noff  ---
Here is the game in Steam but i'm unsure if it's the same version as on my old
CD:
https://store.steampowered.com/app/415610/Red_Comrades_Save_the_Galaxy_Reloa...

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #30 from joaopa  ---
Does the bug still occur with wine-5.10?

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #31 from ax 34noff  ---
@joaopa, yes, it does.

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #32 from joaopa  ---
Does the bug still occur with wine-6.17?

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #33 from ax 34noff  ---
@joaopa, yes, it does.
I also experienced such issue in other apps (not games) earlier, but sadly i
can't remember what apps.

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #34 from joaopa  ---
Does the bug still occur with wine-7.16?

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #35 from ax 34noff  ---
@joaopa, yes, it does.

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

Stefan Dösinger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #36 from Stefan Dösinger  ---
Did you have a chance to test the Steam version in the meantime? If not I guess
I'll try it myself somewhen.

[Bug 38581] Petka 1: some objects render without transparency

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38581

--- Comment #37 from ax 34noff  ---
I think Steam version is completely different under the hood.