[Bug 44964] New: Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

Bug ID: 44964
           Summary: Anno 2205 graphics messed up
           Product: Wine
           Version: 3.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 61079
  --> https://bugs.winehq.org/attachment.cgi?id=61079
Anno 2205 graphic glitch

The game finaly starts and runs but with messed up graphics. The artefacts are
moving with the moving of screen and they are different.

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
Created attachment 61080
  --> https://bugs.winehq.org/attachment.cgi?id=61080
Anno 2205 graphic glitch

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #2 from [e-mail] ---
Created attachment 61081
  --> https://bugs.winehq.org/attachment.cgi?id=61081
Anno 2205 graphic glitch

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #3 from [e-mail] ---
Created attachment 61082
  --> https://bugs.winehq.org/attachment.cgi?id=61082
Anno 2205 graphic glitch

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #4 from [e-mail] ---
Created attachment 61083
  --> https://bugs.winehq.org/attachment.cgi?id=61083
Anno 2205 graphic glitch

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #5 from [e-mail] ---
Created attachment 61084
  --> https://bugs.winehq.org/attachment.cgi?id=61084
Anno 2205 graphic glitch

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

Toni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Toni  ---
You should also post some debug logs to help in debugging the issue

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #7 from [e-mail] ---
Of course, sorry fot that.

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #8 from [e-mail] ---
Created attachment 61091
  --> https://bugs.winehq.org/attachment.cgi?id=61091
Anno 2205 wine-staging 3.5 log

Anno 2205 wine-staging 3.5 log

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #9 from Toni  ---
you seem to be getting some nasty shader errors (syntax errors), like:

003d:fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader
#55:
003d:fixme:d3d_shader:print_glsl_info_log     0(158) : error C0000: syntax
error, unexpected ')', expecting ',' or ';' at token ")"

(...)

003d:fixme:d3d_shader:shader_glsl_dump_program_source     } else {
003d:fixme:d3d_shader:shader_glsl_dump_program_source    
uintBitsToFloat(0xffffffffu));
003d:fixme:d3d_shader:shader_glsl_dump_program_source     }

Regarding the game you could try changing settings to see if any options make
any difference.

Regarding the bug itself, might be worth it to open a separate bug with
something like "Anno 2205 generating invalid glsl shaders (mismatched
parenthesis)"

Then there might be something else going on but that's definitely an issue that
can be solved on its own and looks both nasty and "easy" (for someone that
knows the internals).

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #10 from [e-mail] ---
Yes, turning off anti-aliasing completely solves the problem. Thank you very
much! Did I have to file a bug in this case?

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #11 from Toni  ---
(In reply to mo78 from comment #10)
> Yes, turning off anti-aliasing completely solves the problem. Thank you very
> much! Did I have to file a bug in this case?

I think it would be good to file a more specific bug about the syntax errors
with a title like: "Anno 2205 generating invalid glsl shaders when aa is
enabled (mismatched parenthesis)"

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #12 from Toni  ---
Or, if that was the only problem you could just change the title from this bug
so it's easier for a dev to spot the long hanging fruit ;)

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #13 from Toni  ---
(In reply to Toni from comment #12)
> long hanging fruit

"low hanging" what a pita not being able to edit comments

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #14 from Toni  ---
Btw, please add a report on the appdb as soon as you're happy with how it works
or not being able to advance any more in getting it perfect, that will help
other people in running the game and maybe fixing any remaining issues.

[Bug 44964] Anno 2205 graphics messed up

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #15 from [e-mail] ---
It's difficult for me to do things properly for my native language is
bulgarian. I'll edit the title of this bug, thank you :)

[Bug 44964] Anno 2205 generating invalid glsl shaders when aa is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Anno 2205 graphics messed   |Anno 2205 generating
                   |up                          |invalid glsl shaders when
                   |                            |aa is enabled (mismatched
                   |                            |parenthesis)

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |directx-d3d
            Summary|Anno 2205 generating        |Anno 2205 generates invalid
                   |invalid glsl shaders when   |GLSL shaders when
                   |aa is enabled (mismatched   |antialiasing is enabled
                   |parenthesis)                |(mismatched parenthesis)

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Fabian Maurer  ---
I assume this is a D3D game. Can you provide an apitrace
(https://github.com/apitrace/apitrace/blob/master/docs/USAGE.markdown) of a
scene where the glitches are happening?
Not everyone owns the game, and this way we could still test the issue.

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #17 from [e-mail] ---
What do you mean with "D3D game"? It uses DX11 if that is the question :)

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #18 from Fabian Maurer  ---
Yeah, so it uses Direct3D11, too. It's the 3D part of DirectX11.

With apitrace you can record the drawing calls the program makes, so we can
replay it on our machine, without owning the game.

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #19 from Toni  ---
Fabian in this case I think it's more about an incorrect translation of shaders
(see log and analysis above) inside wine so not sure apitrace will be of much
help.

That said, I posted before a small howto about running apitrace at
https://bugs.winehq.org/show_bug.cgi?id=45080#c7 since by the webpage it's not
obvious what's the best way to do it.

The resulting .trace file is what Fabian is asking for, so you can skip the
'dump' part.

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #20 from [e-mail] ---
I can't get the game running when trying apitrace and it crashes immediately:

https://pastebin.com/BNjmSCE0

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #21 from Fabian Maurer  ---
(In reply to Toni from comment #19)
> Fabian in this case I think it's more about an incorrect translation of
> shaders (see log and analysis above) inside wine so not sure apitrace will
> be of much help.

Maybe I didn't make that clear, but I meant running apitrace under wine,
capturing the D3D calls. This way you can replay it under wine, and let it
translate the shaders again.

(In reply to mo78 from comment #20)
> I can't get the game running when trying apitrace and it crashes immediately:

How exactly are you running it?

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #22 from Toni  ---
(In reply to Fabian Maurer from comment #21)
> (In reply to Toni from comment #19)
> > Fabian in this case I think it's more about an incorrect translation of
> > shaders (see log and analysis above) inside wine so not sure apitrace will
> > be of much help.
>
> Maybe I didn't make that clear, but I meant running apitrace under wine,
> capturing the D3D calls. This way you can replay it under wine, and let it
> translate the shaders again.

Yep, sorry I also didn't make myself clear, I'm talking about apitrace under
wine of course... if wine is generating a bad shader and sending it over you
will see the same shader you can see with wine's own debug.

Anyways who knows maybe you find something else with apitrace :)

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #23 from [e-mail] ---
I already gave some apitrace logs to DXVK project but with Anno and Mafia I
can't get it. I start it in the right way - enter the apitrace-msvc/x64/bin/
folder and than piont to the prefix with the game:
wine apitrace.exe trace -a dxgi
/media/sdc1/Side/Anno2205/prefix/drive_c/Games/Anno\
2205/Bin/Win64/Anno2205.exe &>wine.log

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #24 from [e-mail] ---
*point it to the prefix

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #25 from Fabian Maurer  ---
Wine staging doesn't help with that? Some games just don't work, I'm afraid.

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #26 from [e-mail] ---
Turning off anti-aliasing solves the problem, I wrote it already :)

[Bug 44964] Anno 2205 generates invalid GLSL shaders when antialiasing is enabled ( mismatched parenthesis)

https://bugs.winehq.org/show_bug.cgi?id=44964

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #27 from Józef Kucia  ---
Created attachment 61376
  --> https://bugs.winehq.org/attachment.cgi?id=61376
Implement oMask

Does the attached patch help?

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Anno 2205 generates invalid |Anno 2205 needs oMask
                   |GLSL shaders when           |shader register
                   |antialiasing is enabled     |implementation
                   |(mismatched parenthesis)    |

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #28 from [e-mail] ---
I tried the patch on vanilla wine but the game doesn't run fot it needs some
components but I don't know how to instal them into patched Wine. It's too
difficult for me.

https://pastebin.com/Fdypn0HK

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #29 from [e-mail] ---
I managed to run the game with the Józef Kucia's patch but the problem is still
there. If I turn off antialiasing the problem disappears.

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #30 from [e-mail] ---
Please ingnore my previous message - I'm don't shure if I tried it properly at
all. I downloaded Wine, applied the patch, than I ran ./configure
--enable-win64 and then sudo make install. Then I installed the components
required from Anno 2205 via winetricks, the game started and the bug was there. 
I made another try and uninstalled Wine completely. Then I issued sudo make
install again and it occurs that I have not installed Wine at all. Please let
someone try it, I don't know how, sorry :(

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #31 from Toni  ---
mo78 I have pm'd you some instructions that can help you in trying this (don't
want to add too much noise here)

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #32 from [e-mail] ---
Thanks to great Tony I finaly succeeded to start the game with the patch and it
works! All levels of antialiasing uo to x8 work now except x16 which makes the
game to crash after it has been applied. Great work Józef Kucia, thank you.

It seems the game has some ground missing texture problems. I'll attach some
screenshots.

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #33 from [e-mail] ---
Created attachment 61387
  --> https://bugs.winehq.org/attachment.cgi?id=61387
Anno 2025 missing ground textures screenshot.

Anno 2025 missing ground textures screenshot.

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #34 from [e-mail] ---
Created attachment 61388
  --> https://bugs.winehq.org/attachment.cgi?id=61388
Anno 2025 missing ground textures screenshot.

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

--- Comment #35 from [e-mail] ---
Created attachment 61389
  --> https://bugs.winehq.org/attachment.cgi?id=61389
Anno 2025 missing ground textures screenshot.

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|UNCONFIRMED                 |STAGED
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/wined3d-Implemen
                   |                            |t-oMask
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9a9ecb9b118948fd30eb7ff7fad
                   |                            |2edead3b7301e
             Status|STAGED                      |RESOLVED
         Resolution|---                         |FIXED

--- Comment #36 from Alistair Leslie-Hughes  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=9a9ecb9b118948fd30eb7ff7f...

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

Józef Kucia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #37 from Józef Kucia  ---
*** Bug 45087 has been marked as a duplicate of this bug. ***

[Bug 44964] Anno 2205 needs oMask shader register implementation

https://bugs.winehq.org/show_bug.cgi?id=44964

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #38 from Alexandre Julliard  ---
Closing bugs fixed in 3.9.