http://bugs.winehq.org/show_bug.cgi?id=16932
Summary: GTA:SA - Models have strange colours Product: Wine Version: unspecified Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: kgbricola@web.de CC: stefan@codeweavers.com
Created an attachment (id=18695) --> (http://bugs.winehq.org/attachment.cgi?id=18695) Screenshot from the coloured models
Models in GTA:SA have strange colours. This is regression caused by the following patch. This happens with vertexshader enabled. If they are disabled the models are looking fine.
1deafcb5a758ba7c88e498718a3186d6b526fe71 is first bad commit commit 1deafcb5a758ba7c88e498718a3186d6b526fe71 Author: Stefan Dösinger stefan@codeweavers.com Date: Mon Dec 15 19:37:36 2008 +0100
wined3d: Split the remains of state_fog.
:040000 040000 39455d30afadc1d21664e6730064c5028aa2c3eb 91e5b3d98e7cd72aa61dd8eac1058792d5fce9a7 M dlls
http://bugs.winehq.org/show_bug.cgi?id=16932
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #1 from Rico kgbricola@web.de 2009-01-17 07:00:29 --- Created an attachment (id=18756) --> (http://bugs.winehq.org/attachment.cgi?id=18756) workaround for the coloured models
This workaround let look the models fine, but I don't know if it's at the correct position, even if it is correct at all.
There seems to be a problem with this message "vertex shader with table fog used\n". Probably there is more needed to fix the whole problem.
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #2 from Stefan Dösinger stefandoesinger@gmx.at 2009-01-17 07:07:22 --- Judging from the screenshot and the workaround I think I have a fix for this problem.
Currently my wine tree has another branch checked out, but I'll send that fix within the next days. It is a set of patches that fixes how the fog source is selected, so it is slightly bigger than this code.
http://bugs.winehq.org/show_bug.cgi?id=16932
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=16932
Ivanov d137@abv.bg changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |d137@abv.bg
--- Comment #3 from Ivanov d137@abv.bg 2009-01-18 07:37:05 --- *** Bug 16993 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=16932
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #18756|application/octet-stream |text/plain mime type| | Attachment #18756|0 |1 is patch| |
http://bugs.winehq.org/show_bug.cgi?id=16932
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a.vankaam@chello.nl
--- Comment #4 from Vitaliy Margolen vitaliy@kievinfo.com 2009-01-18 15:12:59 --- *** Bug 16997 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=16932
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Version|unspecified |1.1.13
--- Comment #5 from Vitaliy Margolen vitaliy@kievinfo.com 2009-01-18 15:16:40 --- Confirming
http://bugs.winehq.org/show_bug.cgi?id=16932
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
--- Comment #6 from Vitaliy Margolen vitaliy@kievinfo.com 2009-01-18 15:27:19 --- Affects Prince of Persia The Sands of Time as well which has demo (affected too).
http://bugs.winehq.org/show_bug.cgi?id=16932
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |manuel_jose_silva@hotmail.co | |m
--- Comment #7 from Vitaliy Margolen vitaliy@kievinfo.com 2009-01-18 16:41:45 --- *** Bug 17012 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=16932
Stefan Dösinger stefandoesinger@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stefandoesinger@gmx.at
--- Comment #8 from Stefan Dösinger stefandoesinger@gmx.at 2009-01-19 04:57:46 --- I sent my patches. Patch 5 should hopefully fix this regression, although it doesn't work stand-alone, it needs the previous patches too. Incidentally it looks very similar to the workaround posted here.
I'm sorry that this temporary regression occurred between two releases :-(
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #9 from Rico kgbricola@web.de 2009-01-28 12:35:39 --- It looks like it is fixed in current git, but patches 4 to 7 weren't applied, yet. So it must be fixed by patch 1 to 3. Or am I wrong?
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #10 from Stefan Dösinger stefandoesinger@gmx.at 2009-01-30 04:48:33 --- Ya, the patches collided with some patches from Henri, and I have been busy since and not resent them. Strange that the issue is gone though
http://bugs.winehq.org/show_bug.cgi?id=16932
Rico kgbricola@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #11 from Rico kgbricola@web.de 2009-01-30 13:52:45 --- Fixed by commit 50109aa969ccdc09acd0c4773c7c62a96fd78706 .
http://bugs.winehq.org/show_bug.cgi?id=16932
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Vitaliy Margolen vitaliy@kievinfo.com 2009-01-31 11:35:18 --- Closing fixed in wine-1.1.14
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #13 from Caladan a.vankaam@chello.nl 2009-02-01 11:21:57 --- hi there, I originaly entered bug 16997 which was marked as a duplicate to this bug, now this bug is closed as being fixed in 1.1.14, however the issue is still there. (see bug 16997 for screenshots)
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #14 from Vitaliy Margolen vitaliy@kievinfo.com 2009-02-02 21:28:32 --- (In reply to comment #13) Are you saying you have wine-1.1.14 and it still is not fixed for you?
http://bugs.winehq.org/show_bug.cgi?id=16932
--- Comment #15 from Caladan a.vankaam@chello.nl 2009-02-03 09:32:49 --- (In reply to comment #14)
(In reply to comment #13) Are you saying you have wine-1.1.14 and it still is not fixed for you?
Correct, the symptoms described in bug 16997 (marked a dublicate of this one) created by:
1deafcb5a758ba7c88e498718a3186d6b526fe71 is first bad commit commit 1deafcb5a758ba7c88e498718a3186d6b526fe71 Author: Stefan Dösinger stefan@codeweavers.com Date: Mon Dec 15 19:37:36 2008 +0100
wined3d: Split the remains of state_fog.
:040000 040000 39455d30afadc1d21664e6730064c5028aa2c3eb 91e5b3d98e7cd72aa61dd8eac1058792d5fce9a7 M dlls
are still here with wine 1.1.14, as far as I can tell there is no diffrence between 1.1.13 en 1.1.14, I can created the exact seem screenshots that I made with 1.1.13 and posted in bug 16997.
so how would you like me to proceed ? Re-open this, re-open bug 16997 or created a new bug repport ?