This should move all of the remaining interfaces out of basedoc, except for IDispatchEx (and some fields will still remain); those will be for next MR.
Because all of the remaining interfaces are in the `htmldoc.c` file, and they typically tend to just forward to the HTMLDocumentNode, I'm using some macros inspired by the HTMLWINDOW7_ONEVENT_PROPERTY_\* in `htmlwindow.c` to reduce duplication. The ones that are exceptions are implemented normally without macros.
The first commit converts all of the non-IHTMLDocument\* interfaces because most of the methods are FIXMEs/unimplemented, so splitting it up isn't worth it.
--
v4: mshtml: Move the IHTMLDocument7 interface out of basedoc.
mshtml: Move the IHTMLDocument6 interface out of basedoc.
mshtml: Move the IHTMLDocument5 interface out of basedoc.
mshtml: Move the IHTMLDocument4 interface out of basedoc.
mshtml: Move the IHTMLDocument3 interface out of basedoc.
mshtml: Move the IHTMLDocument2 interface out of basedoc.
mshtml: Move the remaining non-IHTMLDocument* interfaces out of basedoc.
mshtml: Move HTMLDocumentObj implementation to oleobj.c.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1125
On Thu Oct 20 10:02:00 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=125183
> Your paranoid android.
> === debian11 (build log) ===
> Task: Could not create the win32 wineprefix: Failed to disable the crash
> dialogs:
> Task: WineTest did not produce the win32 report
> ```
Why was this merge request accepted when it clearly breaks the creation of 32-bit wineprefixes?
The consequence was predictable, we've lost the 32-bit Wine test results ever since:
https://test.winehq.org/data/patterns-tb-wine.html
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1089#note_11891
This should move all of the remaining interfaces out of basedoc, except for IDispatchEx (and some fields will still remain); those will be for next MR.
Because all of the remaining interfaces are in the `htmldoc.c` file, and they typically tend to just forward to the HTMLDocumentNode, I'm using some macros inspired by the HTMLWINDOW7_ONEVENT_PROPERTY_\* in `htmlwindow.c` to reduce duplication. The ones that are exceptions are implemented normally without macros.
The first commit converts all of the non-IHTMLDocument\* interfaces because most of the methods are FIXMEs/unimplemented, so splitting it up isn't worth it.
--
v3: mshtml: Move the IHTMLDocument7 interface out of basedoc.
mshtml: Move the IHTMLDocument6 interface out of basedoc.
mshtml: Move the IHTMLDocument5 interface out of basedoc.
mshtml: Move the IHTMLDocument4 interface out of basedoc.
mshtml: Move the IHTMLDocument3 interface out of basedoc.
mshtml: Move the IHTMLDocument2 interface out of basedoc.
mshtml: Move the remaining non-IHTMLDocument* interfaces out of basedoc.
mshtml: Move HTMLDocumentObj implementation to oleobj.c.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1125
This is wine-7.0.1-rc1, so not ready yet to merge.
--
This merge request has too many patches to be relayed via email.
Please visit the URL below to see the contents of the merge request.
https://gitlab.winehq.org/wine/wine/-/merge_requests/955