Method decriptor's strings are internally stored in ANSI, and
potentially converted from Unicode using current code page.
Test was expecting loss in Unicode to ANSI conversion.
Adapt test to also support loss-less conversion (that's the case
when code page is UTF-8).
Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=52873
Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1124
This seems to be more correct than what we previously had with fewer lines of code, so I like that. I still don't really like the extra flag I had to add for Nt{Create,Open}Key, but I couldn't find a way to make things work without it. I also checked that Windows doesn't use a similar flag (by iterating over all bit masks).
--
v4: wine.inf: Put the Clients key in the right place.
advapi32/tests: Copy Software\Classes tests from ntdll.
ntdll/tests: Refactor the Software\Classes tests.
ntdll/tests: Factor out the NtEnumerateKey() tests.
kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT.
kernelbase: Remove special Wow6432Node handling from RegCreateKeyEx().
kernelbase: Remove special Wow6432Node handling from RegOpenKeyEx().
server: Don't return the actual 32-bit Software\Classes key.
ntdll/tests: Add some some Software\Classes query and enumerate tests.
ntdll/tests: Test that NtCreateKeyEx() also recursively obtains the Wow6432Node parent.
server: Recursively obtain the Wow6432Node parent.
ntdll/tests: Add some Software\Classes subkey tests.
https://gitlab.winehq.org/wine/wine/-/merge_requests/966
On Thu Oct 20 13:10:51 2022 +0000, eric pouech wrote:
> Hi Hugh,
> IMO, this could be written without using 'goto'
> for example
> ```
> if (console_ioctl(...) && size >= sizeof(...))
> {
> }
> else size = 0;
> HeapFree(...);
> return size;
> ```
Sure. That’s the merged version, which I think @julliard modified.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1107#note_11523