October 2022 - wine-gitlab

Re: [PATCH v5 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon (＠rbernon) 18 Oct '22

18 Oct '22

On Tue Oct 18 17:24:25 2022 +0000, Alexandre Julliard wrote: > I have a feeling that the recent stream of ddraw and d3drm test failures > are also related to this MR. Any ideas? Do you mean the `d3drm.c:4776: Test failed: Cannot create IDirect3DRMDevice2 interface, hr 0x8007000e.` and the `ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000.` kind of errors? The first one seems to be caused by an OOM error. I've seen similar issues in the past when running the tests under llvmpipe, and when multiple D3D devices are initialized. The llvmpipe GL context is memory hungry and it quickly fills the 32-bit address space. This doesn't disculp this changes in any way and it could be very well related, if for some reason the messages here are causing GL contexts to be re-created more often or at different times. For the ddraw issue, I can't guess where it comes from, I believe I've seen the errors before but I'll have to investigate. I'll probably need to re-create the test environment to be sure, these tests tend to be annoying to run as they changes the display modes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/944#note_11182

1 0

[PATCH 0/3] MR1091: Support block spreading across multiple address ranges.
by eric pouech (＠epo) 18 Oct '22

18 Oct '22

This series improves support for blocks which spread across several non contiguous memory chunks. Mingw/Gcc tends to emit quite a few of these, especially in 32bit mode. Now the gaps (between two valid ranges) will no longer be understood as being part of the block, hence potentially hiding valid information lying in other blocks. Note that native doesn't support blocks with multiple ranges of addresses (MSVC stores the information quite differently), so these ranges will be used internally but not exposed to DbgHelp's user. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1091

3 4

[PATCH v2 0/5] MR1072: comctl32: preparation for HPROPSHEETPAGE structure layout changes
by Piotr Caban (＠piotr) 18 Oct '22

18 Oct '22

-- v2: comctl32: Add helper for getting icon from HPROPSHEETPAGE. comctl32: Add helper for getting title from HPROPSHEETPAGE. comctl32: Add helper for loading dialog template from HPROPSHEETPAGE. https://gitlab.winehq.org/wine/wine/-/merge_requests/1072

5 8

[PATCH 0/1] MR1093: dwrite/tests: Use existing to create factory instance.
by Nikolay Sivov (＠nsivov) 18 Oct '22

18 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1093

2 1

[PATCH 0/3] MR1079: wininet/netprofm: Connectivity improvements.
by Gabriel Ivăncescu (＠insn) 18 Oct '22

18 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1079

4 10

Re: [PATCH v5 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Alexandre Julliard (＠julliard) 18 Oct '22

18 Oct '22

I have a feeling that the recent stream of ddraw and d3drm test failures are also related to this MR. Any ideas? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/944#note_11170

1 0

[PATCH v2 0/4] MR1090: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) 18 Oct '22

18 Oct '22

_mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mbctolowe… More information about application crash: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v2: msvcrt: implement missing _mbsupr_s_l CRT function to fix ChessBase 14 crash msvcrt: implement missing _mbslwr_s_l CRT function to fix ChessBase 14 crash msvcrt: implement missing _mbctoupper_l CRT function to fix ChessBase 14 crash msvcrt: implement missing _mbctolower_l CRT function to fix ChessBase 14 crash https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

2 4

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 18 Oct '22

18 Oct '22

On Tue Oct 18 12:28:34 2022 +0000, Rémi Bernon wrote: > Can `current_modref` really still be NULL now if > `LdrGetProcedureAddress` also sets it? Seems like it, although I haven't verified it rigorously. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11165

1 0

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 18 Oct '22

18 Oct '22

On Tue Oct 18 12:28:32 2022 +0000, Rémi Bernon wrote: > I think you can simplify this a bit, by doing `if ((current_modref = > get_modref(...)))`, after saving its previous value, and restoring it > before leaving the CS. > Then I'm not sure what side effects this could have, and maybe it'd be > better to have this specific change separate from the rest? How about ```c RtlEnterCriticalSection( &loader_section ); prev = current_modref; wm = get_modref( module ); if (wm) current_modref = wm; if (!wm) ret = STATUS_DLL_NOT_FOUND; else { ... } current_modref = prev; RtlLeaveCriticalSection( &loader_section ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11162

1 0

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) 18 Oct '22

18 Oct '22

On Tue Oct 18 15:32:53 2022 +0000, Jinoh Kang wrote: > Also note that the forward[1-3] DLLs are exactly designed to test > transitively forwarded exports. Correction: The importer DLL references not only the final DLL but also every intermediate DLL in the forward chain. Intermediate DLLs do not gain any new dependencies, even if they are used in the resolution process of forwarded exports. Only the earliest import DLLs gain dependencies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11161

1 0

2025

2024

2023

2022

wine-gitlab October 2022