Some preliminary cleanups (split off from !969)
- extend an existing `wine_todo` test to show that DDE messages cause spurious calls to IMessageFilter::MessagePending (the same as RPC ones)
I have no current ideas for fixing this, just demonstrating the behavior (before refactoring the code in ways that won't change this)
- extract a helper `com_filter_messagepending` for the interactions between `CoWaitForMultipleHandles` and IMessageFilter::MessagePending
- Pull the remaining use of `PeekMessageW` into the existing `com_peek_message` helper
- one behavior fix, to make `RPC_E_CALL_CANCELED` actually work
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1068
On Fri Oct 14 12:45:38 2022 +0000, Rémi Bernon wrote:
> I'm having a hard time reproducing it, is this with some specific tests?
> The first commit indeed changes some behavior, where it was only
> repositioning the current process windows before and is now
> repositioning all windows from the desktop thread.
> I suspect that it could be about the message being sent to the desktop,
> which is now waiting for all windows to reposition by broadcasting a
> message itself. If they aren't actively processing messages, it could
> probably lock up.
> I created https://gitlab.winehq.org/wine/wine/-/merge_requests/1056 to
> address that issue, but I cannot confirm if it fixes anything. Other
> than that I experienced some random and seldom crashes running
> d3d9:device for instance, but I'm not sure to see how it's related.
I reproduce it by running the full tests, `make testclean test -k` usually hangs somewhere in the d3d tests. !1056 seems to help.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/944#note_10781
Applications calling wined3d_device_context_resolve_sub_resource() on a
deferred context would instead get this scheduled on the immediate context.
Worse, because the original call was intended for a deferred context, we'd do
this without taking the mutex required for immediate contexts, potentially
corrupting the command stream.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1043