On Thu Nov 3 10:12:10 2022 +0000, Piotr Caban wrote:
> I don't know why it crashes on startup on your machine but it's not
> caused by _Condition_variable_notify_one being redefined in multiple .so
> files (I guess you're using no-mingw build of Wine). Maybe there's e.g.
> some kind of memory corruption that happens to be hidden by that change.
> If you don't believe me that it's not the problem - the application
> loads both msvcp120 and msvcp140, there are much more global symbols
> with the same names and you don't see any problem caused by it.
> Please change the commit message (patch title you set with git while
> committing the patch, not only merge request title).
Thanks for the tip I've updated the commit info
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1229#note_12971
_Condition_variable_notify_one and DEFINE_THISCALL_WRAPPER(_Condition_variable_notify_one, 4) are redefined in other dynamic libraries.
Therefore, it caused the problem of global symbol coverage, which caused crash.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1229
With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset.
This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf….
--
v13: win32u: Read mode from the registry if GetCurrentDisplaySettings fails.
win32u: Write display settings to the registry in apply_display_settings.
win32u: Lock display devices while applying display settings.
https://gitlab.winehq.org/wine/wine/-/merge_requests/551