November 2022 - wine-gitlab

[PATCH v5 0/5] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v5: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. comctl32/static: Use CRT allocation functions. comctl32/monthcal: Use CRT allocation functions. comctl32/header: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

3 7

Re: [PATCH v5 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 30 Nov '22

30 Nov '22

It doesn't look like Zebediah is interested in reviewing this. Can any CodeWeavers employee please review this merge request? @nsivov would you mind reviewing it if possible? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/566#note_17982

1 0

[PATCH 0/5] MR1588: Draft: Add windows.system.profile.systemmanufacturers DLL.
by Mohamad Al-Jaf (＠maljaf) 30 Nov '22

30 Nov '22

The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found? On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way? Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1588

5 18

[PATCH v2 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

-- v2: rpcrt4: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

3 3

[PATCH 0/1] MR1605: include: Annotate I_RpcAllocate with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

This gets us a nice warning if memory allocated by this function is freed incorrectly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1605

2 1

[PATCH 0/1] MR1603: wshom: Fix WshNetwork interface definition.
by Nikolay Sivov (＠nsivov) 30 Nov '22

30 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1603

2 1

[PATCH 0/1] MR1602: rpcrt4: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1602

4 4

[PATCH v5 0/1] MR1393: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall.
by Etaash Mathamsetty (＠etaash.mathamsetty) 30 Nov '22

30 Nov '22

fixes bug: https://bugs.winehq.org/show_bug.cgi?id=48989 -- v5: ntoskrnl.exe: Add semi-stub for KeIpiGenericCall. https://gitlab.winehq.org/wine/wine/-/merge_requests/1393

2 1

[PATCH v2 0/1] MR1567: mountmgr: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 30 Nov '22

30 Nov '22

-- v2: mountmgr: Use standard C functions for memory allocation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1567

2 1

[PATCH v4 0/4] MR1502: Draft: winevulkan: wow64 memory mapping using VK_EXT_external_memory_host
by Jacek Caban (＠jacek) 30 Nov '22

30 Nov '22

This MR implements memory mapping for wow64 using VK_EXT_external_memory_host. This has some problems (more below), but overall, it looks promising as a stopgap. It passes D3D tests and works fine in general. For proper solution, we'd need a new Vulkan extension. I experimented with a prototype extension https://github.com/KhronosGroup/Vulkan-Docs/pull/1906 and it looks like we can make it work, my WIP implementation is here https://gitlab.winehq.org/jacek/wine/-/tree/vulkan-map-placed. However, it would be nice to have a fallback working on existing drivers as well. The main problem of this MR is that it breaks Vulkan spec. The main rule it breaks is that according to spec, we should explicitly specify that we plan to use external memory when creating VkBuffer or VkImage. The problem is that we don't know if we will until we bind memory to the buffer. I tried some workarounds for that (delaying actual buffer creation, recreating buffer when needed). I got it mostly working and passing tests without validation errors, but it was more invasive than I'd like and still had other problems. I'd rather avoid that if possible. After looking at Mesa sources, I think that the way this MR breaks the spec should be harmless for its drivers. I don't have the hardware to test with Nvidia. If it works there, I'm tempted to ignore spec violation for now, given that the right path forward is VK_EXT_map_memory_placed anyway. Performance-wise, this MR is sub-optimal because we're limited in what memory types we can use. However, I ran Unigine benchmarks on radv and the difference was marginal. In case of Heaven, it was even slightly faster on wow64, which could be explained by 64-bit Vulkan driver being generally slightly faster, but the difference is too small to draw any conclusion. The last patch is not meant for (eventual) merge, but it's nice for testing the concept. It makes it possible to force using external memory in any kind of Wine build to experiment with its effects without need for wow64. To test that, just set `WINEVULKAN_EXTERNAL_MEMORY` environment variable. -- v4: winevulkan: Introduce debugging environment variables. winevulkan: Use VK_EXT_external_memory_host extension to map memory on wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/1502

3 5

2025

2024

2023

2022

wine-gitlab November 2022