The check was dropped in e392e0ac2846edc25610723c19d6a796372017e1, leaving the dwFlags variable unused.
I have no idea if it was indeed unnecessary or if it was dropped by mistake but either we need to keep the check, or we should remove the variable.
--
v2: winex11: Check pixel format flags in X11DRV_wglChoosePixelFormatARB.
opengl32/tests: Test wglChoosePixelFormatARB flags filters.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1828
We get conhost.exe:tty failures on testbot:
- not for version prior to w1064v1909 (these tests require
pseudo-consoles, which are not implemented in these Windows
version).
- for w1064v1909
- not for W10 versions after w1064v1909.
So, we assume that pseudo-console support is immature in this
Windows version: skip all the remaining test at the first
discrepancy point.
I could have maintained a couple of unit tests for this Windows
version, but decided not to:
- it would make the code more complicated (*),
- it doesn't bring value to Wine
- it would be a pain to maintain.
This patch fixes the (remaining) W10 part of bug below.
Support for W11 will be handled in separate patch (and likely with
properly integrating the results from W11, contrary to this patch).
Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53465
Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1873