December 2022 - wine-gitlab

[PATCH 0/4] MR1775: Fix a few gcc warnings
by Fabian Maurer (＠DarkShadow44) 11 Dec '22

11 Dec '22

Happens on gcc 12.2.0 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1775

2 4

[PATCH 0/2] MR1774: Coverity fixes
by Fabian Maurer (＠DarkShadow44) 11 Dec '22

11 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1774

2 2

[PATCH 0/1] MR1772: ntdll: Make sure xmm6-xmm15 are always restored in unix call dispatcher
by Torge Matthies (＠tmatthies) 11 Dec '22

11 Dec '22

If after a unix call `frame->restore_flags` was not 0 but did not include either `CONTEXT_FLOATING_POINT` or `CONTEXT_XSTATE`, xmm6-xmm15 were not restored to their previous values. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1772

2 1

[PATCH v2 0/7] MR1752: Draft: RFC: Make syscall functions sysv_abi on x64
by Torge Matthies (＠tmatthies) 11 Dec '22

11 Dec '22

This removes 20 `movaps` instructions from every syscall that calls a sysv_abi function, plus an `and` for stack alignment and some other instructions depending on the function. In `NtAllocateLocallyUniqueId` for example this reduces the number of instructions from 63 to 36. I don't entirely understand the llvm-mca output but here are the before and after stats that it outputs for that function: Before Iterations: 100 Instructions: 6300 Total Cycles: 3335 Total uOps: 6300 Dispatch Width: 6 uOps Per Cycle: 1.89 IPC: 1.89 Block RThroughput: 15.0 After Iterations: 100 Instructions: 3600 Total Cycles: 1514 Total uOps: 3600 Dispatch Width: 6 uOps Per Cycle: 2.38 IPC: 2.38 Block RThroughput: 6.0 This currently depends on the stack being aligned by the syscall dispatcher, which afaict is the case if `sizeof(struct syscall_frame) % 16 == 0`. If that is not good enough I can add an `andq $~15,%rsp` somewhere. One question I have is whether we want to continue supporting CDECL syscalls (only `wine_server_call`, `wine_server_fd_to_handle` and `wine_server_handle_to_fd`)? If we do, this adds a bit of complexity to the syscall dispatcher, see the commit "FIXUP ntdll: Support CDECL syscalls." If we don't, and make those syscalls WINAPI instead, then for every call to those functions on x86 it seems to either change nothing or add one `add` instruction. However we of course lose the ability to make CDECL syscalls. -- v2: Revert "ntdll: Make CDECL syscalls WINAPI instead." FIXUP ntdll: Support CDECL syscalls. ntdll: Make syscall functions sysv_abi on x64. ntdll: Make CDECL syscalls WINAPI instead. win32u: Make syscalls use the SYSCALL calling convention. ntdll: Make syscalls use the SYSCALL calling convention. include: Add SYSCALL calling convention. https://gitlab.winehq.org/wine/wine/-/merge_requests/1752

3 12

[PATCH 0/1] MR1771: ntoskrnl.exe: Fake Success for MmMapIoSpace.
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Dec '22

11 Dec '22

originally created by Guy1524 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1771

2 1

[PATCH 0/1] MR1769: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 10 Dec '22

10 Dec '22

When .so module initialization was moved from ntdll to winecrt0 with commit bef09697227c29f53bb0ad95232399cbba5c9c6b we lost a number of include files. This broke FreeBSD-specific code that used BOOL, TRUE, and FALSE. Fix that by using poor man's int, 1, and 0 instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1769

2 1

[PATCH 0/767] MR1767: winecrt0: Avoid predefined BOOL in get_relocbase
by Gerald Pfeifer (＠gerald) 10 Dec '22

10 Dec '22

When .so module initialization was moved from ntdll to winecrt0 with commit bef09697227c29f53bb0ad95232399cbba5c9c6b we lost a number of include files. This broke FreeBSD-specific code that used BOOL, TRUE, and FALSE. Fix that by using poor man's int, 1, and 0 instead. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1767

1 2

[PATCH v2 0/1] MR1633: comctl32: Use strdupAW / strdupWA helpers for CRT allocs.
by Rémi Bernon (＠rbernon) 10 Dec '22

10 Dec '22

Fixing heap mismatches introduced with !1520. -- v2: comctl32: Use CRT heap allocation for some A/W string copies. https://gitlab.winehq.org/wine/wine/-/merge_requests/1633

4 7

[PATCH 0/5] MR1625: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 10 Dec '22

10 Dec '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1625

4 10

[PATCH v3 0/7] MR51: vkd3d-shader/hlsl: Improve constant handling in copy prop, and extend the use of aoffimmi modifiers.
by Francisco Casas (＠fcasas) 10 Dec '22

10 Dec '22

If a hlsl_ir_load loads a variable whose components are stored from different instructions, copy propagation doesn't replace it. But if all these instructions are constants (which currently is the case for value constructors), the load can be replaced with a constant value, which is what the first patch of this series does. For instance, this shader: ``` sampler s; Texture2D t; float4 main() : sv_target { return t.Gather(s, float2(0.6, 0.6), int2(0, 0)); } ``` results in the following IR before applying the patch: ``` float | 6.00000024e-01 float | 6.00000024e-01 uint | 0 | = (<constructor-2>[@4].x @2) uint | 1 | = (<constructor-2>[@6].x @3) float2 | <constructor-2> int | 0 int | 0 uint | 0 | = (<constructor-5>[@11].x @9) uint | 1 | = (<constructor-5>[@13].x @10) int2 | <constructor-5> float4 | gather_red(resource = t, sampler = s, coords = @8, offset = @15) | return | = (<output-sv_target0> @16) ``` and this IR afterwards: ``` float2 | {6.00000024e-01 6.00000024e-01 } int2 | {0 0 } float4 | gather_red(resource = t, sampler = s, coords = @2, offset = @3) | return | = (<output-sv_target0> @4) ``` This is required to write texel_offsets as aoffimmi modifiers in the sm4 backend, since it expects the texel_offset arguments to be hlsl_ir_constant. This series also: * Allows Gather() methods to use aoffimmi modifiers instead of an additional source register (which is the only way allowed for shader model 4.1), when possible. * Adds support to texel_offsets in the Load() method via aoffimmi modifiers (the only allowed method). -- v3: vkd3d-shader/hlsl: Propagate swizzle chains in copy propagation. vkd3d-shader/hlsl: Replace swizzles with constants in copy prop. tests: Test constant propagation through swizzles. vkd3d-shader/hlsl: Support offset argument for the texture Load() method. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/51

2 8

2025

2024

2023

2022

wine-gitlab December 2022