December 2022 - wine-gitlab

[PATCH v3 0/2] MR1321: Reject wic invalid formats
by Zhiyi Zhang (＠zhiyi) 09 Dec '22

09 Dec '22

These invalid formats are rejected when creating WIC render targets. Otherwise, Wine may create a WIC render target with an unsupported format and in turn, will make testing IsSupported() method difficult. -- v3: d2d1: Test creating WIC bitmap render targets. d2d1: Reject unsupported formats when creating WIC bitmap render targets. https://gitlab.winehq.org/wine/wine/-/merge_requests/1321

3 4

[PATCH v8 0/2] MR1046: MfMediaEngine invalid format handling.
by Bernhard Kölbl (＠besentv) 09 Dec '22

09 Dec '22

-- v8: mfmediaengine: Add a fallback when the set engine format cannot be used to init samplegrabber. mfmediaengine/tests: Test possible engine and output texture formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/1046

4 8

[PATCH 0/1] MR1758: comctl32: Switch back to internal allocation function.
by Nikolay Sivov (＠nsivov) 09 Dec '22

09 Dec '22

We are still using exported string functions internally, and that caused mismatches after recent incomplete switching to crt functions. There is also no evidence that crt functions are used at all there, so for now switch back to fix mismatching calls. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1758

2 1

[PATCH v2 0/1] MR1681: uxtheme: Avoid using lstrcmpiW.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

This is called a huge number of time every time the module is loaded. The function does a lot of things, which I believe aren't necessary for uxtheme string comparison. The impact on process startup is noticeable, and this saves ~1min on the Gitlab CI test run. Instead, convert strings to uppercase beforehand in a locale-independent way, and compare with wcscmp. -- v2: uxtheme: Use bsearch and CompareStringOrdinal in MSSTYLES_LookupProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/1681

3 3

[PATCH v3 0/1] MR1681: uxtheme: Avoid using lstrcmpiW.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

This is called a huge number of time every time the module is loaded. The function does a lot of things, which I believe aren't necessary for uxtheme string comparison. The impact on process startup is noticeable, and this saves ~1min on the Gitlab CI test run. Instead, convert strings to uppercase beforehand in a locale-independent way, and compare with wcscmp. -- v3: uxtheme: Use bsearch and CompareStringOrdinal in MSSTYLES_LookupProperty. https://gitlab.winehq.org/wine/wine/-/merge_requests/1681

2 2

[PATCH 0/5] MR1756: ntdll: Various performance improvements to hash_short_file_name.
by Rémi Bernon (＠rbernon) 09 Dec '22

09 Dec '22

The function is called a lot, I believe something like this would improve its performance in general. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1756

2 5

[PATCH v5 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v5: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

4 12

[PATCH v4 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v4: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 9

[PATCH v3 0/7] MR1714: cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync.
by Mohamad Al-Jaf (＠maljaf) 09 Dec '22

09 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53176 1) The async test is broken on Windows 10 1507. This appears to be a trend among WinRT dlls. I'm thinking that we can add macro definitions for each testbot VM to avoid having to skip tests that would otherwise be working fine, and just greater control over tests in general. 2) The provider file that contains `interface IWineAsyncInfoImpl` is likely going to be reused again in the future. Perhaps a new file can be added in the include/wine folder to prevent duplicate code? I can do this in a separate merge request and cleanup the existing provider files. 3) All the check_bool_async tests return a random async_id so I skipped them. Testbot example: https://testbot.winehq.org/JobDetails.pl?Key=127232&f208=exe32.report#k208 -- v3: cryptowinrt/tests: Add IKeyCredentialManagerStatics_IsSupportedAsync tests. cryptowinrt: Implement IKeyCredentialManagerStatics_IsSupportedAsync. cryptowinrt: Import IAsyncOperation from windows.gaming.input. cryptowinrt: Stub IKeyCredentialManagerStatics interface. cryptowinrt: Add private.h file. cryptowinrt/tests: Add ICryptographicBufferStatics interface test. include: Add windows.security.credentials.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1714

3 13

[PATCH 0/1] MR1754: wsdapi: Annotate duplicate_(string|name) with __WINE_MALLOC.
by Alex Henrie (＠alexhenrie) 09 Dec '22

09 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1754

2 1

2025

2024

2023

2022

wine-gitlab December 2022