December 2022 - wine-gitlab

[PATCH v6 0/5] MR54: vkd3d-shader/hlsl: Initialize static variables to 0 by default.
by Francisco Casas (＠fcasas) 11 Jan '23

11 Jan '23

We are currently not initializing static values to zero by default. Consider the following shader: ```hlsl static float4 va; float4 main() : sv_target { return va; } ``` we get the following output: ``` ps_5_0 dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, r1.xyzw mov o0.xyzw, r0.xyzw ret ``` where r1.xyzw is not initialized. This patch solves this by assigning the static variable the value of an uint 0, and thus, relying on complex broadcasts. This seems to be the behaviour of the the native compiler, since it retrieves the following error on a shader that lacks an initializer on a data type with object components: ``` error X3017: cannot convert from 'uint' to 'struct <unnamed>' ``` -- v6: vkd3d-shader/hlsl: Allow uninitialized static objects. vkd3d-shader/hlsl: Validate that non-uniform objects are not referenced. tests: Add additional object references tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/54

6 14

[PATCH 0/1] MR57: tests: Print d3dcompiler_47.dll version when running tests on Windows.
by Giovanni Mascellani (＠giomasce) 11 Jan '23

11 Jan '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/57

4 4

[PATCH v2 0/5] MR47: hlsl: Function calls.
by Zebediah Figura (＠zfigura) 10 Jan '23

10 Jan '23

-- v2: vkd3d-shader/hlsl: Get rid of the "intrinsic" field of struct hlsl_ir_function. vkd3d-shader/hlsl: Forbid returning void expressions from void functions. vkd3d-shader/hlsl: Generate IR for user-defined function calls. vkd3d-shader/hlsl: Avoid assuming that expressions have at least one argument. tests: Test specifying a UAV address as an in/out parameter to a function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/47

3 9

[PATCH 0/1] MR56: vkd3d-shader/hlsl: Fix typo (Coverity)
by Fabian Maurer (＠DarkShadow44) 10 Jan '23

10 Jan '23

I assume this is a typo, right now it doesn't make sense. Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/56

6 7

[PATCH v3 0/9] MR50: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h. (v2) (PART 1/2)
by Francisco Casas (＠fcasas) 10 Jan '23

10 Jan '23

First part of v2 of !38, trying to follow the wide feedback provided. Following patches in: https://gitlab.winehq.org/fcasas/vkd3d/-/tree/documentation -- v3: vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_src. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ir_node. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ctx. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ir_var. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_struct_field. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_type. vkd3d-shader/hlsl: Rename hlsl_struct_field.modifiers to "storage_modifiers". vkd3d-shader/hlsl: Rename hlsl_ir_var.modifiers to "storage_modifiers". vkd3d-shader/hlsl: Rename HLSL_STORAGE_VOLATILE to HLSL_MODIFIER_VOLATILE. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/50

4 11

[PATCH v3 0/1] MR1444: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW
by James McDonnell (＠ElementalWarrior) 08 Jan '23

08 Jan '23

Call MoveFileWithProgress from MoveFileTransacted such that the stub functions. This enables saving for Affinity Photo. -- v3: kernel32: Unstub MoveFileTransactedW, Use MoveFileWithProgressW https://gitlab.winehq.org/wine/wine/-/merge_requests/1444

4 4

[PATCH 0/1] MR1239: winegstreamer: Pause streaming threads when seeking.
by Zhiyi Zhang (＠zhiyi) 08 Jan '23

08 Jan '23

The streaming threads and GST_Seeking_SetPositions() contend for the same flushing locks. GST_Seeking_SetPositions() needs to acquire all the flushing locks before doing the actual stream seeking, having the streaming threads fighting for the same locks will make GST_Seeking_SetPositions() wait for a unusually long time. This reduces PowerPoint 2016 video seeking time from ~5s to almost an instant and fixes a regression for Fallout 3. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53403 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1239

4 6

[PATCH v3 0/1] MR1878: comctl32/listview: Exclude header area in WM_NCPAINT.
by Vladislav Timonin (＠vt) 04 Jan '23

04 Jan '23

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) EDIT1: Actually compared screenshots of 7-Zip file manager and looks like the headers are now painted consistently after highlighting them. ![7zFM-before-hilite](/uploads/64fe3fb80002c847c2e9270337bab4e8/7zFM-before-hilite.png) ![7zFM-after-hilite](/uploads/4db4778c2ad6d27eddbd4a1202b41881/7zFM-after-hilite.png) -- v3: comctl32/listview: Exclude header area in WM_NCPAINT. https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

4 4

[PATCH v3 0/6] MR53: vkd3d-shader/hlsl: transpose(), smoothstep(), and properly convert args of element-wise intrinsics.
by Francisco Casas (＠fcasas) 03 Jan '23

03 Jan '23

This patch series includes an implementation of the long-pending `transpose` intrinsic and the `smoothstep` intrinsic. While implementing `smoothstep` I realized that some intrinsics have different rules for the allowed data types than expressions: - Vectors and matrices at the same time are not allowed, regardless of their dimensions. Even if they have the same number of components. - Any combination of matrices is always allowed, even those when no matrix fits inside another, e.g.: `float2x3` is compatible with `float3x2`, resulting in `float2x2`. The common data type is the min on each dimension. This is the case for `max`, `pow`, `ldexp`, `clamp` and `smoothstep`; which suggest that it is the case for all intrinsics where the operation is applied element-wise. So this was corrected. A minor fix in `pow`'s type conversion is also included. -- v3: vkd3d-shader/hlsl: Use add_unary_arithmetic_expr() in intrinsic_pow(). vkd3d-shader/hlsl: Allow elementwise_intrinsic_convert_args() to also convert args to float. vkd3d-shader/hlsl: Convert elementwise intrinsics args to the proper common type. tests: Test for common type conversion for element-wise intrinsics. vkd3d-shader/hlsl: Support smoothstep() intrinsic. vkd3d-shader/hlsl: Support transpose() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/53

3 8

[PATCH v2 0/1] MR1884: d3d8: Filter out redundant buffer discards.
by Zebediah Figura (＠zfigura) 03 Jan '23

03 Jan '23

I was unable to write tests for this; it seems it doesn't consistently work on Windows. However, Rayman 3 seems to rely on it; it maps the same buffer twice immediately after creation, with DISCARD flags on both maps, and expects the same address to be returned. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53752 -- v2: d3d8: Filter out redundant buffer discards. https://gitlab.winehq.org/wine/wine/-/merge_requests/1884

3 2

2025

2024

2023

2022

wine-gitlab December 2022