July 2022 - wine-gitlab

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 11 Jul '22

11 Jul '22

the test would hang on wine before the implementation is in place. the CloseHandle before the WaitForSingleObject is a workaround to get the thread to exit moving the CloseHandle was meant to show that workaround is no longer needed and that it now performs like windows i can remove that if preferred -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3840

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 10 Jul '22

10 Jul '22

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/file.c: > */ > NTSTATUS WINAPI NtCancelSynchronousIoFile( HANDLE handle, IO_STATUS_BLOCK *io, IO_STATUS_BLOCK *io_status ) > { > - FIXME( "(%p,%p,%p) stub\n", handle, io, io_status ); > - return STATUS_NOT_IMPLEMENTED; > + NTSTATUS status; > + > + TRACE( "(%p %p %p)\n", handle, io, io_status ); I'd at least leave a "partial fixme" here, since this is, after all, a partial implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3835

2 1

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 10 Jul '22

10 Jul '22

On Sun Jul 10 17:41:41 2022 +0000, Jinoh Kang wrote: > I'd at least leave a "partial fixme" here, since this is, after all, a > partial implementation. will do still isn't clear to me what the 2nd argument does. 32-bit windows treats it differently from 64-bit windows, but only in the returned ntstatus. doesn't seem to affect the intended behavior -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3838

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 10 Jul '22

10 Jul '22

Jinoh Kang (@iamahuman) commented about dlls/ntdll/tests/pipe.c: > Sleep(100); > memset(&iosb, 0x55, sizeof(iosb)); > res = pNtCancelSynchronousIoFile(thread, NULL, &iosb); > - todo_wine { > ok(res == STATUS_SUCCESS, "Failed to cancel I/O\n"); > ok(U(iosb).Status == STATUS_SUCCESS, "iosb.Status got changed to %lx\n", U(iosb).Status); > ok(U(iosb).Information == 0, "iosb.Information got changed to %Iu\n", U(iosb).Information); > - CloseHandle(ctx.pipe); > WaitForSingleObject(thread, INFINITE); > CloseHandle(thread); > + CloseHandle(ctx.pipe); Any reason why the call to `CloseHandle` is being moved? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3837

1 0

[PATCH 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) 10 Jul '22

10 Jul '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/414

2 3

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 10 Jul '22

10 Jul '22

@julliard does this look ok? there anything i should change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3831

1 0

[PATCH 0/4] MR413: ntoskrnl: Enumerate child devices on a separate thread.
by Zebediah Figura (＠zfigura) 09 Jul '22

09 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/413

2 4

[PATCH 0/1] MR412: wineusb.sys: Fix memory leak on control transfer.
by Jinoh Kang (＠iamahuman) 09 Jul '22

09 Jul '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/412

3 5

[PATCH v8 0/1] MR320: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo (#53289).
by Jinoh Kang (＠iamahuman) 09 Jul '22

09 Jul '22

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v8: riched20/tests: Test for ITextDocument::Undo and ITextDocument::Redo. https://gitlab.winehq.org/wine/wine/-/merge_requests/320

2 2

[PATCH v2 0/1] MR408: ntdll: Fix x64 single step exception detection on macOS.
by Piotr Caban (＠piotr) 09 Jul '22

09 Jul '22

On macOS si_code is always set to TRAP_BRKPT. -- v2: ntdll: Fix x64 single step exception detection on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/408

3 2

2025

2024

2023

2022

wine-gitlab July 2022