August 2022 - wine-gitlab

Re: [PATCH v8 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Chip Davis (＠cdavis5e) 02 Aug '22

02 Aug '22

> Is there any way to manually trigger the test bot? You can submit patches yourself to [the testbot](https://testbot.winehq.org/). Note that you will need an account on the testbot in order to do this, which I believe is separate from your account here. > the pipeline fails due to a (more or less) unrelated issue in another dll (msi). They have a function with the same name, DllGetVersion. That is because `DllGetVersion()` is also the name of an optional function supported by COM server DLLs. That's what those definitions in `<shlwapi.h>` are for. > Could it be that the dev defined it in shlwapi.h? The issue is that I can't define my function correctly with this definition (probably the reason why the first implementation used it, wrongly), but they can't use it without (or probably can, but didn't). Or, you could give `cabinet`'s `DllGetVersion()` a new name, and then in `cabinet.spec`, export the new name under the correct name: ``` 2 stdcall -private DllGetVersion(ptr) cabinet_dll_get_version ``` (Why did you remove the ordinals? The commit in which this happened has somehow vanished, but I remember seeing that.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5469

1 0

[PATCH v4 0/6] MR561: winex11.drv: Use DEVMODEW instead of x11drv_display_setting.
by Rémi Bernon (＠rbernon) 02 Aug '22

02 Aug '22

In preparation for moving display placement to win32u, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551. The idea for win32u to enumerate and work with full modes, with driver extra data, to do the display placement logic and validation, and pass the modes array for all adapters at once to the driver to apply them. -- v4: winex11.drv: Constify set_current_mode DEVMODEW parameter. winex11.drv: Iterate display settings using dmDriverExtra. winex11.drv: Use DEVMODEW instead of x11drv_display_setting. winex11.drv: Update devmode dmPosition instead of new_rect. winex11.drv: Use DM_POSITION field bit to mark placed displays. winex11.drv: Use a local desired_rect variable when placing displays. https://gitlab.winehq.org/wine/wine/-/merge_requests/561

3 7

[PATCH v5 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 02 Aug '22

02 Aug '22

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v5: comctl32/tests: Add more ownerdata listview tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 9

[PATCH 0/1] MR571: ntdll: Fix floating point registers not being restored under Wow64.
by Brendan Shanks (＠bshanks) 01 Aug '22

01 Aug '22

This bug showed up on macOS Wow64 where XMM registers weren't being restored after an exception. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/571

2 2

Re: [PATCH v8 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 01 Aug '22

01 Aug '22

On Mon Aug 1 21:34:19 2022 +0000, Tobias G��rgens wrote: > I'll slowly add/improve commits after the test results are available, I > don't want to delete every commit again lol > Is there any way to manually trigger the test bot? the pipeline fails due to an unrelated issue in another dll. They have a function with the same name, DllGetVersion. Could it be that the dev defined it in shlwapi.h? The issue is that I can't declare my function correctly with this definition (probably the reason why the first implementation used it, wrongly). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5462

1 0

Re: [PATCH v8 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 01 Aug '22

01 Aug '22

On Mon Aug 1 19:43:52 2022 +0000, Bernhard K��lbl wrote: > Tests cannot fail in their own commit. You need to denote stuff, that's > going to be implemented with todo_wine, which expects a failure. Then > the commit message for tests needs to be cabinet/tests: I'll slowly add/improve commits after the test results are available, I don't want to delete every commit again lol Is there any way to manually trigger the test bot? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5461

1 0

[PATCH v2 0/3] MR393: wmvcore: Asynchronous reader state transitions.
by Rémi Bernon (＠rbernon) 01 Aug '22

01 Aug '22

Before https://gitlab.winehq.org/wine/wine/-/merge_requests/140, and to avoid a situation in the future where we might decide to implement this, and where the callback would be called asynchronously as they are supposed to, without the ASF reader filter supporting it. -- v2: winegstreamer: Make IWMReader state transitions asynchronous. winegstreamer: Move IWMReaderCallbackAdvanced *callback_advanced to a local variable. wmvcore/tests: Add more IWMReader_(Open|Start|Stop|Close) async checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/393

3 7

[PATCH v6 0/3] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens (＠tobi.goergens) 01 Aug '22

01 Aug '22

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v6: cabinet: Implement GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

3 5

[PATCH 0/1] MR572: ntdll: Use correct mcontext struct on macOS under Wow64.
by Brendan Shanks (＠bshanks) 01 Aug '22

01 Aug '22

This bug was causing incorrect FPU state to be read under Wow64 on macOS. This use of different mcontext structures is only documented in Apple's kernel source, most helpfully a test program for custom LDTs: https://github.com/apple-oss-distributions/xnu/blob/e7776783b89a353188416a9… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/572

2 1

[PATCH 0/3] MR568: mshtml: MediaQueryList semi-implementation.
by Gabriel Ivăncescu (＠insn) 01 Aug '22

01 Aug '22

This doesn't implement the listeners (needs wine-gecko notification). Also "media" seems to return somewhat different strings on gecko in some cases, so some of the tests are todo_wine because of that, but I'm not sure if it's worth replicating in practice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/568

3 4

2025

2024

2023

2022

wine-gitlab August 2022