September 2022 - wine-gitlab

[PATCH 0/1] MR958: vbscript: don't abort when trying to TRACE() functions with many arguments.
by Kevin Puetz (＠puetzk) 29 Sep '22

29 Sep '22

__wine_dbg_output accumulates the output characters in a debug_info structure, flushing it when it encounters '\n'. If debug_info plus the new string exceed 1024 characters, append_output will print > wine_dbg_output: debugstr buffer overflow and then crash the process via abort(). wine_dbgstr_variant limits the length printed for any individual argument, but a function with multiple parameters can still plausibly exceed 1024. Fixed by formatting the TRACE for each argument on a separate line, as similar places (like oleaut32/typelib.c:dump_DispParms) do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/958

3 2

[PATCH v3 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon (＠rbernon) 29 Sep '22

29 Sep '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- v3: winemac.drv: Resize desktop window on WM_DISPLAYCHANGE message. winex11.drv: Resize desktop window on WM_DISPLAYCHANGE message. win32u: Send WM_DISPLAYCHANGE message to the desktop window. winex11.drv: Send WM_X11DRV_CLIP_CURSOR_REQUEST message from the deskop. winex11.drv: Sync window positions in a WM_X11DRV_DESKTOP_RESIZED message. https://gitlab.winehq.org/wine/wine/-/merge_requests/944

3 11

[PATCH v5 0/5] MR932: comctl32: propsheet tests
by Piotr Caban (＠piotr) 29 Sep '22

29 Sep '22

-- v5: comctl32: Don't pass PROPSHEETPAGE to SetWindowSubclass in PROPSHEET_CreatePage. https://gitlab.winehq.org/wine/wine/-/merge_requests/932

3 7

[PATCH 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)
by Joel Holdsworth (＠jhol) 29 Sep '22

29 Sep '22

This patch set is based upon [patches from Wine Staging](https://github.com/wine-staging/wine-staging/tree/master/patches/n… by Erich E. Hoover (@ehoover), and implements support for the `SYSTEM`, `HIDDEN` and `READONLY` DOS file attributes. These can implemented in various ways depending upon the capabilities of the operating system and the file system. However, this initial patch-set focusses on just one method: Samba-formatted Extended File Attributes. Modern filesystems generally support Extended File Attributes - auxiliary blobs of binary data that can be attached to a file. Samba uses the `user.DOSATTRIB` attribute to store DOS attribute information in the form of a hexadecimal value, and this patch-set implements a compatible mechanism. Support for additional storage methods to increase operating system and filesystem compatibility is planned for later patch submissions. This effort is part of a larger project I have been working on to get Msys2 and Cygwin working properly on Wine. The absence of DOS fule attribute support prevents one of the modes that Cygwin and Msys2 can use to emulate symbolic links from working correctly, which causes the Cygwin installer to fail: https://bugs.winehq.org/show_bug.cgi?id=15679 See Also * https://bugs.winehq.org/show_bug.cgi?id=9158 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/951

7 18

[PATCH v4 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 29 Sep '22

29 Sep '22

Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> -- v4: kernelbase: Call NtCancelSynchronousIoFile in CancelSynchronousIo. ntdll: Implement NtCancelSynchronousIoFile. ntdll: Add NtCancelSynchronousIoFile stub. kernel32/tests: Add tests for CancelSynchronousIo. https://gitlab.winehq.org/wine/wine/-/merge_requests/47

3 8

[PATCH 0/1] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Kevin Puetz (＠puetzk) 28 Sep '22

28 Sep '22

It's possible for a proxy to be released during the middle of an Invoke. A specific scenario where this happened was a single-shot event sink which, upon receiving the event it was waiting for, would immediately call DispEventUnadvise. This removed the proxy pointing to that sink from the connection point's list of subscribers and released it. For such cases all state used to complete the Invoke must be owned by the __proxy_frame kept on the stack; after calling NdrProxySendReceive (which pumps STA messages and permits reentrancy), anything inside *This could be use-after-free. MIDL_STUB_MESSAGE already had its own IRPCChannelBuffer *pRpcChannelBuffer, but lacked its own refcount. When this does crash, the exception is caught by RpcTryFinally, but still leads to leaks since NdrProxyFreeBuffer wasn't able to call IRPCChannelBuffer::FreeBuffer. To fix this, StdProxy_GetChannel() now calls AddRef() when setting __proxy_frame::_StubMsg::pRpcChannelBuffer and NdrProxyFreeBuffer() calls the corresponding Release(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957

2 1

[PATCH 0/7] MR936: winegstreamer: Test and implement WM sync reader allocation methods.
by Rémi Bernon (＠rbernon) 28 Sep '22

28 Sep '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/936

4 15

Re: [PATCH v2 0/1] MR954: tests: Print unhandled exception messages in colour. - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/954

1 0

Re: [PATCH v3 0/1] MR945: msi: Disable FS redirection for temporary file in cabinet_copy_file(). - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/945

1 0

Re: [PATCH v3 0/1] MR948: winegstreamer: Fix memory leak in get_available_media_type (Coverity). - approved
by Alexandre Julliard (＠julliard) 28 Sep '22

28 Sep '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/948

1 0

2025

2024

2023

2022

wine-gitlab September 2022